| Message ID | 1525754479-12177-18-git-send-email-allison.henderson@oracle.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
On Mon, May 07, 2018 at 09:41:15PM -0700, Allison Henderson wrote: > Signed-off-by: Allison Henderson <allison.henderson@oracle.com> Needs a commit message. Eric might also want the xfs_io bit as a separate patch to keep this one as close to the kernel patch as possible. (Though really, it's a single line, maybe not...) --D > --- > io/inject.c | 1 + > libxfs/xfs_errortag.h | 5 ++++- > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/io/inject.c b/io/inject.c > index fc3cf25..2d6cc9c 100644 > --- a/io/inject.c > +++ b/io/inject.c > @@ -63,6 +63,7 @@ error_tag(char *name) > { XFS_ERRTAG_LOG_BAD_CRC, "log_bad_crc" }, > { XFS_ERRTAG_LOG_ITEM_PIN, "log_item_pin" }, > { XFS_ERRTAG_BUF_LRU_REF, "buf_lru_ref" }, > + { XFS_ERRTAG_DELAYED_ATTR, "delayed_attr" }, > { XFS_ERRTAG_MAX, NULL } > }; > int count; > diff --git a/libxfs/xfs_errortag.h b/libxfs/xfs_errortag.h > index bc1789d..f606ab6 100644 > --- a/libxfs/xfs_errortag.h > +++ b/libxfs/xfs_errortag.h > @@ -65,7 +65,8 @@ > #define XFS_ERRTAG_LOG_BAD_CRC 29 > #define XFS_ERRTAG_LOG_ITEM_PIN 30 > #define XFS_ERRTAG_BUF_LRU_REF 31 > -#define XFS_ERRTAG_MAX 32 > +#define XFS_ERRTAG_DELAYED_ATTR 32 > +#define XFS_ERRTAG_MAX 33 > > /* > * Random factors for above tags, 1 means always, 2 means 1/2 time, etc. > @@ -102,5 +103,7 @@ > #define XFS_RANDOM_LOG_BAD_CRC 1 > #define XFS_RANDOM_LOG_ITEM_PIN 1 > #define XFS_RANDOM_BUF_LRU_REF 2 > +#define XFS_RANDOM_DELAYED_ATTR 1 > > #endif /* __XFS_ERRORTAG_H_ */ > + > -- > 2.7.4 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-xfs" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
On 5/8/18 12:21 PM, Darrick J. Wong wrote: > On Mon, May 07, 2018 at 09:41:15PM -0700, Allison Henderson wrote: >> Signed-off-by: Allison Henderson <allison.henderson@oracle.com> > > Needs a commit message. Eric might also want the xfs_io bit as a > separate patch to keep this one as close to the kernel patch as > possible. > > (Though really, it's a single line, maybe not...) I generally port libxfs to xfsprogs after it's hit the kernel, and then fix stuff up as needed, which usually means "fix it so it builds again." Stuff like this would get missed under that plan, so yes, a separate patch to "enhance" xfs_io like this would be appreciated, to be sure I don't miss it. Thanks, -Eric -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/io/inject.c b/io/inject.c index fc3cf25..2d6cc9c 100644 --- a/io/inject.c +++ b/io/inject.c @@ -63,6 +63,7 @@ error_tag(char *name) { XFS_ERRTAG_LOG_BAD_CRC, "log_bad_crc" }, { XFS_ERRTAG_LOG_ITEM_PIN, "log_item_pin" }, { XFS_ERRTAG_BUF_LRU_REF, "buf_lru_ref" }, + { XFS_ERRTAG_DELAYED_ATTR, "delayed_attr" }, { XFS_ERRTAG_MAX, NULL } }; int count; diff --git a/libxfs/xfs_errortag.h b/libxfs/xfs_errortag.h index bc1789d..f606ab6 100644 --- a/libxfs/xfs_errortag.h +++ b/libxfs/xfs_errortag.h @@ -65,7 +65,8 @@ #define XFS_ERRTAG_LOG_BAD_CRC 29 #define XFS_ERRTAG_LOG_ITEM_PIN 30 #define XFS_ERRTAG_BUF_LRU_REF 31 -#define XFS_ERRTAG_MAX 32 +#define XFS_ERRTAG_DELAYED_ATTR 32 +#define XFS_ERRTAG_MAX 33 /* * Random factors for above tags, 1 means always, 2 means 1/2 time, etc. @@ -102,5 +103,7 @@ #define XFS_RANDOM_LOG_BAD_CRC 1 #define XFS_RANDOM_LOG_ITEM_PIN 1 #define XFS_RANDOM_BUF_LRU_REF 2 +#define XFS_RANDOM_DELAYED_ATTR 1 #endif /* __XFS_ERRORTAG_H_ */ +
Signed-off-by: Allison Henderson <allison.henderson@oracle.com> --- io/inject.c | 1 + libxfs/xfs_errortag.h | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-)