diff mbox series

[07/18] libxfs: silence static warnings about platform_* functions

Message ID 1539201682-22198-8-git-send-email-sandeen@redhat.com (mailing list archive)
State Accepted
Headers show
Series xfsprogs: finer-grained sparse fixes | expand

Commit Message

Eric Sandeen Oct. 10, 2018, 8:01 p.m. UTC
Add all platform_* prototypes to init.h and include it in linux.c
to silence sparse warnings about static functions.

Signed-off-by: Eric Sandeen <sandeen@redhat.com>
---
 libfrog/linux.c | 1 +
 libxfs/init.h   | 2 ++
 2 files changed, 3 insertions(+)

Comments

Christoph Hellwig Oct. 11, 2018, 6 a.m. UTC | #1
On Wed, Oct 10, 2018 at 03:01:11PM -0500, Eric Sandeen wrote:
> Add all platform_* prototypes to init.h and include it in linux.c
> to silence sparse warnings about static functions.
> 
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/libfrog/linux.c b/libfrog/linux.c
index fc9f3ac..b6c2487 100644
--- a/libfrog/linux.c
+++ b/libfrog/linux.c
@@ -11,6 +11,7 @@ 
 
 #include "libxfs_priv.h"
 #include "xfs_fs.h"
+#include "init.h"
 
 extern char *progname;
 static int max_block_alignment;
diff --git a/libxfs/init.h b/libxfs/init.h
index e0b5091..2cda895 100644
--- a/libxfs/init.h
+++ b/libxfs/init.h
@@ -19,5 +19,7 @@  extern char *platform_findblockpath (char *path);
 extern int platform_direct_blockdev (void);
 extern int platform_align_blockdev (void);
 extern unsigned long platform_physmem(void);	/* in kilobytes */
+extern void platform_findsizes(char *path, int fd, long long *sz, int *bsz);
+extern int platform_nproc(void);
 
 #endif	/* LIBXFS_INIT_H */