| Message ID | 155173434839.767.14812800687954592485.stgit@magnolia (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | fstests: various fixes | expand |
On Mon, Mar 04, 2019 at 01:19:08PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > Helper functions are supposed to have a leading underscore ('_') in the > function name, but this one doesn't have it. Unfortunately, the calling > test cases (generic/349-351) /do/ have the leading underscore, so now > they're broken. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > --- > common/rc | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/common/rc b/common/rc > index 8b40aabe..1c42515f 100644 > --- a/common/rc > +++ b/common/rc > @@ -3834,7 +3834,7 @@ _get_max_file_size() > } > > # get MAX_LFS_FILESIZE > -get_max_lfs_filesize() > +_get_max_lfs_filesize() I introduced this bug on commit when renaming the function, I remembered I did test it before pushing it out.. Thanks for fixing it! Eryu > { > case "$(getconf LONG_BIT)" in > "32") >
diff --git a/common/rc b/common/rc index 8b40aabe..1c42515f 100644 --- a/common/rc +++ b/common/rc @@ -3834,7 +3834,7 @@ _get_max_file_size() } # get MAX_LFS_FILESIZE -get_max_lfs_filesize() +_get_max_lfs_filesize() { case "$(getconf LONG_BIT)" in "32")