| Message ID | 156757182904.1838441.1851639472366955352.stgit@magnolia (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfsprogs-5.3: various fixes | expand |
On 9/3/19 11:37 PM, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > Amend the fs geometry ioctl documentation to cover the new v5 structure. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Seems fine; I wonder if we should have a some details in here about how we rev this interface as it's a bit unusual, but this follows history I guess. Reviewed-by: Eric Sandeen <sandeen@redhat.com> > --- > man/man2/ioctl_xfs_fsop_geometry.2 | 8 ++++++++ > 1 file changed, 8 insertions(+) > > > diff --git a/man/man2/ioctl_xfs_fsop_geometry.2 b/man/man2/ioctl_xfs_fsop_geometry.2 > index 68e3387d..365bda8b 100644 > --- a/man/man2/ioctl_xfs_fsop_geometry.2 > +++ b/man/man2/ioctl_xfs_fsop_geometry.2 > @@ -12,6 +12,8 @@ ioctl_xfs_fsop_geometry \- report XFS filesystem layout and features > .PP > .BI "int ioctl(int " fd ", XFS_IOC_FSOP_GEOMETRY, struct xfs_fsop_geom*" arg ); > .br > +.BI "int ioctl(int " fd ", XFS_IOC_FSOP_GEOMETRY_V4, struct xfs_fsop_geom_v4 *" arg ); > +.br > .BI "int ioctl(int " fd ", XFS_IOC_FSOP_GEOMETRY_V1, struct xfs_fsop_geom_v1 *" arg ); > .SH DESCRIPTION > Report the details of an XFS filesystem layout, features, and other descriptive items. > @@ -43,6 +45,9 @@ struct xfs_fsop_geom { > /* struct xfs_fsop_geom_v1 stops here. */ > > __u32 logsunit; > + /* struct xfs_fsop_geom_v4 stops here. */ > + > + __u64 reserved[18]; > }; > .fi > .in > @@ -124,6 +129,9 @@ underlying log device, in filesystem blocks. > This field is meaningful only if the flag > .B XFS_FSOP_GEOM_FLAGS_LOGV2 > is set. > +.PP > +.I reserved > +is set to zero. > .SH FILESYSTEM FEATURE FLAGS > Filesystem features are reported to userspace as a combination the following > flags: >
diff --git a/man/man2/ioctl_xfs_fsop_geometry.2 b/man/man2/ioctl_xfs_fsop_geometry.2 index 68e3387d..365bda8b 100644 --- a/man/man2/ioctl_xfs_fsop_geometry.2 +++ b/man/man2/ioctl_xfs_fsop_geometry.2 @@ -12,6 +12,8 @@ ioctl_xfs_fsop_geometry \- report XFS filesystem layout and features .PP .BI "int ioctl(int " fd ", XFS_IOC_FSOP_GEOMETRY, struct xfs_fsop_geom*" arg ); .br +.BI "int ioctl(int " fd ", XFS_IOC_FSOP_GEOMETRY_V4, struct xfs_fsop_geom_v4 *" arg ); +.br .BI "int ioctl(int " fd ", XFS_IOC_FSOP_GEOMETRY_V1, struct xfs_fsop_geom_v1 *" arg ); .SH DESCRIPTION Report the details of an XFS filesystem layout, features, and other descriptive items. @@ -43,6 +45,9 @@ struct xfs_fsop_geom { /* struct xfs_fsop_geom_v1 stops here. */ __u32 logsunit; + /* struct xfs_fsop_geom_v4 stops here. */ + + __u64 reserved[18]; }; .fi .in @@ -124,6 +129,9 @@ underlying log device, in filesystem blocks. This field is meaningful only if the flag .B XFS_FSOP_GEOM_FLAGS_LOGV2 is set. +.PP +.I reserved +is set to zero. .SH FILESYSTEM FEATURE FLAGS Filesystem features are reported to userspace as a combination the following flags: