| Message ID | 156897334377.20210.1896184598481042341.stgit@fedora-28 (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xfs: mount API patch series | expand |
On Fri, Sep 20, 2019 at 05:55:43PM +0800, Ian Kent wrote: > It appears the biosize mount option hasn't been documented as > a vilid option since 2005. > > So remove it. > > Signed-off-by: Ian Kent <raven@themaw.net> > --- Works for me: Reviewed-by: Brian Foster <bfoster@redhat.com> > fs/xfs/xfs_super.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c > index f9450235533c..1010097354a6 100644 > --- a/fs/xfs/xfs_super.c > +++ b/fs/xfs/xfs_super.c > @@ -51,7 +51,7 @@ static struct xfs_kobj xfs_dbg_kobj; /* global debug sysfs attrs */ > * Table driven mount option parser. > */ > enum { > - Opt_logbufs, Opt_logbsize, Opt_logdev, Opt_rtdev, Opt_biosize, > + Opt_logbufs, Opt_logbsize, Opt_logdev, Opt_rtdev, > Opt_wsync, Opt_noalign, Opt_swalloc, Opt_sunit, Opt_swidth, Opt_nouuid, > Opt_grpid, Opt_nogrpid, Opt_bsdgroups, Opt_sysvgroups, > Opt_allocsize, Opt_norecovery, Opt_inode64, Opt_inode32, Opt_ikeep, > @@ -67,7 +67,6 @@ static const match_table_t tokens = { > {Opt_logbsize, "logbsize=%s"}, /* size of XFS log buffers */ > {Opt_logdev, "logdev=%s"}, /* log device */ > {Opt_rtdev, "rtdev=%s"}, /* realtime I/O device */ > - {Opt_biosize, "biosize=%u"}, /* log2 of preferred buffered io size */ > {Opt_wsync, "wsync"}, /* safe-mode nfs compatible mount */ > {Opt_noalign, "noalign"}, /* turn off stripe alignment */ > {Opt_swalloc, "swalloc"}, /* turn on stripe width allocation */ > @@ -229,7 +228,6 @@ xfs_parseargs( > return -ENOMEM; > break; > case Opt_allocsize: > - case Opt_biosize: > if (suffix_kstrtoint(args, 10, &iosize)) > return -EINVAL; > iosizelog = ffs(iosize) - 1; >
diff --git a/fs/xfs/xfs_super.c b/fs/xfs/xfs_super.c index f9450235533c..1010097354a6 100644 --- a/fs/xfs/xfs_super.c +++ b/fs/xfs/xfs_super.c @@ -51,7 +51,7 @@ static struct xfs_kobj xfs_dbg_kobj; /* global debug sysfs attrs */ * Table driven mount option parser. */ enum { - Opt_logbufs, Opt_logbsize, Opt_logdev, Opt_rtdev, Opt_biosize, + Opt_logbufs, Opt_logbsize, Opt_logdev, Opt_rtdev, Opt_wsync, Opt_noalign, Opt_swalloc, Opt_sunit, Opt_swidth, Opt_nouuid, Opt_grpid, Opt_nogrpid, Opt_bsdgroups, Opt_sysvgroups, Opt_allocsize, Opt_norecovery, Opt_inode64, Opt_inode32, Opt_ikeep, @@ -67,7 +67,6 @@ static const match_table_t tokens = { {Opt_logbsize, "logbsize=%s"}, /* size of XFS log buffers */ {Opt_logdev, "logdev=%s"}, /* log device */ {Opt_rtdev, "rtdev=%s"}, /* realtime I/O device */ - {Opt_biosize, "biosize=%u"}, /* log2 of preferred buffered io size */ {Opt_wsync, "wsync"}, /* safe-mode nfs compatible mount */ {Opt_noalign, "noalign"}, /* turn off stripe alignment */ {Opt_swalloc, "swalloc"}, /* turn on stripe width allocation */ @@ -229,7 +228,6 @@ xfs_parseargs( return -ENOMEM; break; case Opt_allocsize: - case Opt_biosize: if (suffix_kstrtoint(args, 10, &iosize)) return -EINVAL; iosizelog = ffs(iosize) - 1;
It appears the biosize mount option hasn't been documented as a vilid option since 2005. So remove it. Signed-off-by: Ian Kent <raven@themaw.net> --- fs/xfs/xfs_super.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)