diff mbox series

xfs: removed unused error variable from xchk_refcountbt_rec

Message ID 1569851934-10718-1-git-send-email-aliasgar.surti500@gmail.com (mailing list archive)
State Accepted
Headers show
Series xfs: removed unused error variable from xchk_refcountbt_rec | expand

Commit Message

Aliasgar Surti Sept. 30, 2019, 1:58 p.m. UTC 
From: Aliasgar Surti <aliasgar.surti500@gmail.com>

Removed unused error variable. Instead of using error variable,
returned the value directly as it wasn't updated.

Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
---
 fs/xfs/scrub/refcount.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

Comments

Brian Foster Sept. 30, 2019, 5:04 p.m. UTC | #1 
On Mon, Sep 30, 2019 at 07:28:54PM +0530, Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
> 
> Removed unused error variable. Instead of using error variable,
> returned the value directly as it wasn't updated.
> 
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>
> ---

Reviewed-by: Brian Foster <bfoster@redhat.com>

>  fs/xfs/scrub/refcount.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/scrub/refcount.c b/fs/xfs/scrub/refcount.c
> index 93b3793b..0cab11a 100644
> --- a/fs/xfs/scrub/refcount.c
> +++ b/fs/xfs/scrub/refcount.c
> @@ -341,7 +341,6 @@ xchk_refcountbt_rec(
>  	xfs_extlen_t		len;
>  	xfs_nlink_t		refcount;
>  	bool			has_cowflag;
> -	int			error = 0;
>  
>  	bno = be32_to_cpu(rec->refc.rc_startblock);
>  	len = be32_to_cpu(rec->refc.rc_blockcount);
> @@ -366,7 +365,7 @@ xchk_refcountbt_rec(
>  
>  	xchk_refcountbt_xref(bs->sc, bno, len, refcount);
>  
> -	return error;
> +	return 0;
>  }
>  
>  /* Make sure we have as many refc blocks as the rmap says. */
> -- 
> 2.7.4
>
Darrick J. Wong Sept. 30, 2019, 6:24 p.m. UTC | #2 
On Mon, Sep 30, 2019 at 07:28:54PM +0530, Aliasgar Surti wrote:
> From: Aliasgar Surti <aliasgar.surti500@gmail.com>
> 
> Removed unused error variable. Instead of using error variable,
> returned the value directly as it wasn't updated.
> 
> Signed-off-by: Aliasgar Surti <aliasgar.surti500@gmail.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

--D

> ---
>  fs/xfs/scrub/refcount.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/fs/xfs/scrub/refcount.c b/fs/xfs/scrub/refcount.c
> index 93b3793b..0cab11a 100644
> --- a/fs/xfs/scrub/refcount.c
> +++ b/fs/xfs/scrub/refcount.c
> @@ -341,7 +341,6 @@ xchk_refcountbt_rec(
>  	xfs_extlen_t		len;
>  	xfs_nlink_t		refcount;
>  	bool			has_cowflag;
> -	int			error = 0;
>  
>  	bno = be32_to_cpu(rec->refc.rc_startblock);
>  	len = be32_to_cpu(rec->refc.rc_blockcount);
> @@ -366,7 +365,7 @@ xchk_refcountbt_rec(
>  
>  	xchk_refcountbt_xref(bs->sc, bno, len, refcount);
>  
> -	return error;
> +	return 0;
>  }
>  
>  /* Make sure we have as many refc blocks as the rmap says. */
> -- 
> 2.7.4
>
diff mbox series

Patch

diff --git a/fs/xfs/scrub/refcount.c b/fs/xfs/scrub/refcount.c
index 93b3793b..0cab11a 100644
--- a/fs/xfs/scrub/refcount.c
+++ b/fs/xfs/scrub/refcount.c
@@ -341,7 +341,6 @@  xchk_refcountbt_rec(
 	xfs_extlen_t		len;
 	xfs_nlink_t		refcount;
 	bool			has_cowflag;
-	int			error = 0;
 
 	bno = be32_to_cpu(rec->refc.rc_startblock);
 	len = be32_to_cpu(rec->refc.rc_blockcount);
@@ -366,7 +365,7 @@  xchk_refcountbt_rec(
 
 	xchk_refcountbt_xref(bs->sc, bno, len, refcount);
 
-	return error;
+	return 0;
 }
 
 /* Make sure we have as many refc blocks as the rmap says. */