diff mbox series

[2/4] debian: turn debhelper compat level up to 11

Message ID 157784177377.1372453.1008055450028015778.stgit@magnolia (mailing list archive)
State Deferred, archived
Headers show
Series xfsprogs: packaging cleanups | expand

Commit Message

Darrick J. Wong Jan. 1, 2020, 1:22 a.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

Upgrade to debhelper level 11 to take advantage of dh_installsystemd,
which greatly simplifies the installation and activation of the scrub
systemd services.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 debian/compat |    2 +-
 debian/rules  |    1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

Comments

Christoph Hellwig Jan. 7, 2020, 2:21 p.m. UTC | #1 
On Tue, Dec 31, 2019 at 05:22:53PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> Upgrade to debhelper level 11 to take advantage of dh_installsystemd,
> which greatly simplifies the installation and activation of the scrub
> systemd services.

The subject and description seem upside down.  You want to use
dh_installsystemd, and to do so you'll have to bump the level..
Darrick J. Wong Jan. 7, 2020, 6:51 p.m. UTC | #2 
On Tue, Jan 07, 2020 at 06:21:23AM -0800, Christoph Hellwig wrote:
> On Tue, Dec 31, 2019 at 05:22:53PM -0800, Darrick J. Wong wrote:
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> > 
> > Upgrade to debhelper level 11 to take advantage of dh_installsystemd,
> > which greatly simplifies the installation and activation of the scrub
> > systemd services.
> 
> The subject and description seem upside down.  You want to use
> dh_installsystemd, and to do so you'll have to bump the level..

Heh, ok.

"debian: install scrub services with dh_installsystemd

"Use dh_installsystemd to handle the installation and activation of the
scrub systemd services.  This requires bumping the compat version to
11."

(Admittedly the subject was a riff on the old 'turn it up to 11' joke)

Related question: Are Debian oldoldstable and Ubuntu 16.04LTS old enough
to drop the "debian: permit compat level 9 dh builds" patch?  On systems
with software that old the kernel isn't going to support scrub, and who's
going to build xfsprogs 5.xx for those old systems?

--D
Christoph Hellwig Jan. 8, 2020, 8:58 a.m. UTC | #3 
On Tue, Jan 07, 2020 at 10:51:51AM -0800, Darrick J. Wong wrote:
> Related question: Are Debian oldoldstable and Ubuntu 16.04LTS old enough
> to drop the "debian: permit compat level 9 dh builds" patch?  On systems
> with software that old the kernel isn't going to support scrub, and who's
> going to build xfsprogs 5.xx for those old systems?

This sounds old enough to not bother.  And if someone screams loud
enough we could still add it back.
diff mbox series

Patch

diff --git a/debian/compat b/debian/compat
index ec635144..b4de3947 100644
--- a/debian/compat
+++ b/debian/compat
@@ -1 +1 @@ 
-9
+11
diff --git a/debian/rules b/debian/rules
index e8509fb3..a79db896 100755
--- a/debian/rules
+++ b/debian/rules
@@ -93,6 +93,7 @@  binary-arch: checkroot built
 	dh_compress
 	dh_fixperms
 	dh_makeshlibs
+	dh_installsystemd -p xfsprogs --no-enable --no-start --no-restart-after-upgrade --no-stop-on-upgrade
 	dh_installdeb
 	dh_shlibdeps
 	dh_gencontrol