| Message ID | 159716414414.2135493.1784583001962165153.stgit@magnolia (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xfsprogs: various small enhancements | expand |
On 8/11/20 9:42 AM, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > process_inode uses a local convenience variable to abstract the > differences between the ondisk nlink fields in a v1 inode and a v2 > inode. Use this variable for checking and reporting errors. Ah, otherwise we risk looking at the V2 field for a V1 inode, right? Reviewed-by: Eric Sandeen <sandeen@redhat.com> > Fixes: 6526f30e4801 ("xfs_db: stop misusing an onstack inode") > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > --- > db/check.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/db/check.c b/db/check.c > index c2233a0d1ba7..ef0e82d4efa1 100644 > --- a/db/check.c > +++ b/db/check.c > @@ -2797,10 +2797,10 @@ process_inode( > be64_to_cpu(dip->di_nblocks), ino); > error++; > } > - if (dip->di_nlink != 0) { > + if (nlink != 0) { > if (v) > dbprintf(_("bad nlink %d for free inode %lld\n"), > - be32_to_cpu(dip->di_nlink), ino); > + nlink, ino); > error++; > } > if (dip->di_mode != 0) { >
diff --git a/db/check.c b/db/check.c index c2233a0d1ba7..ef0e82d4efa1 100644 --- a/db/check.c +++ b/db/check.c @@ -2797,10 +2797,10 @@ process_inode( be64_to_cpu(dip->di_nblocks), ino); error++; } - if (dip->di_nlink != 0) { + if (nlink != 0) { if (v) dbprintf(_("bad nlink %d for free inode %lld\n"), - be32_to_cpu(dip->di_nlink), ino); + nlink, ino); error++; } if (dip->di_mode != 0) {