| Message ID | 159950110270.567664.7772913999736955021.stgit@magnolia (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfsprogs: various fixes for 5.9 | expand |
On Mon, Sep 07, 2020 at 10:51:42AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > If the external log device is too small to satisfy minimum requirements, > mkfs will complain about "external log device 512 too small...". That > doesn't make any sense, so add a few missing words to clarify what we're > talking about: > > "external log device size 512 blocks too small..." Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
On 9/7/20 10:51 AM, Darrick J. Wong wrote: > From: Darrick J. Wong <darrick.wong@oracle.com> > > If the external log device is too small to satisfy minimum requirements, > mkfs will complain about "external log device 512 too small...". That > doesn't make any sense, so add a few missing words to clarify what we're > talking about: > > "external log device size 512 blocks too small..." > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> Looks ok Reviewed-by: Allison Collins <allison.henderson@oracle.com> > --- > mkfs/xfs_mkfs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c > index a687f385a9c1..39fad9576088 100644 > --- a/mkfs/xfs_mkfs.c > +++ b/mkfs/xfs_mkfs.c > @@ -3095,7 +3095,7 @@ calculate_log_size( > if (!cfg->loginternal) { > if (min_logblocks > cfg->logblocks) { > fprintf(stderr, > -_("external log device %lld too small, must be at least %lld blocks\n"), > +_("external log device size %lld blocks too small, must be at least %lld blocks\n"), > (long long)cfg->logblocks, > (long long)min_logblocks); > usage(); >
diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index a687f385a9c1..39fad9576088 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -3095,7 +3095,7 @@ calculate_log_size( if (!cfg->loginternal) { if (min_logblocks > cfg->logblocks) { fprintf(stderr, -_("external log device %lld too small, must be at least %lld blocks\n"), +_("external log device size %lld blocks too small, must be at least %lld blocks\n"), (long long)cfg->logblocks, (long long)min_logblocks); usage();