diff mbox series

[01/24] xfs/331: don't run this test if fallocate isn't supported

Message ID 160013418077.2923511.4423324916550074038.stgit@magnolia (mailing list archive)
State Accepted, archived
Headers show
Series fstests: tons of random fixes | expand

Commit Message

Darrick J. Wong Sept. 15, 2020, 1:43 a.m. UTC 
From: Darrick J. Wong <darrick.wong@oracle.com>

This test requires fallocate, so make sure that actually works before
running it.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/331 |    1 +
 1 file changed, 1 insertion(+)

Comments

Christoph Hellwig Sept. 17, 2020, 7:50 a.m. UTC | #1 
On Mon, Sep 14, 2020 at 06:43:00PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> This test requires fallocate, so make sure that actually works before
> running it.
> 
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>

Looks good,

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/xfs/331 b/tests/xfs/331
index b26ea155..501dd1f8 100755
--- a/tests/xfs/331
+++ b/tests/xfs/331
@@ -32,6 +32,7 @@  _supported_fs xfs
 _require_scratch
 _require_xfs_scratch_rmapbt
 _require_scratch_reflink
+_require_xfs_io_command "falloc"
 _require_test_program "punch-alternating"
 
 rm -f "$seqres.full"