| Message ID | 1603169666-16106-1-git-send-email-kaixuxia@tencent.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfs: remove the unused XFS_B_FSB_OFFSET macro | expand |
On Tue, Oct 20, 2020 at 12:54:26PM +0800, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia <kaixuxia@tencent.com> > > There are no callers of the XFS_B_FSB_OFFSET macro, so remove it. > > Signed-off-by: Kaixu Xia <kaixuxia@tencent.com> > --- > fs/xfs/libxfs/xfs_format.h | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h > index dd764da08f6f..40b6fa3b4e01 100644 > --- a/fs/xfs/libxfs/xfs_format.h > +++ b/fs/xfs/libxfs/xfs_format.h > @@ -625,7 +625,6 @@ xfs_is_quota_inode(struct xfs_sb *sbp, xfs_ino_t ino) > #define XFS_B_TO_FSB(mp,b) \ > ((((uint64_t)(b)) + (mp)->m_blockmask) >> (mp)->m_sb.sb_blocklog) > #define XFS_B_TO_FSBT(mp,b) (((uint64_t)(b)) >> (mp)->m_sb.sb_blocklog) > -#define XFS_B_FSB_OFFSET(mp,b) ((b) & (mp)->m_blockmask) Looks fine. Reviewed-by: Dave Chinner <dchinner@redhat.com>
On Tue, Oct 20, 2020 at 12:54:26PM +0800, xiakaixu1987@gmail.com wrote: > From: Kaixu Xia <kaixuxia@tencent.com> > > There are no callers of the XFS_B_FSB_OFFSET macro, so remove it. No callers in xfsprogs either. Looks good: Reviewed-by: Christoph Hellwig <hch@lst.de>
On 2020/10/28 2:47, Christoph Hellwig wrote: > On Tue, Oct 20, 2020 at 12:54:26PM +0800, xiakaixu1987@gmail.com wrote: >> From: Kaixu Xia <kaixuxia@tencent.com> >> >> There are no callers of the XFS_B_FSB_OFFSET macro, so remove it. > > No callers in xfsprogs either. > > Looks good: > > Reviewed-by: Christoph Hellwig <hch@lst.de> Hi Darrick, There are some patches that have been reviewed but not been merged into xfs for-next branch, I will reply to them. Sorry for the noise:) Thanks, Kaixu >
On Thu, Nov 12, 2020 at 10:44:25AM +0800, kaixuxia wrote: > > > On 2020/10/28 2:47, Christoph Hellwig wrote: > > On Tue, Oct 20, 2020 at 12:54:26PM +0800, xiakaixu1987@gmail.com wrote: > >> From: Kaixu Xia <kaixuxia@tencent.com> > >> > >> There are no callers of the XFS_B_FSB_OFFSET macro, so remove it. > > > > No callers in xfsprogs either. > > > > Looks good: > > > > Reviewed-by: Christoph Hellwig <hch@lst.de> > > Hi Darrick, > > There are some patches that have been reviewed but not been merged > into xfs for-next branch, I will reply to them. > Sorry for the noise:) Yes. AFAICT none of them are critical 5.10 bugfixes so they're all waiting for 5.11. --D > Thanks, > Kaixu > > > > -- > kaixuxia
diff --git a/fs/xfs/libxfs/xfs_format.h b/fs/xfs/libxfs/xfs_format.h index dd764da08f6f..40b6fa3b4e01 100644 --- a/fs/xfs/libxfs/xfs_format.h +++ b/fs/xfs/libxfs/xfs_format.h @@ -625,7 +625,6 @@ xfs_is_quota_inode(struct xfs_sb *sbp, xfs_ino_t ino) #define XFS_B_TO_FSB(mp,b) \ ((((uint64_t)(b)) + (mp)->m_blockmask) >> (mp)->m_sb.sb_blocklog) #define XFS_B_TO_FSBT(mp,b) (((uint64_t)(b)) >> (mp)->m_sb.sb_blocklog) -#define XFS_B_FSB_OFFSET(mp,b) ((b) & (mp)->m_blockmask) /* * Allocation group header