diff mbox series

[7/7] xfs/122: fix test for xfs_attr_shortform_t conversion

Message ID 160382539620.1203387.14717204905418805283.stgit@magnolia
State Superseded
Headers show
Series various: test xfs things fixed in 5.10 | expand

Commit Message

Darrick J. Wong Oct. 27, 2020, 7:03 p.m. UTC
From: Darrick J. Wong <darrick.wong@oracle.com>

The typedef xfs_attr_shortform_t was converted to a struct in 5.10.
Update this test to pass.

Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
---
 tests/xfs/122.out |    1 +
 1 file changed, 1 insertion(+)

Comments

Chandan Babu R Oct. 29, 2020, 10:12 a.m. UTC | #1
On Wednesday 28 October 2020 12:33:16 AM IST Darrick J. Wong wrote:
> From: Darrick J. Wong <darrick.wong@oracle.com>
> 
> The typedef xfs_attr_shortform_t was converted to a struct in 5.10.
> Update this test to pass.
>

Looks good to me.

Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>

> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  tests/xfs/122.out |    1 +
>  1 file changed, 1 insertion(+)
> 
> 
> diff --git a/tests/xfs/122.out b/tests/xfs/122.out
> index 45c42e59..cfe09c6d 100644
> --- a/tests/xfs/122.out
> +++ b/tests/xfs/122.out
> @@ -62,6 +62,7 @@ sizeof(struct xfs_agfl) = 36
>  sizeof(struct xfs_attr3_leaf_hdr) = 80
>  sizeof(struct xfs_attr3_leafblock) = 88
>  sizeof(struct xfs_attr3_rmt_hdr) = 56
> +sizeof(struct xfs_attr_shortform) = 8
>  sizeof(struct xfs_btree_block) = 72
>  sizeof(struct xfs_btree_block_lhdr) = 64
>  sizeof(struct xfs_btree_block_shdr) = 48
> 
>
Amir Goldstein Oct. 29, 2020, 11:17 a.m. UTC | #2
On Wed, Oct 28, 2020 at 10:24 PM Darrick J. Wong
<darrick.wong@oracle.com> wrote:
>
> From: Darrick J. Wong <darrick.wong@oracle.com>
>
> The typedef xfs_attr_shortform_t was converted to a struct in 5.10.
> Update this test to pass.
>
> Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> ---
>  tests/xfs/122.out |    1 +
>  1 file changed, 1 insertion(+)
>
>
> diff --git a/tests/xfs/122.out b/tests/xfs/122.out
> index 45c42e59..cfe09c6d 100644
> --- a/tests/xfs/122.out
> +++ b/tests/xfs/122.out
> @@ -62,6 +62,7 @@ sizeof(struct xfs_agfl) = 36
>  sizeof(struct xfs_attr3_leaf_hdr) = 80
>  sizeof(struct xfs_attr3_leafblock) = 88
>  sizeof(struct xfs_attr3_rmt_hdr) = 56
> +sizeof(struct xfs_attr_shortform) = 8
>  sizeof(struct xfs_btree_block) = 72
>  sizeof(struct xfs_btree_block_lhdr) = 64
>  sizeof(struct xfs_btree_block_shdr) = 48
>

Maybe remove comment

# missing:
# xfs_attr_shortform_t

While at it.

Thanks,
Amir.
Darrick J. Wong Oct. 29, 2020, 6:17 p.m. UTC | #3
On Thu, Oct 29, 2020 at 01:17:40PM +0200, Amir Goldstein wrote:
> On Wed, Oct 28, 2020 at 10:24 PM Darrick J. Wong
> <darrick.wong@oracle.com> wrote:
> >
> > From: Darrick J. Wong <darrick.wong@oracle.com>
> >
> > The typedef xfs_attr_shortform_t was converted to a struct in 5.10.
> > Update this test to pass.
> >
> > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com>
> > ---
> >  tests/xfs/122.out |    1 +
> >  1 file changed, 1 insertion(+)
> >
> >
> > diff --git a/tests/xfs/122.out b/tests/xfs/122.out
> > index 45c42e59..cfe09c6d 100644
> > --- a/tests/xfs/122.out
> > +++ b/tests/xfs/122.out
> > @@ -62,6 +62,7 @@ sizeof(struct xfs_agfl) = 36
> >  sizeof(struct xfs_attr3_leaf_hdr) = 80
> >  sizeof(struct xfs_attr3_leafblock) = 88
> >  sizeof(struct xfs_attr3_rmt_hdr) = 56
> > +sizeof(struct xfs_attr_shortform) = 8
> >  sizeof(struct xfs_btree_block) = 72
> >  sizeof(struct xfs_btree_block_lhdr) = 64
> >  sizeof(struct xfs_btree_block_shdr) = 48
> >
> 
> Maybe remove comment
> 
> # missing:
> # xfs_attr_shortform_t
> 
> While at it.

I'll do that, thanks!

--D

> Thanks,
> Amir.
diff mbox series

Patch

diff --git a/tests/xfs/122.out b/tests/xfs/122.out
index 45c42e59..cfe09c6d 100644
--- a/tests/xfs/122.out
+++ b/tests/xfs/122.out
@@ -62,6 +62,7 @@  sizeof(struct xfs_agfl) = 36
 sizeof(struct xfs_attr3_leaf_hdr) = 80
 sizeof(struct xfs_attr3_leafblock) = 88
 sizeof(struct xfs_attr3_rmt_hdr) = 56
+sizeof(struct xfs_attr_shortform) = 8
 sizeof(struct xfs_btree_block) = 72
 sizeof(struct xfs_btree_block_lhdr) = 64
 sizeof(struct xfs_btree_block_shdr) = 48