| Message ID | 160382544101.1203848.15837078115947156573.stgit@magnolia (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xfstests: widen timestamps to deal with y2038+ | expand |
On Wed, Oct 28, 2020 at 10:25 PM Darrick J. Wong <darrick.wong@oracle.com> wrote: > > From: Darrick J. Wong <darrick.wong@oracle.com> > > These two tests ensure we can store and retrieve timestamps on the > extremes of the date ranges supported by userspace, and the common > places where overflows can happen. > > They differ from generic/402 in that they don't constrain the dates > tested to the range that the filesystem claims to support; we attempt > various things that /userspace/ can parse, and then check that the vfs > clamps and persists the values correctly. So this test will fail when run on stable kernels before the vfs clamping changes and there is no require_* to mitigate that failure. At the time, I discussed this with Deepa and the result was the _check_dmesg_for part of _require_timestamp_range, which is incomplete. The complete check for kernel clamping support would be to run _require_timestamp_range (on the second half thereof) on a loop mounted ext2, so we know for sure that the kernel is going to emit the y2038 warning. I am going to leave it to you and the maintainer the decide how critical that is, but I would suggest to at least factor out _require_timestamp_limits() which is true if either the filesystem timestamp range is known or the kernel emits y2038 warning. > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > --- > tests/generic/721 | 117 ++++++++++++++++++++++++++++++++++++++++++++++++ > tests/generic/721.out | 1 > tests/generic/722 | 120 +++++++++++++++++++++++++++++++++++++++++++++++++ > tests/generic/722.out | 1 > tests/generic/group | 2 + > 5 files changed, 241 insertions(+) > create mode 100755 tests/generic/721 > create mode 100644 tests/generic/721.out > create mode 100755 tests/generic/722 > create mode 100644 tests/generic/722.out > > > diff --git a/tests/generic/721 b/tests/generic/721 > new file mode 100755 > index 00000000..9638fbfc > --- /dev/null > +++ b/tests/generic/721 > @@ -0,0 +1,117 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0-or-later > +# Copyright (c) 2020, Oracle and/or its affiliates. All Rights Reserved. > +# > +# FS QA Test No. 721 > +# > +# Make sure we can store and retrieve timestamps on the extremes of the > +# date ranges supported by userspace, and the common places where overflows > +# can happen. > +# > +# This differs from generic/402 in that we don't constrain ourselves to the > +# range that the filesystem claims to support; we attempt various things that > +# /userspace/ can parse, and then check that the vfs clamps and persists the > +# values correctly. > + > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + cd / > + rm -f $tmp.* > +} > + > +# get standard environment, filters and checks > +. ./common/rc > + > +# real QA test starts here > +_supported_fs generic > +_require_scratch > + > +rm -f $seqres.full > + > +_scratch_mkfs > $seqres.full > +_scratch_mount > + > +# Does our userspace even support large dates? > +test_bigdates=1 > +touch -d 'May 30 01:53:03 UTC 2514' $SCRATCH_MNT 2>/dev/null || test_bigdates=0 > + > +# And can we do statx? > +test_statx=1 > +($XFS_IO_PROG -c 'help statx' | grep -q 'Print raw statx' && \ > + $XFS_IO_PROG -c 'statx -r' $SCRATCH_MNT 2>/dev/null | grep -q 'stat.mtime') || \ > + test_statx=0 > + > +echo "Userspace support of large timestamps: $test_bigdates" >> $seqres.full > +echo "xfs_io support of statx: $test_statx" >> $seqres.full > + > +touchme() { > + local arg="$1" > + local name="$2" > + > + echo "$arg" > $SCRATCH_MNT/t_$name > + touch -d "$arg" $SCRATCH_MNT/t_$name > +} > + > +report() { > + local files=($SCRATCH_MNT/t_*) > + for file in "${files[@]}"; do > + echo "${file}: $(cat "${file}")" > + TZ=UTC stat -c '%y %Y %n' "${file}" > + test $test_statx -gt 0 && \ > + $XFS_IO_PROG -c 'statx -r' "${file}" | grep 'stat.mtime' > + done > +} > + > +# -2147483648 (S32_MIN, or classic unix min) > +touchme 'Dec 13 20:45:52 UTC 1901' s32_min > + > +# 2147483647 (S32_MAX, or classic unix max) > +touchme 'Jan 19 03:14:07 UTC 2038' s32_max > + > +# 7956915742, all twos > +touchme 'Feb 22 22:22:22 UTC 2222' all_twos > + > +if [ $test_bigdates -gt 0 ]; then > + # 16299260424 (u64 nsec counter from s32_min, like xfs does) > + touchme 'Tue Jul 2 20:20:24 UTC 2486' u64ns_from_s32_min > + > + # 15032385535 (u34 time if you start from s32_min, like ext4 does) > + touchme 'May 10 22:38:55 UTC 2446' u34_from_s32_min > + > + # 17179869183 (u34 time if you start from the unix epoch) > + touchme 'May 30 01:53:03 UTC 2514' u34_max > + > + # Latest date we can synthesize(?) > + touchme 'Dec 31 23:59:59 UTC 2147483647' abs_max_time > + > + # Earliest date we can synthesize(?) > + touchme 'Jan 1 00:00:00 UTC 0' abs_min_time > +fi > + > +# Query timestamps from incore > +echo before >> $seqres.full > +report > $tmp.times0 > +cat $tmp.times0 >> $seqres.full > + > +_scratch_cycle_mount > + > +# Query timestamps from disk > +echo after >> $seqres.full > +report > $tmp.times1 > +cat $tmp.times1 >> $seqres.full > + > +# Did they match? > +cmp -s $tmp.times0 $tmp.times1 > + Please use suffix $tmp.{before,after}_cycle_mount It makes the meaning of the diff in the test failure much clearer to a bystander. > +# success, all done > +status=0 > +exit > diff --git a/tests/generic/721.out b/tests/generic/721.out > new file mode 100644 > index 00000000..087decb5 > --- /dev/null > +++ b/tests/generic/721.out > @@ -0,0 +1 @@ > +QA output created by 721 What? no "Silence is golden"? :-D > diff --git a/tests/generic/722 b/tests/generic/722 > new file mode 100755 > index 00000000..3e8c553b > --- /dev/null > +++ b/tests/generic/722 > @@ -0,0 +1,120 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0-or-later > +# Copyright (c) 2020, Oracle and/or its affiliates. All Rights Reserved. > +# > +# FS QA Test No. 722 > +# > +# Make sure we can store and retrieve timestamps on the extremes of the > +# date ranges supported by userspace, and the common places where overflows > +# can happen. This test also ensures that the timestamps are persisted > +# correctly after a shutdown. > +# > +# This differs from generic/402 in that we don't constrain ourselves to the > +# range that the filesystem claims to support; we attempt various things that > +# /userspace/ can parse, and then check that the vfs clamps and persists the > +# values correctly. > + > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + cd / > + rm -f $tmp.* > +} > + > +# get standard environment, filters and checks > +. ./common/rc > + > +# real QA test starts here > +_supported_fs generic > +_require_scratch > +_require_scratch_shutdown > + > +rm -f $seqres.full > + > +_scratch_mkfs > $seqres.full > +_scratch_mount > + > +# Does our userspace even support large dates? > +test_bigdates=1 > +touch -d 'May 30 01:53:03 UTC 2514' $SCRATCH_MNT 2>/dev/null || test_bigdates=0 > + > +# And can we do statx? > +test_statx=1 > +($XFS_IO_PROG -c 'help statx' | grep -q 'Print raw statx' && \ > + $XFS_IO_PROG -c 'statx -r' $SCRATCH_MNT 2>/dev/null | grep -q 'stat.mtime') || \ > + test_statx=0 > + > +echo "Userspace support of large timestamps: $test_bigdates" >> $seqres.full > +echo "xfs_io support of statx: $test_statx" >> $seqres.full > + > +touchme() { > + local arg="$1" > + local name="$2" > + > + echo "$arg" > $SCRATCH_MNT/t_$name > + touch -d "$arg" $SCRATCH_MNT/t_$name > +} > + > +report() { > + local files=($SCRATCH_MNT/t_*) > + for file in "${files[@]}"; do > + echo "${file}: $(cat "${file}")" > + TZ=UTC stat -c '%y %Y %n' "${file}" > + test $test_statx -gt 0 && \ > + $XFS_IO_PROG -c 'statx -r' "${file}" | grep 'stat.mtime' > + done > +} > + > +# -2147483648 (S32_MIN, or classic unix min) > +touchme 'Dec 13 20:45:52 UTC 1901' s32_min > + > +# 2147483647 (S32_MAX, or classic unix max) > +touchme 'Jan 19 03:14:07 UTC 2038' s32_max > + > +# 7956915742, all twos > +touchme 'Feb 22 22:22:22 UTC 2222' all_twos > + > +if [ $test_bigdates -gt 0 ]; then > + # 16299260424 (u64 nsec counter from s32_min, like xfs does) > + touchme 'Tue Jul 2 20:20:24 UTC 2486' u64ns_from_s32_min > + > + # 15032385535 (u34 time if you start from s32_min, like ext4 does) > + touchme 'May 10 22:38:55 UTC 2446' u34_from_s32_min > + > + # 17179869183 (u34 time if you start from the unix epoch) > + touchme 'May 30 01:53:03 UTC 2514' u34_max > + > + # Latest date we can synthesize(?) > + touchme 'Dec 31 23:59:59 UTC 2147483647' abs_max_time > + > + # Earliest date we can synthesize(?) > + touchme 'Jan 1 00:00:00 UTC 0' abs_min_time > +fi > + > +# Query timestamps from incore > +echo before >> $seqres.full > +report > $tmp.times0 > +cat $tmp.times0 >> $seqres.full > + > +_scratch_shutdown -f > +_scratch_cycle_mount > + > +# Query timestamps from disk > +echo after >> $seqres.full > +report > $tmp.times1 > +cat $tmp.times1 >> $seqres.full > + > +# Did they match? > +cmp -s $tmp.times0 $tmp.times1 > + > +# success, all done > +status=0 > +exit > diff --git a/tests/generic/722.out b/tests/generic/722.out > new file mode 100644 > index 00000000..83acd5cf > --- /dev/null > +++ b/tests/generic/722.out > @@ -0,0 +1 @@ > +QA output created by 722 > diff --git a/tests/generic/group b/tests/generic/group > index cf4fdc23..b533d6b2 100644 > --- a/tests/generic/group > +++ b/tests/generic/group > @@ -615,5 +615,7 @@ > 610 auto quick prealloc zero > 611 auto quick attr > 612 auto quick clone > +721 auto quick atime bigtime > +722 auto quick atime bigtime shutdown group please. If we are going to use "bigtime" for generic tests to describe y2038 tests, perhaps add it to 258 and 402 as well? Thanks, Amir.
On Thu, Oct 29, 2020 at 12:34:57PM +0200, Amir Goldstein wrote: > On Wed, Oct 28, 2020 at 10:25 PM Darrick J. Wong > <darrick.wong@oracle.com> wrote: > > > > From: Darrick J. Wong <darrick.wong@oracle.com> > > > > These two tests ensure we can store and retrieve timestamps on the > > extremes of the date ranges supported by userspace, and the common > > places where overflows can happen. > > > > They differ from generic/402 in that they don't constrain the dates > > tested to the range that the filesystem claims to support; we attempt > > various things that /userspace/ can parse, and then check that the vfs > > clamps and persists the values correctly. > > So this test will fail when run on stable kernels before the vfs > clamping changes > and there is no require_* to mitigate that failure. Yes, that is the intended outcome. Those old kernels silently truncate the high bits from those timestamps when inodes are flushed to disk, and the only user-visible evidence of this comes much later when the system reboots and suddenly the timestamps are wrong. Clamping also seems a little strange, but at least it's immediately obvious. It is very surprising that you could set a timestamp of 2 Apr 2500 on ext2, ls your shiny futuristic timestamp, reboot, and have it become 5 Nov 1955. Only Marty McFly would be amused. > At the time, I discussed this with Deepa and the result was the > _check_dmesg_for part of _require_timestamp_range, which is incomplete. > The complete check for kernel clamping support would be to run > _require_timestamp_range (on the second half thereof) on a loop mounted > ext2, so we know for sure that the kernel is going to emit the y2038 warning. Uh... I don't think it's a sensible to require ext2 to test a different filesystem. > I am going to leave it to you and the maintainer the decide how > critical that is, > but I would suggest to at least factor out _require_timestamp_limits() > which is true if either the filesystem timestamp range is known or the kernel > emits y2038 warning. TBH I had rather hoped that the VFS woulud have a way to export the supported timestamp range by now, but that probably failed when dhowells' big complicated fsinfo series died. --D > > > > Signed-off-by: Darrick J. Wong <darrick.wong@oracle.com> > > --- > > tests/generic/721 | 117 ++++++++++++++++++++++++++++++++++++++++++++++++ > > tests/generic/721.out | 1 > > tests/generic/722 | 120 +++++++++++++++++++++++++++++++++++++++++++++++++ > > tests/generic/722.out | 1 > > tests/generic/group | 2 + > > 5 files changed, 241 insertions(+) > > create mode 100755 tests/generic/721 > > create mode 100644 tests/generic/721.out > > create mode 100755 tests/generic/722 > > create mode 100644 tests/generic/722.out > > > > > > diff --git a/tests/generic/721 b/tests/generic/721 > > new file mode 100755 > > index 00000000..9638fbfc > > --- /dev/null > > +++ b/tests/generic/721 > > @@ -0,0 +1,117 @@ > > +#! /bin/bash > > +# SPDX-License-Identifier: GPL-2.0-or-later > > +# Copyright (c) 2020, Oracle and/or its affiliates. All Rights Reserved. > > +# > > +# FS QA Test No. 721 > > +# > > +# Make sure we can store and retrieve timestamps on the extremes of the > > +# date ranges supported by userspace, and the common places where overflows > > +# can happen. > > +# > > +# This differs from generic/402 in that we don't constrain ourselves to the > > +# range that the filesystem claims to support; we attempt various things that > > +# /userspace/ can parse, and then check that the vfs clamps and persists the > > +# values correctly. > > + > > +seq=`basename $0` > > +seqres=$RESULT_DIR/$seq > > +echo "QA output created by $seq" > > + > > +here=`pwd` > > +tmp=/tmp/$$ > > +status=1 # failure is the default! > > +trap "_cleanup; exit \$status" 0 1 2 3 15 > > + > > +_cleanup() > > +{ > > + cd / > > + rm -f $tmp.* > > +} > > + > > +# get standard environment, filters and checks > > +. ./common/rc > > + > > +# real QA test starts here > > +_supported_fs generic > > +_require_scratch > > + > > +rm -f $seqres.full > > + > > +_scratch_mkfs > $seqres.full > > +_scratch_mount > > + > > +# Does our userspace even support large dates? > > +test_bigdates=1 > > +touch -d 'May 30 01:53:03 UTC 2514' $SCRATCH_MNT 2>/dev/null || test_bigdates=0 > > + > > +# And can we do statx? > > +test_statx=1 > > +($XFS_IO_PROG -c 'help statx' | grep -q 'Print raw statx' && \ > > + $XFS_IO_PROG -c 'statx -r' $SCRATCH_MNT 2>/dev/null | grep -q 'stat.mtime') || \ > > + test_statx=0 > > + > > +echo "Userspace support of large timestamps: $test_bigdates" >> $seqres.full > > +echo "xfs_io support of statx: $test_statx" >> $seqres.full > > + > > +touchme() { > > + local arg="$1" > > + local name="$2" > > + > > + echo "$arg" > $SCRATCH_MNT/t_$name > > + touch -d "$arg" $SCRATCH_MNT/t_$name > > +} > > + > > +report() { > > + local files=($SCRATCH_MNT/t_*) > > + for file in "${files[@]}"; do > > + echo "${file}: $(cat "${file}")" > > + TZ=UTC stat -c '%y %Y %n' "${file}" > > + test $test_statx -gt 0 && \ > > + $XFS_IO_PROG -c 'statx -r' "${file}" | grep 'stat.mtime' > > + done > > +} > > + > > +# -2147483648 (S32_MIN, or classic unix min) > > +touchme 'Dec 13 20:45:52 UTC 1901' s32_min > > + > > +# 2147483647 (S32_MAX, or classic unix max) > > +touchme 'Jan 19 03:14:07 UTC 2038' s32_max > > + > > +# 7956915742, all twos > > +touchme 'Feb 22 22:22:22 UTC 2222' all_twos > > + > > +if [ $test_bigdates -gt 0 ]; then > > + # 16299260424 (u64 nsec counter from s32_min, like xfs does) > > + touchme 'Tue Jul 2 20:20:24 UTC 2486' u64ns_from_s32_min > > + > > + # 15032385535 (u34 time if you start from s32_min, like ext4 does) > > + touchme 'May 10 22:38:55 UTC 2446' u34_from_s32_min > > + > > + # 17179869183 (u34 time if you start from the unix epoch) > > + touchme 'May 30 01:53:03 UTC 2514' u34_max > > + > > + # Latest date we can synthesize(?) > > + touchme 'Dec 31 23:59:59 UTC 2147483647' abs_max_time > > + > > + # Earliest date we can synthesize(?) > > + touchme 'Jan 1 00:00:00 UTC 0' abs_min_time > > +fi > > + > > +# Query timestamps from incore > > +echo before >> $seqres.full > > +report > $tmp.times0 > > +cat $tmp.times0 >> $seqres.full > > + > > +_scratch_cycle_mount > > + > > +# Query timestamps from disk > > +echo after >> $seqres.full > > +report > $tmp.times1 > > +cat $tmp.times1 >> $seqres.full > > + > > +# Did they match? > > +cmp -s $tmp.times0 $tmp.times1 > > + > > Please use suffix $tmp.{before,after}_cycle_mount > It makes the meaning of the diff in the test failure much clearer > to a bystander. > > > +# success, all done > > +status=0 > > +exit > > diff --git a/tests/generic/721.out b/tests/generic/721.out > > new file mode 100644 > > index 00000000..087decb5 > > --- /dev/null > > +++ b/tests/generic/721.out > > @@ -0,0 +1 @@ > > +QA output created by 721 > > What? no "Silence is golden"? :-D > > > diff --git a/tests/generic/722 b/tests/generic/722 > > new file mode 100755 > > index 00000000..3e8c553b > > --- /dev/null > > +++ b/tests/generic/722 > > @@ -0,0 +1,120 @@ > > +#! /bin/bash > > +# SPDX-License-Identifier: GPL-2.0-or-later > > +# Copyright (c) 2020, Oracle and/or its affiliates. All Rights Reserved. > > +# > > +# FS QA Test No. 722 > > +# > > +# Make sure we can store and retrieve timestamps on the extremes of the > > +# date ranges supported by userspace, and the common places where overflows > > +# can happen. This test also ensures that the timestamps are persisted > > +# correctly after a shutdown. > > +# > > +# This differs from generic/402 in that we don't constrain ourselves to the > > +# range that the filesystem claims to support; we attempt various things that > > +# /userspace/ can parse, and then check that the vfs clamps and persists the > > +# values correctly. > > + > > +seq=`basename $0` > > +seqres=$RESULT_DIR/$seq > > +echo "QA output created by $seq" > > + > > +here=`pwd` > > +tmp=/tmp/$$ > > +status=1 # failure is the default! > > +trap "_cleanup; exit \$status" 0 1 2 3 15 > > + > > +_cleanup() > > +{ > > + cd / > > + rm -f $tmp.* > > +} > > + > > +# get standard environment, filters and checks > > +. ./common/rc > > + > > +# real QA test starts here > > +_supported_fs generic > > +_require_scratch > > +_require_scratch_shutdown > > + > > +rm -f $seqres.full > > + > > +_scratch_mkfs > $seqres.full > > +_scratch_mount > > + > > +# Does our userspace even support large dates? > > +test_bigdates=1 > > +touch -d 'May 30 01:53:03 UTC 2514' $SCRATCH_MNT 2>/dev/null || test_bigdates=0 > > + > > +# And can we do statx? > > +test_statx=1 > > +($XFS_IO_PROG -c 'help statx' | grep -q 'Print raw statx' && \ > > + $XFS_IO_PROG -c 'statx -r' $SCRATCH_MNT 2>/dev/null | grep -q 'stat.mtime') || \ > > + test_statx=0 > > + > > +echo "Userspace support of large timestamps: $test_bigdates" >> $seqres.full > > +echo "xfs_io support of statx: $test_statx" >> $seqres.full > > + > > +touchme() { > > + local arg="$1" > > + local name="$2" > > + > > + echo "$arg" > $SCRATCH_MNT/t_$name > > + touch -d "$arg" $SCRATCH_MNT/t_$name > > +} > > + > > +report() { > > + local files=($SCRATCH_MNT/t_*) > > + for file in "${files[@]}"; do > > + echo "${file}: $(cat "${file}")" > > + TZ=UTC stat -c '%y %Y %n' "${file}" > > + test $test_statx -gt 0 && \ > > + $XFS_IO_PROG -c 'statx -r' "${file}" | grep 'stat.mtime' > > + done > > +} > > + > > +# -2147483648 (S32_MIN, or classic unix min) > > +touchme 'Dec 13 20:45:52 UTC 1901' s32_min > > + > > +# 2147483647 (S32_MAX, or classic unix max) > > +touchme 'Jan 19 03:14:07 UTC 2038' s32_max > > + > > +# 7956915742, all twos > > +touchme 'Feb 22 22:22:22 UTC 2222' all_twos > > + > > +if [ $test_bigdates -gt 0 ]; then > > + # 16299260424 (u64 nsec counter from s32_min, like xfs does) > > + touchme 'Tue Jul 2 20:20:24 UTC 2486' u64ns_from_s32_min > > + > > + # 15032385535 (u34 time if you start from s32_min, like ext4 does) > > + touchme 'May 10 22:38:55 UTC 2446' u34_from_s32_min > > + > > + # 17179869183 (u34 time if you start from the unix epoch) > > + touchme 'May 30 01:53:03 UTC 2514' u34_max > > + > > + # Latest date we can synthesize(?) > > + touchme 'Dec 31 23:59:59 UTC 2147483647' abs_max_time > > + > > + # Earliest date we can synthesize(?) > > + touchme 'Jan 1 00:00:00 UTC 0' abs_min_time > > +fi > > + > > +# Query timestamps from incore > > +echo before >> $seqres.full > > +report > $tmp.times0 > > +cat $tmp.times0 >> $seqres.full > > + > > +_scratch_shutdown -f > > +_scratch_cycle_mount > > + > > +# Query timestamps from disk > > +echo after >> $seqres.full > > +report > $tmp.times1 > > +cat $tmp.times1 >> $seqres.full > > + > > +# Did they match? > > +cmp -s $tmp.times0 $tmp.times1 > > + > > +# success, all done > > +status=0 > > +exit > > diff --git a/tests/generic/722.out b/tests/generic/722.out > > new file mode 100644 > > index 00000000..83acd5cf > > --- /dev/null > > +++ b/tests/generic/722.out > > @@ -0,0 +1 @@ > > +QA output created by 722 > > diff --git a/tests/generic/group b/tests/generic/group > > index cf4fdc23..b533d6b2 100644 > > --- a/tests/generic/group > > +++ b/tests/generic/group > > @@ -615,5 +615,7 @@ > > 610 auto quick prealloc zero > > 611 auto quick attr > > 612 auto quick clone > > +721 auto quick atime bigtime > > +722 auto quick atime bigtime > > shutdown group please. > > If we are going to use "bigtime" for generic tests to describe y2038 tests, > perhaps add it to 258 and 402 as well? > > Thanks, > Amir.
On Thu, Oct 29, 2020 at 11:02 PM Darrick J. Wong <darrick.wong@oracle.com> wrote: > > On Thu, Oct 29, 2020 at 12:34:57PM +0200, Amir Goldstein wrote: > > On Wed, Oct 28, 2020 at 10:25 PM Darrick J. Wong > > <darrick.wong@oracle.com> wrote: > > > > > > From: Darrick J. Wong <darrick.wong@oracle.com> > > > > > > These two tests ensure we can store and retrieve timestamps on the > > > extremes of the date ranges supported by userspace, and the common > > > places where overflows can happen. > > > > > > They differ from generic/402 in that they don't constrain the dates > > > tested to the range that the filesystem claims to support; we attempt > > > various things that /userspace/ can parse, and then check that the vfs > > > clamps and persists the values correctly. > > > > So this test will fail when run on stable kernels before the vfs > > clamping changes > > and there is no require_* to mitigate that failure. > > Yes, that is the intended outcome. Those old kernels silently truncate > the high bits from those timestamps when inodes are flushed to disk, and > the only user-visible evidence of this comes much later when the system > reboots and suddenly the timestamps are wrong. Clamping also seems a > little strange, but at least it's immediately obvious. > > It is very surprising that you could set a timestamp of 2 Apr 2500 on > ext2, ls your shiny futuristic timestamp, reboot, and have it become > 5 Nov 1955. Only Marty McFly would be amused. > OK. So we can call it a bug in old kernels that is not going to be fixed in stable updates. The minimum we can do for stable kernel testers is provide a decent way to exclude the tests for clamping. I guess 'check -x bigtime' is decent enough. I might have named the group 'timelimit' but I can live with 'bigtime'. So with fix for the rest of my minor nits, you may add: Reviewed-by: Amir Goldstein <amir73il@gmail.com> Thanks, Amir.
On Thu, Oct 29, 2020 at 11:40:00PM +0200, Amir Goldstein wrote: > On Thu, Oct 29, 2020 at 11:02 PM Darrick J. Wong > <darrick.wong@oracle.com> wrote: > > > > On Thu, Oct 29, 2020 at 12:34:57PM +0200, Amir Goldstein wrote: > > > On Wed, Oct 28, 2020 at 10:25 PM Darrick J. Wong > > > <darrick.wong@oracle.com> wrote: > > > > > > > > From: Darrick J. Wong <darrick.wong@oracle.com> > > > > > > > > These two tests ensure we can store and retrieve timestamps on the > > > > extremes of the date ranges supported by userspace, and the common > > > > places where overflows can happen. > > > > > > > > They differ from generic/402 in that they don't constrain the dates > > > > tested to the range that the filesystem claims to support; we attempt > > > > various things that /userspace/ can parse, and then check that the vfs > > > > clamps and persists the values correctly. > > > > > > So this test will fail when run on stable kernels before the vfs > > > clamping changes > > > and there is no require_* to mitigate that failure. > > > > Yes, that is the intended outcome. Those old kernels silently truncate > > the high bits from those timestamps when inodes are flushed to disk, and > > the only user-visible evidence of this comes much later when the system > > reboots and suddenly the timestamps are wrong. Clamping also seems a > > little strange, but at least it's immediately obvious. > > > > It is very surprising that you could set a timestamp of 2 Apr 2500 on > > ext2, ls your shiny futuristic timestamp, reboot, and have it become > > 5 Nov 1955. Only Marty McFly would be amused. > > > > OK. So we can call it a bug in old kernels that is not going to be fixed > in stable updates. The minimum we can do for stable kernel testers is > provide a decent way to exclude the tests for clamping. > > I guess 'check -x bigtime' is decent enough. > I might have named the group 'timelimit' but I can live with 'bigtime'. > > So with fix for the rest of my minor nits, you may add: Ok, I've fixed them all. I also added warnings to 721 and 722 that the test is expected to fail on pre-5.4 kernels. Thanks for reviewing! --D > Reviewed-by: Amir Goldstein <amir73il@gmail.com> > > Thanks, > Amir.
diff --git a/tests/generic/721 b/tests/generic/721 new file mode 100755 index 00000000..9638fbfc --- /dev/null +++ b/tests/generic/721 @@ -0,0 +1,117 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2020, Oracle and/or its affiliates. All Rights Reserved. +# +# FS QA Test No. 721 +# +# Make sure we can store and retrieve timestamps on the extremes of the +# date ranges supported by userspace, and the common places where overflows +# can happen. +# +# This differs from generic/402 in that we don't constrain ourselves to the +# range that the filesystem claims to support; we attempt various things that +# /userspace/ can parse, and then check that the vfs clamps and persists the +# values correctly. + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc + +# real QA test starts here +_supported_fs generic +_require_scratch + +rm -f $seqres.full + +_scratch_mkfs > $seqres.full +_scratch_mount + +# Does our userspace even support large dates? +test_bigdates=1 +touch -d 'May 30 01:53:03 UTC 2514' $SCRATCH_MNT 2>/dev/null || test_bigdates=0 + +# And can we do statx? +test_statx=1 +($XFS_IO_PROG -c 'help statx' | grep -q 'Print raw statx' && \ + $XFS_IO_PROG -c 'statx -r' $SCRATCH_MNT 2>/dev/null | grep -q 'stat.mtime') || \ + test_statx=0 + +echo "Userspace support of large timestamps: $test_bigdates" >> $seqres.full +echo "xfs_io support of statx: $test_statx" >> $seqres.full + +touchme() { + local arg="$1" + local name="$2" + + echo "$arg" > $SCRATCH_MNT/t_$name + touch -d "$arg" $SCRATCH_MNT/t_$name +} + +report() { + local files=($SCRATCH_MNT/t_*) + for file in "${files[@]}"; do + echo "${file}: $(cat "${file}")" + TZ=UTC stat -c '%y %Y %n' "${file}" + test $test_statx -gt 0 && \ + $XFS_IO_PROG -c 'statx -r' "${file}" | grep 'stat.mtime' + done +} + +# -2147483648 (S32_MIN, or classic unix min) +touchme 'Dec 13 20:45:52 UTC 1901' s32_min + +# 2147483647 (S32_MAX, or classic unix max) +touchme 'Jan 19 03:14:07 UTC 2038' s32_max + +# 7956915742, all twos +touchme 'Feb 22 22:22:22 UTC 2222' all_twos + +if [ $test_bigdates -gt 0 ]; then + # 16299260424 (u64 nsec counter from s32_min, like xfs does) + touchme 'Tue Jul 2 20:20:24 UTC 2486' u64ns_from_s32_min + + # 15032385535 (u34 time if you start from s32_min, like ext4 does) + touchme 'May 10 22:38:55 UTC 2446' u34_from_s32_min + + # 17179869183 (u34 time if you start from the unix epoch) + touchme 'May 30 01:53:03 UTC 2514' u34_max + + # Latest date we can synthesize(?) + touchme 'Dec 31 23:59:59 UTC 2147483647' abs_max_time + + # Earliest date we can synthesize(?) + touchme 'Jan 1 00:00:00 UTC 0' abs_min_time +fi + +# Query timestamps from incore +echo before >> $seqres.full +report > $tmp.times0 +cat $tmp.times0 >> $seqres.full + +_scratch_cycle_mount + +# Query timestamps from disk +echo after >> $seqres.full +report > $tmp.times1 +cat $tmp.times1 >> $seqres.full + +# Did they match? +cmp -s $tmp.times0 $tmp.times1 + +# success, all done +status=0 +exit diff --git a/tests/generic/721.out b/tests/generic/721.out new file mode 100644 index 00000000..087decb5 --- /dev/null +++ b/tests/generic/721.out @@ -0,0 +1 @@ +QA output created by 721 diff --git a/tests/generic/722 b/tests/generic/722 new file mode 100755 index 00000000..3e8c553b --- /dev/null +++ b/tests/generic/722 @@ -0,0 +1,120 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2020, Oracle and/or its affiliates. All Rights Reserved. +# +# FS QA Test No. 722 +# +# Make sure we can store and retrieve timestamps on the extremes of the +# date ranges supported by userspace, and the common places where overflows +# can happen. This test also ensures that the timestamps are persisted +# correctly after a shutdown. +# +# This differs from generic/402 in that we don't constrain ourselves to the +# range that the filesystem claims to support; we attempt various things that +# /userspace/ can parse, and then check that the vfs clamps and persists the +# values correctly. + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc + +# real QA test starts here +_supported_fs generic +_require_scratch +_require_scratch_shutdown + +rm -f $seqres.full + +_scratch_mkfs > $seqres.full +_scratch_mount + +# Does our userspace even support large dates? +test_bigdates=1 +touch -d 'May 30 01:53:03 UTC 2514' $SCRATCH_MNT 2>/dev/null || test_bigdates=0 + +# And can we do statx? +test_statx=1 +($XFS_IO_PROG -c 'help statx' | grep -q 'Print raw statx' && \ + $XFS_IO_PROG -c 'statx -r' $SCRATCH_MNT 2>/dev/null | grep -q 'stat.mtime') || \ + test_statx=0 + +echo "Userspace support of large timestamps: $test_bigdates" >> $seqres.full +echo "xfs_io support of statx: $test_statx" >> $seqres.full + +touchme() { + local arg="$1" + local name="$2" + + echo "$arg" > $SCRATCH_MNT/t_$name + touch -d "$arg" $SCRATCH_MNT/t_$name +} + +report() { + local files=($SCRATCH_MNT/t_*) + for file in "${files[@]}"; do + echo "${file}: $(cat "${file}")" + TZ=UTC stat -c '%y %Y %n' "${file}" + test $test_statx -gt 0 && \ + $XFS_IO_PROG -c 'statx -r' "${file}" | grep 'stat.mtime' + done +} + +# -2147483648 (S32_MIN, or classic unix min) +touchme 'Dec 13 20:45:52 UTC 1901' s32_min + +# 2147483647 (S32_MAX, or classic unix max) +touchme 'Jan 19 03:14:07 UTC 2038' s32_max + +# 7956915742, all twos +touchme 'Feb 22 22:22:22 UTC 2222' all_twos + +if [ $test_bigdates -gt 0 ]; then + # 16299260424 (u64 nsec counter from s32_min, like xfs does) + touchme 'Tue Jul 2 20:20:24 UTC 2486' u64ns_from_s32_min + + # 15032385535 (u34 time if you start from s32_min, like ext4 does) + touchme 'May 10 22:38:55 UTC 2446' u34_from_s32_min + + # 17179869183 (u34 time if you start from the unix epoch) + touchme 'May 30 01:53:03 UTC 2514' u34_max + + # Latest date we can synthesize(?) + touchme 'Dec 31 23:59:59 UTC 2147483647' abs_max_time + + # Earliest date we can synthesize(?) + touchme 'Jan 1 00:00:00 UTC 0' abs_min_time +fi + +# Query timestamps from incore +echo before >> $seqres.full +report > $tmp.times0 +cat $tmp.times0 >> $seqres.full + +_scratch_shutdown -f +_scratch_cycle_mount + +# Query timestamps from disk +echo after >> $seqres.full +report > $tmp.times1 +cat $tmp.times1 >> $seqres.full + +# Did they match? +cmp -s $tmp.times0 $tmp.times1 + +# success, all done +status=0 +exit diff --git a/tests/generic/722.out b/tests/generic/722.out new file mode 100644 index 00000000..83acd5cf --- /dev/null +++ b/tests/generic/722.out @@ -0,0 +1 @@ +QA output created by 722 diff --git a/tests/generic/group b/tests/generic/group index cf4fdc23..b533d6b2 100644 --- a/tests/generic/group +++ b/tests/generic/group @@ -615,5 +615,7 @@ 610 auto quick prealloc zero 611 auto quick attr 612 auto quick clone +721 auto quick atime bigtime +722 auto quick atime bigtime 947 auto quick rw clone 948 auto quick rw copy_range