| Message ID | 1604275396-4565-1-git-send-email-fengfei_xi@126.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | xfs: Drop useless comments | expand |
On Mon, Nov 02, 2020 at 08:03:16AM +0800, Fengfei Xi wrote: > The names of functions xfs_buf_get_maps and _xfs_buf_free_pages xfs_buf_get_maps? I don't see any changes for that function...? --D > can fully express their roles. So their comments are redundant. > We could drop them entirely. > > Signed-off-by: Fengfei Xi <fengfei_xi@126.com> > --- > fs/xfs/xfs_buf.c | 6 ------ > 1 file changed, 6 deletions(-) > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index 4e4cf91..2aeed30 100644 > --- a/fs/xfs/xfs_buf.c > +++ b/fs/xfs/xfs_buf.c > @@ -197,9 +197,6 @@ > return 0; > } > > -/* > - * Frees b_pages if it was allocated. > - */ > static void > xfs_buf_free_maps( > struct xfs_buf *bp) > @@ -297,9 +294,6 @@ > return 0; > } > > -/* > - * Frees b_pages if it was allocated. > - */ > STATIC void > _xfs_buf_free_pages( > xfs_buf_t *bp) > -- > 1.9.1 >
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 4e4cf91..2aeed30 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -197,9 +197,6 @@ return 0; } -/* - * Frees b_pages if it was allocated. - */ static void xfs_buf_free_maps( struct xfs_buf *bp) @@ -297,9 +294,6 @@ return 0; } -/* - * Frees b_pages if it was allocated. - */ STATIC void _xfs_buf_free_pages( xfs_buf_t *bp)
The names of functions xfs_buf_get_maps and _xfs_buf_free_pages can fully express their roles. So their comments are redundant. We could drop them entirely. Signed-off-by: Fengfei Xi <fengfei_xi@126.com> --- fs/xfs/xfs_buf.c | 6 ------ 1 file changed, 6 deletions(-)