| Message ID | 161238139753.1278306.12571924344581175091.stgit@magnolia (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | xfs: add the ability to flag a fs for repair | expand |
On Wed, Feb 03, 2021 at 11:43:17AM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > Clean up the string quoting in this script so that we don't trip over > users feeding us arguments like "/dev/sd ha ha ha lol". > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- Reviewed-by: Brian Foster <bfoster@redhat.com> > db/xfs_admin.sh | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/db/xfs_admin.sh b/db/xfs_admin.sh > index bd325da2..71a9aa98 100755 > --- a/db/xfs_admin.sh > +++ b/db/xfs_admin.sh > @@ -43,7 +43,7 @@ case $# in > > if [ -n "$DB_OPTS" ] > then > - eval xfs_db -x -p xfs_admin $DB_OPTS $1 > + eval xfs_db -x -p xfs_admin $DB_OPTS "$1" > status=$? > fi > if [ -n "$REPAIR_OPTS" ] > @@ -53,7 +53,7 @@ case $# in > # running xfs_admin. > # Ideally, we need to improve the output behaviour > # of repair for this purpose (say a "quiet" mode). > - eval xfs_repair $REPAIR_OPTS $1 2> /dev/null > + eval xfs_repair $REPAIR_OPTS "$1" 2> /dev/null > status=`expr $? + $status` > if [ $status -ne 0 ] > then >
diff --git a/db/xfs_admin.sh b/db/xfs_admin.sh index bd325da2..71a9aa98 100755 --- a/db/xfs_admin.sh +++ b/db/xfs_admin.sh @@ -43,7 +43,7 @@ case $# in if [ -n "$DB_OPTS" ] then - eval xfs_db -x -p xfs_admin $DB_OPTS $1 + eval xfs_db -x -p xfs_admin $DB_OPTS "$1" status=$? fi if [ -n "$REPAIR_OPTS" ] @@ -53,7 +53,7 @@ case $# in # running xfs_admin. # Ideally, we need to improve the output behaviour # of repair for this purpose (say a "quiet" mode). - eval xfs_repair $REPAIR_OPTS $1 2> /dev/null + eval xfs_repair $REPAIR_OPTS "$1" 2> /dev/null status=`expr $? + $status` if [ $status -ne 0 ] then