| Message ID | 161526482563.1214319.7317631500409765514.stgit@magnolia (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | fstests: test kernel regressions fixed in 5.12 | expand |
On 09 Mar 2021 at 10:10, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > In "mkfs: set required parts of the realtime geometry before computing > log geometry" we made sure that mkfs set up enough of the fs geometry to > compute the minimum xfs log size correctly when formatting the > filesystem. This is the regression test for that issue. > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- > tests/xfs/761 | 45 +++++++++++++++++++++++++++++++++++++++++++++ > tests/xfs/761.out | 1 + > tests/xfs/group | 1 + > 3 files changed, 47 insertions(+) > create mode 100755 tests/xfs/761 > create mode 100644 tests/xfs/761.out > > > diff --git a/tests/xfs/761 b/tests/xfs/761 > new file mode 100755 > index 00000000..b9770d90 > --- /dev/null > +++ b/tests/xfs/761 > @@ -0,0 +1,45 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0-or-later > +# Copyright (c) 2021 Oracle. All Rights Reserved. > +# > +# FS QA Test No. 761 > +# > +# Make sure mkfs sets up enough of the rt geometry that we can compute the > +# correct min log size for formatting the fs. > +# > +# This is a regression test for the xfsprogs commit 31409f48 ("mkfs: set > +# required parts of the realtime geometry before computing log geometry"). > + > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + cd / > + rm -f $tmp.* > +} > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/filter > + > +# real QA test starts here > +_supported_fs xfs > +_require_scratch > +_require_realtime > + > +rm -f $seqres.full > + > +# Format a tiny filesystem to force minimum log size, then see if it mounts > +_scratch_mkfs -r size=1m -d size=100m > $seqres.full > +_scratch_mount >> $seqres.full > + > +# success, all done > +status=0 > +exit > diff --git a/tests/xfs/761.out b/tests/xfs/761.out > new file mode 100644 > index 00000000..8c9d9e90 > --- /dev/null > +++ b/tests/xfs/761.out > @@ -0,0 +1 @@ > +QA output created by 761 > diff --git a/tests/xfs/group b/tests/xfs/group > index 318468b5..87badd56 100644 > --- a/tests/xfs/group > +++ b/tests/xfs/group > @@ -503,4 +503,5 @@ > 758 auto quick rw attr realtime > 759 auto quick rw realtime > 760 auto quick rw collapse punch insert zero prealloc > +761 auto quick realtime Maybe "mount" should be added to the above list. Rest looks good to me. Reviewed-by: Chandan Babu R <chandanrlinux@gmail.com>
On Mon, Mar 08, 2021 at 08:40:25PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > In "mkfs: set required parts of the realtime geometry before computing > log geometry" we made sure that mkfs set up enough of the fs geometry to > compute the minimum xfs log size correctly when formatting the > filesystem. This is the regression test for that issue. > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- > tests/xfs/761 | 45 +++++++++++++++++++++++++++++++++++++++++++++ > tests/xfs/761.out | 1 + > tests/xfs/group | 1 + > 3 files changed, 47 insertions(+) > create mode 100755 tests/xfs/761 > create mode 100644 tests/xfs/761.out > > > diff --git a/tests/xfs/761 b/tests/xfs/761 > new file mode 100755 > index 00000000..b9770d90 > --- /dev/null > +++ b/tests/xfs/761 > @@ -0,0 +1,45 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0-or-later > +# Copyright (c) 2021 Oracle. All Rights Reserved. > +# > +# FS QA Test No. 761 > +# > +# Make sure mkfs sets up enough of the rt geometry that we can compute the > +# correct min log size for formatting the fs. > +# > +# This is a regression test for the xfsprogs commit 31409f48 ("mkfs: set > +# required parts of the realtime geometry before computing log geometry"). > + > +seq=`basename $0` > +seqres=$RESULT_DIR/$seq > +echo "QA output created by $seq" > + > +here=`pwd` > +tmp=/tmp/$$ > +status=1 # failure is the default! > +trap "_cleanup; exit \$status" 0 1 2 3 15 > + > +_cleanup() > +{ > + cd / > + rm -f $tmp.* > +} > + > +# get standard environment, filters and checks > +. ./common/rc > +. ./common/filter > + > +# real QA test starts here > +_supported_fs xfs > +_require_scratch > +_require_realtime > + > +rm -f $seqres.full > + > +# Format a tiny filesystem to force minimum log size, then see if it mounts > +_scratch_mkfs -r size=1m -d size=100m > $seqres.full > +_scratch_mount >> $seqres.full > + > +# success, all done > +status=0 > +exit > diff --git a/tests/xfs/761.out b/tests/xfs/761.out > new file mode 100644 > index 00000000..8c9d9e90 > --- /dev/null > +++ b/tests/xfs/761.out > @@ -0,0 +1 @@ > +QA output created by 761 Need "Silence is golden" in .out file if you're going to respin it, otherwise I can fix it on commit. Thanks, Eryu > diff --git a/tests/xfs/group b/tests/xfs/group > index 318468b5..87badd56 100644 > --- a/tests/xfs/group > +++ b/tests/xfs/group > @@ -503,4 +503,5 @@ > 758 auto quick rw attr realtime > 759 auto quick rw realtime > 760 auto quick rw collapse punch insert zero prealloc > +761 auto quick realtime > 763 auto quick rw realtime
On Sun, Mar 14, 2021 at 10:51:41PM +0800, Eryu Guan wrote: > On Mon, Mar 08, 2021 at 08:40:25PM -0800, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@kernel.org> > > > > In "mkfs: set required parts of the realtime geometry before computing > > log geometry" we made sure that mkfs set up enough of the fs geometry to > > compute the minimum xfs log size correctly when formatting the > > filesystem. This is the regression test for that issue. > > > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > > --- > > tests/xfs/761 | 45 +++++++++++++++++++++++++++++++++++++++++++++ > > tests/xfs/761.out | 1 + > > tests/xfs/group | 1 + > > 3 files changed, 47 insertions(+) > > create mode 100755 tests/xfs/761 > > create mode 100644 tests/xfs/761.out > > > > > > diff --git a/tests/xfs/761 b/tests/xfs/761 > > new file mode 100755 > > index 00000000..b9770d90 > > --- /dev/null > > +++ b/tests/xfs/761 > > @@ -0,0 +1,45 @@ > > +#! /bin/bash > > +# SPDX-License-Identifier: GPL-2.0-or-later > > +# Copyright (c) 2021 Oracle. All Rights Reserved. > > +# > > +# FS QA Test No. 761 > > +# > > +# Make sure mkfs sets up enough of the rt geometry that we can compute the > > +# correct min log size for formatting the fs. > > +# > > +# This is a regression test for the xfsprogs commit 31409f48 ("mkfs: set > > +# required parts of the realtime geometry before computing log geometry"). > > + > > +seq=`basename $0` > > +seqres=$RESULT_DIR/$seq > > +echo "QA output created by $seq" > > + > > +here=`pwd` > > +tmp=/tmp/$$ > > +status=1 # failure is the default! > > +trap "_cleanup; exit \$status" 0 1 2 3 15 > > + > > +_cleanup() > > +{ > > + cd / > > + rm -f $tmp.* > > +} > > + > > +# get standard environment, filters and checks > > +. ./common/rc > > +. ./common/filter > > + > > +# real QA test starts here > > +_supported_fs xfs > > +_require_scratch > > +_require_realtime > > + > > +rm -f $seqres.full > > + > > +# Format a tiny filesystem to force minimum log size, then see if it mounts > > +_scratch_mkfs -r size=1m -d size=100m > $seqres.full > > +_scratch_mount >> $seqres.full > > + > > +# success, all done > > +status=0 > > +exit > > diff --git a/tests/xfs/761.out b/tests/xfs/761.out > > new file mode 100644 > > index 00000000..8c9d9e90 > > --- /dev/null > > +++ b/tests/xfs/761.out > > @@ -0,0 +1 @@ > > +QA output created by 761 > > Need "Silence is golden" in .out file if you're going to respin it, > otherwise I can fix it on commit. Never mind, I've applied it with .out file fixed, and added 'mount' group as Chandan suggested. Thanks, Eryu
diff --git a/tests/xfs/761 b/tests/xfs/761 new file mode 100755 index 00000000..b9770d90 --- /dev/null +++ b/tests/xfs/761 @@ -0,0 +1,45 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0-or-later +# Copyright (c) 2021 Oracle. All Rights Reserved. +# +# FS QA Test No. 761 +# +# Make sure mkfs sets up enough of the rt geometry that we can compute the +# correct min log size for formatting the fs. +# +# This is a regression test for the xfsprogs commit 31409f48 ("mkfs: set +# required parts of the realtime geometry before computing log geometry"). + +seq=`basename $0` +seqres=$RESULT_DIR/$seq +echo "QA output created by $seq" + +here=`pwd` +tmp=/tmp/$$ +status=1 # failure is the default! +trap "_cleanup; exit \$status" 0 1 2 3 15 + +_cleanup() +{ + cd / + rm -f $tmp.* +} + +# get standard environment, filters and checks +. ./common/rc +. ./common/filter + +# real QA test starts here +_supported_fs xfs +_require_scratch +_require_realtime + +rm -f $seqres.full + +# Format a tiny filesystem to force minimum log size, then see if it mounts +_scratch_mkfs -r size=1m -d size=100m > $seqres.full +_scratch_mount >> $seqres.full + +# success, all done +status=0 +exit diff --git a/tests/xfs/761.out b/tests/xfs/761.out new file mode 100644 index 00000000..8c9d9e90 --- /dev/null +++ b/tests/xfs/761.out @@ -0,0 +1 @@ +QA output created by 761 diff --git a/tests/xfs/group b/tests/xfs/group index 318468b5..87badd56 100644 --- a/tests/xfs/group +++ b/tests/xfs/group @@ -503,4 +503,5 @@ 758 auto quick rw attr realtime 759 auto quick rw realtime 760 auto quick rw collapse punch insert zero prealloc +761 auto quick realtime 763 auto quick rw realtime