| Message ID | 1622883170-33317-1-git-send-email-zhangshaokun@hisilicon.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfs: remove redundant initialization of variable error | expand |
Hi, On Sat, Jun 05, 2021 at 04:52:50PM +0800, Shaokun Zhang wrote: > 'error' will be initialized, so clean up the redundant initialization. > > Cc: "Darrick J. Wong" <djwong@kernel.org> > Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com> This makes no difference in the resulting code. Particularly, I'd rather have such variables explicitly initialized. This function is small, so it's easy to see its initialization later in the code, but still, IMHO, it's way better to see the 'default error values' explicit at the beginning of the function. But, it's just my 'visual' preference :) > --- > fs/xfs/xfs_buf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index 592800c8852f..59991c8c7127 100644 > --- a/fs/xfs/xfs_buf.c > +++ b/fs/xfs/xfs_buf.c > @@ -707,7 +707,7 @@ xfs_buf_get_map( > { > struct xfs_buf *bp; > struct xfs_buf *new_bp; > - int error = 0; > + int error; > > *bpp = NULL; > error = xfs_buf_find(target, map, nmaps, flags, NULL, &bp); > -- > 2.7.4 >
Hi Carlos, On 2021/6/7 21:13, Carlos Maiolino wrote: > Hi, > > On Sat, Jun 05, 2021 at 04:52:50PM +0800, Shaokun Zhang wrote: >> 'error' will be initialized, so clean up the redundant initialization. >> >> Cc: "Darrick J. Wong" <djwong@kernel.org> >> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com> > > > This makes no difference in the resulting code. > Particularly, I'd rather have such variables explicitly initialized. This > function is small, so it's easy to see its initialization later in the code, but > still, IMHO, it's way better to see the 'default error values' explicit at the > beginning of the function. But, it's just my 'visual' preference :) Thanks your reply, as you also said that it would be assigned later, the initialization is unnecessary. I'm fine that Darrick will take it or not. Cheers, Shaokun > > >> --- >> fs/xfs/xfs_buf.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c >> index 592800c8852f..59991c8c7127 100644 >> --- a/fs/xfs/xfs_buf.c >> +++ b/fs/xfs/xfs_buf.c >> @@ -707,7 +707,7 @@ xfs_buf_get_map( >> { >> struct xfs_buf *bp; >> struct xfs_buf *new_bp; >> - int error = 0; >> + int error; >> >> *bpp = NULL; >> error = xfs_buf_find(target, map, nmaps, flags, NULL, &bp); >> -- >> 2.7.4 >> >
On Sat, Jun 05, 2021 at 04:52:50PM +0800, Shaokun Zhang wrote: > 'error' will be initialized, so clean up the redundant initialization. > > Cc: "Darrick J. Wong" <djwong@kernel.org> > Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com> Looks ok, Reviewed-by: Darrick J. Wong <djwong@kernel.org> --D > --- > fs/xfs/xfs_buf.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c > index 592800c8852f..59991c8c7127 100644 > --- a/fs/xfs/xfs_buf.c > +++ b/fs/xfs/xfs_buf.c > @@ -707,7 +707,7 @@ xfs_buf_get_map( > { > struct xfs_buf *bp; > struct xfs_buf *new_bp; > - int error = 0; > + int error; > > *bpp = NULL; > error = xfs_buf_find(target, map, nmaps, flags, NULL, &bp); > -- > 2.7.4 >
diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index 592800c8852f..59991c8c7127 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -707,7 +707,7 @@ xfs_buf_get_map( { struct xfs_buf *bp; struct xfs_buf *new_bp; - int error = 0; + int error; *bpp = NULL; error = xfs_buf_find(target, map, nmaps, flags, NULL, &bp);
'error' will be initialized, so clean up the redundant initialization. Cc: "Darrick J. Wong" <djwong@kernel.org> Signed-off-by: Shaokun Zhang <zhangshaokun@hisilicon.com> --- fs/xfs/xfs_buf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)