| Message ID | 163466953269.2235671.2810573391142102057.stgit@magnolia (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | xfs: use slab caches for deferred log items | expand |
On 20 Oct 2021 at 00:22, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > Rearrange these structs to reduce the amount of unused padding bytes. > This saves eight bytes for each of the three structs changed here, which > means they're now all (rmap/bmap are 64 bytes, refc is 32 bytes) even > powers of two. > Looks good to me. Reviewed-by: Chandan Babu R <chandan.babu@oracle.com> > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- > fs/xfs/libxfs/xfs_bmap.h | 2 +- > fs/xfs/libxfs/xfs_refcount.h | 2 +- > fs/xfs/libxfs/xfs_rmap.h | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > > diff --git a/fs/xfs/libxfs/xfs_bmap.h b/fs/xfs/libxfs/xfs_bmap.h > index 2cd7717cf753..db01fe83bb8a 100644 > --- a/fs/xfs/libxfs/xfs_bmap.h > +++ b/fs/xfs/libxfs/xfs_bmap.h > @@ -257,8 +257,8 @@ enum xfs_bmap_intent_type { > struct xfs_bmap_intent { > struct list_head bi_list; > enum xfs_bmap_intent_type bi_type; > - struct xfs_inode *bi_owner; > int bi_whichfork; > + struct xfs_inode *bi_owner; > struct xfs_bmbt_irec bi_bmap; > }; > > diff --git a/fs/xfs/libxfs/xfs_refcount.h b/fs/xfs/libxfs/xfs_refcount.h > index 02cb3aa405be..894045968bc6 100644 > --- a/fs/xfs/libxfs/xfs_refcount.h > +++ b/fs/xfs/libxfs/xfs_refcount.h > @@ -32,8 +32,8 @@ enum xfs_refcount_intent_type { > struct xfs_refcount_intent { > struct list_head ri_list; > enum xfs_refcount_intent_type ri_type; > - xfs_fsblock_t ri_startblock; > xfs_extlen_t ri_blockcount; > + xfs_fsblock_t ri_startblock; > }; > > void xfs_refcount_increase_extent(struct xfs_trans *tp, > diff --git a/fs/xfs/libxfs/xfs_rmap.h b/fs/xfs/libxfs/xfs_rmap.h > index fd67904ed446..85dd98ac3f12 100644 > --- a/fs/xfs/libxfs/xfs_rmap.h > +++ b/fs/xfs/libxfs/xfs_rmap.h > @@ -159,8 +159,8 @@ enum xfs_rmap_intent_type { > struct xfs_rmap_intent { > struct list_head ri_list; > enum xfs_rmap_intent_type ri_type; > - uint64_t ri_owner; > int ri_whichfork; > + uint64_t ri_owner; > struct xfs_bmbt_irec ri_bmap; > }; >
diff --git a/fs/xfs/libxfs/xfs_bmap.h b/fs/xfs/libxfs/xfs_bmap.h index 2cd7717cf753..db01fe83bb8a 100644 --- a/fs/xfs/libxfs/xfs_bmap.h +++ b/fs/xfs/libxfs/xfs_bmap.h @@ -257,8 +257,8 @@ enum xfs_bmap_intent_type { struct xfs_bmap_intent { struct list_head bi_list; enum xfs_bmap_intent_type bi_type; - struct xfs_inode *bi_owner; int bi_whichfork; + struct xfs_inode *bi_owner; struct xfs_bmbt_irec bi_bmap; }; diff --git a/fs/xfs/libxfs/xfs_refcount.h b/fs/xfs/libxfs/xfs_refcount.h index 02cb3aa405be..894045968bc6 100644 --- a/fs/xfs/libxfs/xfs_refcount.h +++ b/fs/xfs/libxfs/xfs_refcount.h @@ -32,8 +32,8 @@ enum xfs_refcount_intent_type { struct xfs_refcount_intent { struct list_head ri_list; enum xfs_refcount_intent_type ri_type; - xfs_fsblock_t ri_startblock; xfs_extlen_t ri_blockcount; + xfs_fsblock_t ri_startblock; }; void xfs_refcount_increase_extent(struct xfs_trans *tp, diff --git a/fs/xfs/libxfs/xfs_rmap.h b/fs/xfs/libxfs/xfs_rmap.h index fd67904ed446..85dd98ac3f12 100644 --- a/fs/xfs/libxfs/xfs_rmap.h +++ b/fs/xfs/libxfs/xfs_rmap.h @@ -159,8 +159,8 @@ enum xfs_rmap_intent_type { struct xfs_rmap_intent { struct list_head ri_list; enum xfs_rmap_intent_type ri_type; - uint64_t ri_owner; int ri_whichfork; + uint64_t ri_owner; struct xfs_bmbt_irec ri_bmap; };