| Message ID | 163466955467.2235671.4983293287731225085.stgit@magnolia (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | xfs: use slab caches for deferred log items | expand |
On 20 Oct 2021 at 00:22, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > The owner info parameter is always NULL, so get rid of the parameter. Looks good to me. Reviewed-by: Chandan Babu R <chandan.babu@oracle.com> > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- > fs/xfs/libxfs/xfs_refcount.c | 19 ++++++++----------- > 1 file changed, 8 insertions(+), 11 deletions(-) > > > diff --git a/fs/xfs/libxfs/xfs_refcount.c b/fs/xfs/libxfs/xfs_refcount.c > index bb9e256f4970..327ba25e9e17 100644 > --- a/fs/xfs/libxfs/xfs_refcount.c > +++ b/fs/xfs/libxfs/xfs_refcount.c > @@ -918,8 +918,7 @@ xfs_refcount_adjust_extents( > struct xfs_btree_cur *cur, > xfs_agblock_t *agbno, > xfs_extlen_t *aglen, > - enum xfs_refc_adjust_op adj, > - struct xfs_owner_info *oinfo) > + enum xfs_refc_adjust_op adj) > { > struct xfs_refcount_irec ext, tmp; > int error; > @@ -977,7 +976,7 @@ xfs_refcount_adjust_extents( > cur->bc_ag.pag->pag_agno, > tmp.rc_startblock); > xfs_free_extent_later(cur->bc_tp, fsbno, > - tmp.rc_blockcount, oinfo); > + tmp.rc_blockcount, NULL); > } > > (*agbno) += tmp.rc_blockcount; > @@ -1021,8 +1020,8 @@ xfs_refcount_adjust_extents( > fsbno = XFS_AGB_TO_FSB(cur->bc_mp, > cur->bc_ag.pag->pag_agno, > ext.rc_startblock); > - xfs_free_extent_later(cur->bc_tp, fsbno, ext.rc_blockcount, > - oinfo); > + xfs_free_extent_later(cur->bc_tp, fsbno, > + ext.rc_blockcount, NULL); > } > > skip: > @@ -1050,8 +1049,7 @@ xfs_refcount_adjust( > xfs_extlen_t aglen, > xfs_agblock_t *new_agbno, > xfs_extlen_t *new_aglen, > - enum xfs_refc_adjust_op adj, > - struct xfs_owner_info *oinfo) > + enum xfs_refc_adjust_op adj) > { > bool shape_changed; > int shape_changes = 0; > @@ -1094,8 +1092,7 @@ xfs_refcount_adjust( > cur->bc_ag.refc.shape_changes++; > > /* Now that we've taken care of the ends, adjust the middle extents */ > - error = xfs_refcount_adjust_extents(cur, new_agbno, new_aglen, > - adj, oinfo); > + error = xfs_refcount_adjust_extents(cur, new_agbno, new_aglen, adj); > if (error) > goto out_error; > > @@ -1190,12 +1187,12 @@ xfs_refcount_finish_one( > switch (type) { > case XFS_REFCOUNT_INCREASE: > error = xfs_refcount_adjust(rcur, bno, blockcount, &new_agbno, > - new_len, XFS_REFCOUNT_ADJUST_INCREASE, NULL); > + new_len, XFS_REFCOUNT_ADJUST_INCREASE); > *new_fsb = XFS_AGB_TO_FSB(mp, pag->pag_agno, new_agbno); > break; > case XFS_REFCOUNT_DECREASE: > error = xfs_refcount_adjust(rcur, bno, blockcount, &new_agbno, > - new_len, XFS_REFCOUNT_ADJUST_DECREASE, NULL); > + new_len, XFS_REFCOUNT_ADJUST_DECREASE); > *new_fsb = XFS_AGB_TO_FSB(mp, pag->pag_agno, new_agbno); > break; > case XFS_REFCOUNT_ALLOC_COW:
diff --git a/fs/xfs/libxfs/xfs_refcount.c b/fs/xfs/libxfs/xfs_refcount.c index bb9e256f4970..327ba25e9e17 100644 --- a/fs/xfs/libxfs/xfs_refcount.c +++ b/fs/xfs/libxfs/xfs_refcount.c @@ -918,8 +918,7 @@ xfs_refcount_adjust_extents( struct xfs_btree_cur *cur, xfs_agblock_t *agbno, xfs_extlen_t *aglen, - enum xfs_refc_adjust_op adj, - struct xfs_owner_info *oinfo) + enum xfs_refc_adjust_op adj) { struct xfs_refcount_irec ext, tmp; int error; @@ -977,7 +976,7 @@ xfs_refcount_adjust_extents( cur->bc_ag.pag->pag_agno, tmp.rc_startblock); xfs_free_extent_later(cur->bc_tp, fsbno, - tmp.rc_blockcount, oinfo); + tmp.rc_blockcount, NULL); } (*agbno) += tmp.rc_blockcount; @@ -1021,8 +1020,8 @@ xfs_refcount_adjust_extents( fsbno = XFS_AGB_TO_FSB(cur->bc_mp, cur->bc_ag.pag->pag_agno, ext.rc_startblock); - xfs_free_extent_later(cur->bc_tp, fsbno, ext.rc_blockcount, - oinfo); + xfs_free_extent_later(cur->bc_tp, fsbno, + ext.rc_blockcount, NULL); } skip: @@ -1050,8 +1049,7 @@ xfs_refcount_adjust( xfs_extlen_t aglen, xfs_agblock_t *new_agbno, xfs_extlen_t *new_aglen, - enum xfs_refc_adjust_op adj, - struct xfs_owner_info *oinfo) + enum xfs_refc_adjust_op adj) { bool shape_changed; int shape_changes = 0; @@ -1094,8 +1092,7 @@ xfs_refcount_adjust( cur->bc_ag.refc.shape_changes++; /* Now that we've taken care of the ends, adjust the middle extents */ - error = xfs_refcount_adjust_extents(cur, new_agbno, new_aglen, - adj, oinfo); + error = xfs_refcount_adjust_extents(cur, new_agbno, new_aglen, adj); if (error) goto out_error; @@ -1190,12 +1187,12 @@ xfs_refcount_finish_one( switch (type) { case XFS_REFCOUNT_INCREASE: error = xfs_refcount_adjust(rcur, bno, blockcount, &new_agbno, - new_len, XFS_REFCOUNT_ADJUST_INCREASE, NULL); + new_len, XFS_REFCOUNT_ADJUST_INCREASE); *new_fsb = XFS_AGB_TO_FSB(mp, pag->pag_agno, new_agbno); break; case XFS_REFCOUNT_DECREASE: error = xfs_refcount_adjust(rcur, bno, blockcount, &new_agbno, - new_len, XFS_REFCOUNT_ADJUST_DECREASE, NULL); + new_len, XFS_REFCOUNT_ADJUST_DECREASE); *new_fsb = XFS_AGB_TO_FSB(mp, pag->pag_agno, new_agbno); break; case XFS_REFCOUNT_ALLOC_COW: