| Message ID | 164740142591.3371628.12793589713189041823.stgit@magnolia (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | fstests: random fixes | expand |
On Tue, Mar 15, 2022 at 08:30:25PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > Filipe Manana pointed out[1] that the setgid dropping behavior encoded > in this generic test is based on some outdated XFS code, and not based > on what the VFS inode attribute change functions actually do. Now that > we're working on fixing that, we should update the golden output to > reflect what all filesystems are supposed to be doing. > > [1] https://lore.kernel.org/linux-xfs/CAL3q7H47iNQ=Wmk83WcGB-KBJVOEtR9+qGczzCeXJ9Y2KCV25Q@mail.gmail.com/ > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- Thanks for making this change clear. As this's a generic test, other filesystem might hit new failures if this test passed on them before. And hope some downstream XFS users won't report too many customer bugs to us :) Anyway, it's good to me. Reviewed-by: Zorro Lang <zlang@redhat.com> > tests/generic/673.out | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > > diff --git a/tests/generic/673.out b/tests/generic/673.out > index 8df672d6..4d18bca2 100644 > --- a/tests/generic/673.out > +++ b/tests/generic/673.out > @@ -3,7 +3,7 @@ Test 1 - qa_user, non-exec file > 310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/a > 6666 -rwSrwSrw- SCRATCH_MNT/a > 3784de23efab7a2074c9ec66901e39e5 SCRATCH_MNT/a > -2666 -rw-rwSrw- SCRATCH_MNT/a > +666 -rw-rw-rw- SCRATCH_MNT/a > > Test 2 - qa_user, group-exec file > 310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/a > @@ -15,7 +15,7 @@ Test 3 - qa_user, user-exec file > 310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/a > 6766 -rwsrwSrw- SCRATCH_MNT/a > 3784de23efab7a2074c9ec66901e39e5 SCRATCH_MNT/a > -2766 -rwxrwSrw- SCRATCH_MNT/a > +766 -rwxrw-rw- SCRATCH_MNT/a > > Test 4 - qa_user, all-exec file > 310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/a >
diff --git a/tests/generic/673.out b/tests/generic/673.out index 8df672d6..4d18bca2 100644 --- a/tests/generic/673.out +++ b/tests/generic/673.out @@ -3,7 +3,7 @@ Test 1 - qa_user, non-exec file 310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/a 6666 -rwSrwSrw- SCRATCH_MNT/a 3784de23efab7a2074c9ec66901e39e5 SCRATCH_MNT/a -2666 -rw-rwSrw- SCRATCH_MNT/a +666 -rw-rw-rw- SCRATCH_MNT/a Test 2 - qa_user, group-exec file 310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/a @@ -15,7 +15,7 @@ Test 3 - qa_user, user-exec file 310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/a 6766 -rwsrwSrw- SCRATCH_MNT/a 3784de23efab7a2074c9ec66901e39e5 SCRATCH_MNT/a -2766 -rwxrwSrw- SCRATCH_MNT/a +766 -rwxrw-rw- SCRATCH_MNT/a Test 4 - qa_user, all-exec file 310f146ce52077fcd3308dcbe7632bb2 SCRATCH_MNT/a