diff mbox series

[2/2] generic/019: fix incorrect unset statements

Message ID 165038952637.1677615.2651496553218188517.stgit@magnolia (mailing list archive)
State New, archived
Headers show
Series fstests: random fixes | expand

Commit Message

Darrick J. Wong April 19, 2022, 5:32 p.m. UTC
From: Darrick J. Wong <djwong@kernel.org>

Fix incorrect usage of unset -- one passes the name of the variable, not
the *value* contained within it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/generic/019 |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Zorro Lang April 19, 2022, 6:34 p.m. UTC | #1
On Tue, Apr 19, 2022 at 10:32:06AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Fix incorrect usage of unset -- one passes the name of the variable, not
> the *value* contained within it.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---

Good to me,
Reviewed-by: Zorro Lang <zlang@redhat.com>

>  tests/generic/019 |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> 
> diff --git a/tests/generic/019 b/tests/generic/019
> index 854ba57d..45c91624 100755
> --- a/tests/generic/019
> +++ b/tests/generic/019
> @@ -140,8 +140,8 @@ _workout()
>  	kill $fs_pid &> /dev/null
>  	wait $fs_pid
>  	wait $fio_pid
> -	unset $fs_pid
> -	unset $fio_pid
> +	unset fs_pid
> +	unset fio_pid
>  
>  	# We expect that broken FS still can be umounted
>  	run_check _scratch_unmount
>
diff mbox series

Patch

diff --git a/tests/generic/019 b/tests/generic/019
index 854ba57d..45c91624 100755
--- a/tests/generic/019
+++ b/tests/generic/019
@@ -140,8 +140,8 @@  _workout()
 	kill $fs_pid &> /dev/null
 	wait $fs_pid
 	wait $fio_pid
-	unset $fs_pid
-	unset $fio_pid
+	unset fs_pid
+	unset fio_pid
 
 	# We expect that broken FS still can be umounted
 	run_check _scratch_unmount