| Message ID | 166473479526.1083393.2162985380296325620.stgit@magnolia (mailing list archive) |
|---|---|
| State | Accepted, archived |
| Headers | show |
| Series | xfs: fix incorrect return values in online fsck | expand |
On Sun, Oct 02, 2022 at 11:19:55AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > If the program calling online fsck is terminated with a fatal signal, > bail out to userspace by returning EINTR, not EAGAIN. EAGAIN is used by > scrubbers to indicate that we should try again with more resources > locked, and not to indicate that the operation was cancelled. The > miswiring is mostly harmless, but it shows up in the trace data. > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- > fs/xfs/scrub/common.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/fs/xfs/scrub/common.h b/fs/xfs/scrub/common.h > index 454145db10e7..b73648d81d23 100644 > --- a/fs/xfs/scrub/common.h > +++ b/fs/xfs/scrub/common.h > @@ -25,7 +25,7 @@ xchk_should_terminate( > > if (fatal_signal_pending(current)) { > if (*error == 0) > - *error = -EAGAIN; > + *error = -EINTR; > return true; > } > return false; Makes sense. Reviewed-by: Dave Chinner <dchinner@redhat.com>
diff --git a/fs/xfs/scrub/common.h b/fs/xfs/scrub/common.h index 454145db10e7..b73648d81d23 100644 --- a/fs/xfs/scrub/common.h +++ b/fs/xfs/scrub/common.h @@ -25,7 +25,7 @@ xchk_should_terminate( if (fatal_signal_pending(current)) { if (*error == 0) - *error = -EAGAIN; + *error = -EINTR; return true; } return false;