diff mbox series

[2/3] xfs: fix reflink test failures when dax is enabled

Message ID 167400102472.1914858.16726369189467075623.stgit@magnolia (mailing list archive)
State New, archived
Headers show
Series fstests: fix dax+reflink tests | expand

Commit Message

Darrick J. Wong Jan. 18, 2023, 12:42 a.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Turn off reflink tests that require delayed allocation to work, because
we don't use delayed allocation when fsdax mode is turned on.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/184 |    1 +
 tests/xfs/192 |    1 +
 tests/xfs/200 |    1 +
 tests/xfs/204 |    1 +
 tests/xfs/232 |    1 +
 tests/xfs/440 |    1 +
 6 files changed, 6 insertions(+)

Comments

Xiao Yang Jan. 18, 2023, 5:10 a.m. UTC | #1 
Hi Darrick,

Thanks for your quick fix. It's better than my patch.
Reviewed-by: Xiao Yang <yangx.jy@fujitsu.com>

Best Regards,
Xiao Yang

On 2023/1/18 8:42, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Turn off reflink tests that require delayed allocation to work, because
> we don't use delayed allocation when fsdax mode is turned on.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>   tests/xfs/184 |    1 +
>   tests/xfs/192 |    1 +
>   tests/xfs/200 |    1 +
>   tests/xfs/204 |    1 +
>   tests/xfs/232 |    1 +
>   tests/xfs/440 |    1 +
>   6 files changed, 6 insertions(+)
> 
> 
> diff --git a/tests/xfs/184 b/tests/xfs/184
> index c251040e8a..3bdd86addf 100755
> --- a/tests/xfs/184
> +++ b/tests/xfs/184
> @@ -19,6 +19,7 @@ _begin_fstest auto quick clone fiemap unshare
>   
>   # real QA test starts here
>   _supported_fs xfs
> +_require_scratch_delalloc
>   _require_scratch_reflink
>   _require_cp_reflink
>   _require_xfs_io_command "fiemap"
> diff --git a/tests/xfs/192 b/tests/xfs/192
> index 85ed7a48fc..ced18fa3c1 100755
> --- a/tests/xfs/192
> +++ b/tests/xfs/192
> @@ -19,6 +19,7 @@ _begin_fstest auto quick clone fiemap unshare
>   
>   # real QA test starts here
>   _supported_fs xfs
> +_require_scratch_delalloc
>   _require_scratch_reflink
>   _require_cp_reflink
>   _require_xfs_io_command "fiemap"
> diff --git a/tests/xfs/200 b/tests/xfs/200
> index f91bfbf478..b51b9a54f5 100755
> --- a/tests/xfs/200
> +++ b/tests/xfs/200
> @@ -21,6 +21,7 @@ _begin_fstest auto quick clone fiemap unshare
>   
>   # real QA test starts here
>   _supported_fs xfs
> +_require_scratch_delalloc
>   _require_scratch_reflink
>   _require_cp_reflink
>   _require_xfs_io_command "fiemap"
> diff --git a/tests/xfs/204 b/tests/xfs/204
> index d034446bbc..ca21dfe722 100755
> --- a/tests/xfs/204
> +++ b/tests/xfs/204
> @@ -21,6 +21,7 @@ _begin_fstest auto quick clone fiemap unshare
>   
>   # real QA test starts here
>   _supported_fs xfs
> +_require_scratch_delalloc
>   _require_scratch_reflink
>   _require_cp_reflink
>   _require_xfs_io_command "fiemap"
> diff --git a/tests/xfs/232 b/tests/xfs/232
> index f402ad6cf3..59bbc43686 100755
> --- a/tests/xfs/232
> +++ b/tests/xfs/232
> @@ -30,6 +30,7 @@ _cleanup()
>   
>   # real QA test starts here
>   _supported_fs xfs
> +_require_scratch_delalloc
>   _require_xfs_io_command "cowextsize"
>   _require_scratch_reflink
>   _require_cp_reflink
> diff --git a/tests/xfs/440 b/tests/xfs/440
> index 496ee04edf..368ee8a05d 100755
> --- a/tests/xfs/440
> +++ b/tests/xfs/440
> @@ -20,6 +20,7 @@ _begin_fstest auto quick clone quota
>   _supported_fs xfs
>   
>   _require_quota
> +_require_scratch_delalloc
>   _require_scratch_reflink
>   _require_cp_reflink
>   _require_user
>
diff mbox series

Patch

diff --git a/tests/xfs/184 b/tests/xfs/184
index c251040e8a..3bdd86addf 100755
--- a/tests/xfs/184
+++ b/tests/xfs/184
@@ -19,6 +19,7 @@  _begin_fstest auto quick clone fiemap unshare
 
 # real QA test starts here
 _supported_fs xfs
+_require_scratch_delalloc
 _require_scratch_reflink
 _require_cp_reflink
 _require_xfs_io_command "fiemap"
diff --git a/tests/xfs/192 b/tests/xfs/192
index 85ed7a48fc..ced18fa3c1 100755
--- a/tests/xfs/192
+++ b/tests/xfs/192
@@ -19,6 +19,7 @@  _begin_fstest auto quick clone fiemap unshare
 
 # real QA test starts here
 _supported_fs xfs
+_require_scratch_delalloc
 _require_scratch_reflink
 _require_cp_reflink
 _require_xfs_io_command "fiemap"
diff --git a/tests/xfs/200 b/tests/xfs/200
index f91bfbf478..b51b9a54f5 100755
--- a/tests/xfs/200
+++ b/tests/xfs/200
@@ -21,6 +21,7 @@  _begin_fstest auto quick clone fiemap unshare
 
 # real QA test starts here
 _supported_fs xfs
+_require_scratch_delalloc
 _require_scratch_reflink
 _require_cp_reflink
 _require_xfs_io_command "fiemap"
diff --git a/tests/xfs/204 b/tests/xfs/204
index d034446bbc..ca21dfe722 100755
--- a/tests/xfs/204
+++ b/tests/xfs/204
@@ -21,6 +21,7 @@  _begin_fstest auto quick clone fiemap unshare
 
 # real QA test starts here
 _supported_fs xfs
+_require_scratch_delalloc
 _require_scratch_reflink
 _require_cp_reflink
 _require_xfs_io_command "fiemap"
diff --git a/tests/xfs/232 b/tests/xfs/232
index f402ad6cf3..59bbc43686 100755
--- a/tests/xfs/232
+++ b/tests/xfs/232
@@ -30,6 +30,7 @@  _cleanup()
 
 # real QA test starts here
 _supported_fs xfs
+_require_scratch_delalloc
 _require_xfs_io_command "cowextsize"
 _require_scratch_reflink
 _require_cp_reflink
diff --git a/tests/xfs/440 b/tests/xfs/440
index 496ee04edf..368ee8a05d 100755
--- a/tests/xfs/440
+++ b/tests/xfs/440
@@ -20,6 +20,7 @@  _begin_fstest auto quick clone quota
 _supported_fs xfs
 
 _require_quota
+_require_scratch_delalloc
 _require_scratch_reflink
 _require_cp_reflink
 _require_user