diff mbox series

[1/5] xfs_spaceman: fix broken -g behavior in freesp command

Message ID 167658437328.3590000.18137446679798085024.stgit@magnolia (mailing list archive)
State Accepted
Headers show
Series xfsprogs: random fixes for 6.2 | expand

Commit Message

Darrick J. Wong Feb. 16, 2023, 9:52 p.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Don't zero out the histogram bucket count when turning on group summary
mode -- this will screw up the data structures and it's pointless.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 spaceman/freesp.c |    1 -
 1 file changed, 1 deletion(-)

Comments

Carlos Maiolino Feb. 22, 2023, 8:40 a.m. UTC | #1 
On Thu, Feb 16, 2023 at 01:52:53PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> Don't zero out the histogram bucket count when turning on group summary
> mode -- this will screw up the data structures and it's pointless.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>

> ---
>  spaceman/freesp.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> 
> diff --git a/spaceman/freesp.c b/spaceman/freesp.c
> index 423568a4248..70dcdb5c923 100644
> --- a/spaceman/freesp.c
> +++ b/spaceman/freesp.c
> @@ -284,7 +284,6 @@ init(
>  			speced = 1;
>  			break;
>  		case 'g':
> -			histcount = 0;
>  			gflag++;
>  			break;
>  		case 'h':
>
diff mbox series

Patch

diff --git a/spaceman/freesp.c b/spaceman/freesp.c
index 423568a4248..70dcdb5c923 100644
--- a/spaceman/freesp.c
+++ b/spaceman/freesp.c
@@ -284,7 +284,6 @@  init(
 			speced = 1;
 			break;
 		case 'g':
-			histcount = 0;
 			gflag++;
 			break;
 		case 'h':