diff mbox series

[16/23] xfs: Filter XFS_ATTR_PARENT for getfattr

Message ID	168080824886.615225.3222037053842648091.stgit@frogsfrogsfrogs (mailing list archive)
State	Superseded
Headers	show Return-Path: <linux-xfs-owner@vger.kernel.org> Date: Thu, 06 Apr 2023 12:24:34 -0700 Subject: [PATCH 16/23] xfs: Filter XFS_ATTR_PARENT for getfattr From: "Darrick J. Wong" <djwong@kernel.org> To: djwong@kernel.org Cc: Allison Henderson <allison.henderson@oracle.com>, allison.henderson@oracle.com, linux-xfs@vger.kernel.org Message-ID: <168080824886.615225.3222037053842648091.stgit@frogsfrogsfrogs> In-Reply-To: <168080824634.615225.17234363585853846885.stgit@frogsfrogsfrogs> References: <168080824634.615225.17234363585853846885.stgit@frogsfrogsfrogs> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk
Series	xfs: Parent Pointers \| expand [PATCHSET,v11,00/23] xfs: Parent Pointers [01/23] xfs: Expose init_xattrs in xfs_create_tmpfile [02/23] xfs: Increase XFS_DEFER_OPS_NR_INODES to 5 [03/23] xfs: Increase XFS_QM_TRANS_MAXDQS to 5 [04/23] xfs: add parent pointer support to attribute code [05/23] xfs: define parent pointer ondisk extended attribute format [06/23] xfs: add parent pointer validator functions [07/23] xfs: extend transaction reservations for parent attributes [08/23] xfs: parent pointer attribute creation [09/23] xfs: add parent attributes to link [10/23] xfs: add parent attributes to symlink [11/23] xfs: remove parent pointers in unlink [12/23] xfs: Indent xfs_rename [13/23] xfs: Add parent pointers to rename [14/23] xfs: Add parent pointers to xfs_cross_rename [15/23] xfs: Add helper function xfs_attr_list_context_init [16/23] xfs: Filter XFS_ATTR_PARENT for getfattr [17/23] xfs: pass the attr value to put_listent when possible [18/23] xfs: add a libxfs header file for staging new ioctls [19/23] xfs: Add parent pointer ioctl [20/23] xfs: fix unit conversion error in xfs_log_calc_max_attrsetm_res [21/23] xfs: drop compatibility minimum log size computations for reflink [22/23] xfs: don't remove the attr fork when parent pointers are enabled [23/23] xfs: Add the parent pointer support to the superblock version 5.

Commit Message

Darrick J. Wong April 6, 2023, 7:24 p.m. UTC

From: Allison Henderson <allison.henderson@oracle.com>

Parent pointers returned to the get_fattr tool cause errors since
the tool cannot parse parent pointers.  Fix this by filtering parent
parent pointers from xfs_xattr_put_listent.

Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
---
 fs/xfs/xfs_xattr.c |    3 +++
 1 file changed, 3 insertions(+)

diff mbox series

Patch

diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c
index ef5a635238e5..c0c27c0edb33 100644
--- a/fs/xfs/xfs_xattr.c
+++ b/fs/xfs/xfs_xattr.c
@@ -239,6 +239,9 @@  xfs_xattr_put_listent(
 
 	ASSERT(context->count >= 0);
 
+	if (flags & XFS_ATTR_PARENT)
+		return;
+
 	if (flags & XFS_ATTR_ROOT) {
 #ifdef CONFIG_XFS_POSIX_ACL
 		if (namelen == SGI_ACL_FILE_SIZE &&