[12/18] xfs: Filter XFS_ATTR_PARENT for getfattr

Message ID	168506072870.3744191.10179194999559499457.stgit@frogsfrogsfrogs (mailing list archive)
State	Superseded, archived
Headers	show Return-Path: <linux-xfs-owner@vger.kernel.org> Date: Thu, 25 May 2023 19:13:00 -0700 Subject: [PATCH 12/18] xfs: Filter XFS_ATTR_PARENT for getfattr From: "Darrick J. Wong" <djwong@kernel.org> To: djwong@kernel.org Cc: Allison Henderson <allison.henderson@oracle.com>, linux-xfs@vger.kernel.org, allison.henderson@oracle.com, catherine.hoang@oracle.com Message-ID: <168506072870.3744191.10179194999559499457.stgit@frogsfrogsfrogs> In-Reply-To: <168506072673.3744191.16402822066993932505.stgit@frogsfrogsfrogs> References: <168506072673.3744191.16402822066993932505.stgit@frogsfrogsfrogs> User-Agent: StGit/0.19 MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Precedence: bulk
Series	xfs: Parent Pointers \| expand [PATCHSET,v12.0,00/18] xfs: Parent Pointers [01/18] xfs: add parent pointer support to attribute code [02/18] xfs: define parent pointer ondisk extended attribute format [03/18] xfs: add parent pointer validator functions [04/18] xfs: extend transaction reservations for parent attributes [05/18] xfs: parent pointer attribute creation [06/18] xfs: add parent attributes to link [07/18] xfs: add parent attributes to symlink [08/18] xfs: remove parent pointers in unlink [09/18] xfs: Indent xfs_rename [10/18] xfs: Add parent pointers to rename [11/18] xfs: Add parent pointers to xfs_cross_rename [12/18] xfs: Filter XFS_ATTR_PARENT for getfattr [13/18] xfs: pass the attr value to put_listent when possible [14/18] xfs: Add parent pointer ioctl [15/18] xfs: fix unit conversion error in xfs_log_calc_max_attrsetm_res [16/18] xfs: drop compatibility minimum log size computations for reflink [17/18] xfs: don't remove the attr fork when parent pointers are enabled [18/18] xfs: Add the parent pointer support to the superblock version 5.

Message ID

168506072870.3744191.10179194999559499457.stgit@frogsfrogsfrogs (mailing list archive)

State

Superseded, archived

Headers

Date: Thu, 25 May 2023 19:13:00 -0700
Subject: [PATCH 12/18] xfs: Filter XFS_ATTR_PARENT for getfattr
From: "Darrick J. Wong" <djwong@kernel.org>
To: djwong@kernel.org
Cc: Allison Henderson <allison.henderson@oracle.com>,
        linux-xfs@vger.kernel.org, allison.henderson@oracle.com,
        catherine.hoang@oracle.com
Message-ID: <168506072870.3744191.10179194999559499457.stgit@frogsfrogsfrogs>
In-Reply-To: <168506072673.3744191.16402822066993932505.stgit@frogsfrogsfrogs>
References: <168506072673.3744191.16402822066993932505.stgit@frogsfrogsfrogs>
User-Agent: StGit/0.19
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
Precedence: bulk

Series

xfs: Parent Pointers | expand

Commit Message

Darrick J. Wong May 26, 2023, 2:13 a.m. UTC

From: Allison Henderson <allison.henderson@oracle.com>

Parent pointers returned to the get_fattr tool cause errors since
the tool cannot parse parent pointers.  Fix this by filtering parent
parent pointers from xfs_xattr_put_listent.

Signed-off-by: Allison Henderson <allison.henderson@oracle.com>
Reviewed-by: Darrick J. Wong <djwong@kernel.org>
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 fs/xfs/xfs_xattr.c |    3 +++
 1 file changed, 3 insertions(+)

diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c
index b4fa2663f8b6..7b8460091da8 100644
--- a/fs/xfs/xfs_xattr.c
+++ b/fs/xfs/xfs_xattr.c
@@ -237,6 +237,9 @@  xfs_xattr_put_listent(
 
 	ASSERT(context->count >= 0);
 
+	if (flags & XFS_ATTR_PARENT)
+		return;
+
 	if (flags & XFS_ATTR_ROOT) {
 #ifdef CONFIG_XFS_POSIX_ACL
 		if (namelen == SGI_ACL_FILE_SIZE &&

[12/18] xfs: Filter XFS_ATTR_PARENT for getfattr

Commit Message

Patch