| Message ID | 1685993543-27714-1-git-send-email-sandeen@redhat.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | mkfs.xfs: test that shipped config files work properly | expand |
On Mon, Jun 05, 2023 at 02:32:23PM -0500, Eric Sandeen wrote: > Sanity check the shipped mkfs.xfs config files by using > them to format the scratch device. > > Signed-off-by: Eric Sandeen <sandeen@redhat.com> > --- > tests/xfs/569 | 32 ++++++++++++++++++++++++++++++++ > tests/xfs/569.out | 2 ++ > 2 files changed, 34 insertions(+) > create mode 100755 tests/xfs/569 > create mode 100644 tests/xfs/569.out > > diff --git a/tests/xfs/569 b/tests/xfs/569 > new file mode 100755 > index 0000000..ebcaaab > --- /dev/null > +++ b/tests/xfs/569 > @@ -0,0 +1,32 @@ > +#! /bin/bash > +# SPDX-License-Identifier: GPL-2.0 > +# Copyright (c) 2023 Red Hat, Inc. All Rights Reserved. > +# > +# FS QA Test 569 > +# > +# Check for any installed example mkfs config files and validate that > +# mkfs.xfs can properly use them. > +# > +. ./common/preamble > +_begin_fstest mkfs > + > +# real QA test starts here > + > +# Modify as appropriate. > +_supported_fs xfs > +_require_scratch > + > +ls /usr/share/xfsprogs/mkfs/*.conf &>/dev/null || \ > + _notrun "No mkfs.xfs config files installed" > + > +# We only fail if mkfs.xfs fails outright, ignoring warnings etc > +echo "Silence is golden" > + > +for CONFIG in /usr/share/xfsprogs/mkfs/*.conf; do > + $MKFS_XFS_PROG -c options=$CONFIG -f $SCRATCH_DEV &>>$seqres.full || \ > + _fail "mkfs.xfs config file $CONFIG failed" Why not echo instead of _fail so we can see every config that failed, not just the first one? --D > +done > + > +# success, all done > +status=0 > +exit > diff --git a/tests/xfs/569.out b/tests/xfs/569.out > new file mode 100644 > index 0000000..c7aaf10 > --- /dev/null > +++ b/tests/xfs/569.out > @@ -0,0 +1,2 @@ > +QA output created by 569 > +Silence is golden > -- > 1.8.3.1 >
diff --git a/tests/xfs/569 b/tests/xfs/569 new file mode 100755 index 0000000..ebcaaab --- /dev/null +++ b/tests/xfs/569 @@ -0,0 +1,32 @@ +#! /bin/bash +# SPDX-License-Identifier: GPL-2.0 +# Copyright (c) 2023 Red Hat, Inc. All Rights Reserved. +# +# FS QA Test 569 +# +# Check for any installed example mkfs config files and validate that +# mkfs.xfs can properly use them. +# +. ./common/preamble +_begin_fstest mkfs + +# real QA test starts here + +# Modify as appropriate. +_supported_fs xfs +_require_scratch + +ls /usr/share/xfsprogs/mkfs/*.conf &>/dev/null || \ + _notrun "No mkfs.xfs config files installed" + +# We only fail if mkfs.xfs fails outright, ignoring warnings etc +echo "Silence is golden" + +for CONFIG in /usr/share/xfsprogs/mkfs/*.conf; do + $MKFS_XFS_PROG -c options=$CONFIG -f $SCRATCH_DEV &>>$seqres.full || \ + _fail "mkfs.xfs config file $CONFIG failed" +done + +# success, all done +status=0 +exit diff --git a/tests/xfs/569.out b/tests/xfs/569.out new file mode 100644 index 0000000..c7aaf10 --- /dev/null +++ b/tests/xfs/569.out @@ -0,0 +1,2 @@ +QA output created by 569 +Silence is golden
Sanity check the shipped mkfs.xfs config files by using them to format the scratch device. Signed-off-by: Eric Sandeen <sandeen@redhat.com> --- tests/xfs/569 | 32 ++++++++++++++++++++++++++++++++ tests/xfs/569.out | 2 ++ 2 files changed, 34 insertions(+) create mode 100755 tests/xfs/569 create mode 100644 tests/xfs/569.out