diff mbox series

[2/6] libfrog: don't fail on XFS_FSOP_GEOM_FLAGS_NREXT64 in xfrog_bulkstat_single5

Message ID 169454758720.3539425.12997334128444146623.stgit@frogsfrogsfrogs (mailing list archive)
State New, archived
Headers show
Series xfsprogs: minor fixes | expand

Commit Message

Darrick J. Wong Sept. 12, 2023, 7:39 p.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

This flag is perfectly acceptable for bulkstatting a single file;
there's no reason not to allow it.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 libfrog/bulkstat.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Carlos Maiolino Sept. 13, 2023, 12:50 p.m. UTC | #1 
On Tue, Sep 12, 2023 at 12:39:47PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> This flag is perfectly acceptable for bulkstatting a single file;
> there's no reason not to allow it.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>


> ---
>  libfrog/bulkstat.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/libfrog/bulkstat.c b/libfrog/bulkstat.c
> index 0a90947fb29..c863bcb6bf8 100644
> --- a/libfrog/bulkstat.c
> +++ b/libfrog/bulkstat.c
> @@ -53,7 +53,7 @@ xfrog_bulkstat_single5(
>  	struct xfs_bulkstat_req		*req;
>  	int				ret;
> 
> -	if (flags & ~(XFS_BULK_IREQ_SPECIAL))
> +	if (flags & ~(XFS_BULK_IREQ_SPECIAL | XFS_BULK_IREQ_NREXT64))
>  		return -EINVAL;
> 
>  	if (xfd->fsgeom.flags & XFS_FSOP_GEOM_FLAGS_NREXT64)
>
Carlos Maiolino Oct. 5, 2023, 12:34 p.m. UTC | #2 
On Tue, Sep 12, 2023 at 12:39:47PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
> 
> This flag is perfectly acceptable for bulkstatting a single file;
> there's no reason not to allow it.

Reviewed-by: Carlos Maiolino <cmaiolino@redhat.com>
Carlos

> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  libfrog/bulkstat.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> 
> diff --git a/libfrog/bulkstat.c b/libfrog/bulkstat.c
> index 0a90947fb29..c863bcb6bf8 100644
> --- a/libfrog/bulkstat.c
> +++ b/libfrog/bulkstat.c
> @@ -53,7 +53,7 @@ xfrog_bulkstat_single5(
>  	struct xfs_bulkstat_req		*req;
>  	int				ret;
> 
> -	if (flags & ~(XFS_BULK_IREQ_SPECIAL))
> +	if (flags & ~(XFS_BULK_IREQ_SPECIAL | XFS_BULK_IREQ_NREXT64))
>  		return -EINVAL;
> 
>  	if (xfd->fsgeom.flags & XFS_FSOP_GEOM_FLAGS_NREXT64)
>
diff mbox series

Patch

diff --git a/libfrog/bulkstat.c b/libfrog/bulkstat.c
index 0a90947fb29..c863bcb6bf8 100644
--- a/libfrog/bulkstat.c
+++ b/libfrog/bulkstat.c
@@ -53,7 +53,7 @@  xfrog_bulkstat_single5(
 	struct xfs_bulkstat_req		*req;
 	int				ret;
 
-	if (flags & ~(XFS_BULK_IREQ_SPECIAL))
+	if (flags & ~(XFS_BULK_IREQ_SPECIAL | XFS_BULK_IREQ_NREXT64))
 		return -EINVAL;
 
 	if (xfd->fsgeom.flags & XFS_FSOP_GEOM_FLAGS_NREXT64)