| Message ID | 169567817607.2269889.5897696336492740125.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | fstests: fix ro mounting with unknown rocompat features | expand |
On Mon, Sep 25, 2023 at 02:42:56PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > Update the commit id in the _fixed_by tag now that we've merged the > kernel fix. > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- > tests/xfs/270 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > > diff --git a/tests/xfs/270 b/tests/xfs/270 > index 7d4e1f6a87..4e4f767dc1 100755 > --- a/tests/xfs/270 > +++ b/tests/xfs/270 > @@ -17,7 +17,7 @@ _begin_fstest auto quick mount > > # real QA test starts here > _supported_fs xfs > -_fixed_by_kernel_commit xxxxxxxxxxxx \ > +_fixed_by_kernel_commit 74ad4693b647 \ > "xfs: fix log recovery when unknown rocompat bits are set" This patch is good to me, but we have more xfs cases have fixed commit which have been merged: $ grep -rsni xxxxxxxx tests/xfs|grep _fixed tests/xfs/600:23:_fixed_by_git_commit kernel XXXXXXXXXXXXX \ tests/xfs/557:21:_fixed_by_kernel_commit XXXXXXXXXXXX \ tests/xfs/270:20:_fixed_by_kernel_commit xxxxxxxxxxxx \ xfs/600: cfa2df68b7ce xfs: fix an agbno overflow in __xfs_getfsmap_datadev xfs/557: 817644fa4525 xfs: get root inode correctly at bulkstat Do you want to fix them in one patch, or you hope to merge this patch at first? Thanks, Zorro > # skip fs check because superblock contains unknown ro-compat features > _require_scratch_nocheck >
On Fri, Sep 29, 2023 at 01:22:59PM +0800, Zorro Lang wrote: > On Mon, Sep 25, 2023 at 02:42:56PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@kernel.org> > > > > Update the commit id in the _fixed_by tag now that we've merged the > > kernel fix. > > > > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > > --- > > tests/xfs/270 | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/tests/xfs/270 b/tests/xfs/270 > > index 7d4e1f6a87..4e4f767dc1 100755 > > --- a/tests/xfs/270 > > +++ b/tests/xfs/270 > > @@ -17,7 +17,7 @@ _begin_fstest auto quick mount > > > > # real QA test starts here > > _supported_fs xfs > > -_fixed_by_kernel_commit xxxxxxxxxxxx \ > > +_fixed_by_kernel_commit 74ad4693b647 \ > > "xfs: fix log recovery when unknown rocompat bits are set" > > This patch is good to me, but we have more xfs cases have fixed commit which > have been merged: > > $ grep -rsni xxxxxxxx tests/xfs|grep _fixed > tests/xfs/600:23:_fixed_by_git_commit kernel XXXXXXXXXXXXX \ > tests/xfs/557:21:_fixed_by_kernel_commit XXXXXXXXXXXX \ > tests/xfs/270:20:_fixed_by_kernel_commit xxxxxxxxxxxx \ > > xfs/600: cfa2df68b7ce xfs: fix an agbno overflow in __xfs_getfsmap_datadev > xfs/557: 817644fa4525 xfs: get root inode correctly at bulkstat > > Do you want to fix them in one patch, or you hope to merge this > patch at first? Eh, I'll just resubmit with all three. --D > Thanks, > Zorro > > > > # skip fs check because superblock contains unknown ro-compat features > > _require_scratch_nocheck > > >
diff --git a/tests/xfs/270 b/tests/xfs/270 index 7d4e1f6a87..4e4f767dc1 100755 --- a/tests/xfs/270 +++ b/tests/xfs/270 @@ -17,7 +17,7 @@ _begin_fstest auto quick mount # real QA test starts here _supported_fs xfs -_fixed_by_kernel_commit xxxxxxxxxxxx \ +_fixed_by_kernel_commit 74ad4693b647 \ "xfs: fix log recovery when unknown rocompat bits are set" # skip fs check because superblock contains unknown ro-compat features _require_scratch_nocheck