| Message ID | 170069443670.1865809.2265862857261044359.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | Superseded, archived |
| Headers | show |
| Series | xfsprogs: minor fixes for 6.6 | expand |
Looks good:
Reviewed-by: Christoph Hellwig <hch@lst.de>
On Wed, Nov 22, 2023 at 03:07:16 PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > Update the documentation to reflect that we can metadump external log > device contents. > Looks good to me. Reviewed-by: Chandan Babu R <chandanbabu@kernel.org> > Signed-off-by: Darrick J. Wong <djwong@kernel.org> > --- > man/man8/xfs_mdrestore.8 | 6 +++++- > man/man8/xfs_metadump.8 | 7 +++++-- > 2 files changed, 10 insertions(+), 3 deletions(-) > > > diff --git a/man/man8/xfs_mdrestore.8 b/man/man8/xfs_mdrestore.8 > index 6e7457c0445..f60e7b56ebf 100644 > --- a/man/man8/xfs_mdrestore.8 > +++ b/man/man8/xfs_mdrestore.8 > @@ -14,6 +14,10 @@ xfs_mdrestore \- restores an XFS metadump image to a filesystem image > .br > .B xfs_mdrestore > .B \-i > +[ > +.B \-l > +.I logdev > +] > .I source > .br > .B xfs_mdrestore \-V > @@ -52,7 +56,7 @@ Shows metadump information on stdout. If no > is specified, exits after displaying information. Older metadumps man not > include any descriptive information. > .TP > -.B \-l " logdev" > +.BI \-l " logdev" > Metadump in v2 format can contain metadata dumped from an external log. > In such a scenario, the user has to provide a device to which the log device > contents from the metadump file are copied. > diff --git a/man/man8/xfs_metadump.8 b/man/man8/xfs_metadump.8 > index 1732012cd0c..496b5926603 100644 > --- a/man/man8/xfs_metadump.8 > +++ b/man/man8/xfs_metadump.8 > @@ -132,8 +132,11 @@ is stdout. > .TP > .BI \-l " logdev" > For filesystems which use an external log, this specifies the device where the > -external log resides. The external log is not copied, only internal logs are > -copied. > +external log resides. > +If the v2 metadump format is selected, the contents of the external log will be > +copied to the metadump. > +The v2 metadump format will be selected automatically if this option is > +specified. > .TP > .B \-m > Set the maximum size of an allowed metadata extent. Extremely large metadata
diff --git a/man/man8/xfs_mdrestore.8 b/man/man8/xfs_mdrestore.8 index 6e7457c0445..f60e7b56ebf 100644 --- a/man/man8/xfs_mdrestore.8 +++ b/man/man8/xfs_mdrestore.8 @@ -14,6 +14,10 @@ xfs_mdrestore \- restores an XFS metadump image to a filesystem image .br .B xfs_mdrestore .B \-i +[ +.B \-l +.I logdev +] .I source .br .B xfs_mdrestore \-V @@ -52,7 +56,7 @@ Shows metadump information on stdout. If no is specified, exits after displaying information. Older metadumps man not include any descriptive information. .TP -.B \-l " logdev" +.BI \-l " logdev" Metadump in v2 format can contain metadata dumped from an external log. In such a scenario, the user has to provide a device to which the log device contents from the metadump file are copied. diff --git a/man/man8/xfs_metadump.8 b/man/man8/xfs_metadump.8 index 1732012cd0c..496b5926603 100644 --- a/man/man8/xfs_metadump.8 +++ b/man/man8/xfs_metadump.8 @@ -132,8 +132,11 @@ is stdout. .TP .BI \-l " logdev" For filesystems which use an external log, this specifies the device where the -external log resides. The external log is not copied, only internal logs are -copied. +external log resides. +If the v2 metadump format is selected, the contents of the external log will be +copied to the metadump. +The v2 metadump format will be selected automatically if this option is +specified. .TP .B \-m Set the maximum size of an allowed metadata extent. Extremely large metadata