diff mbox series

[7/9] xfs_mdrestore: emit newlines for fatal errors

Message ID 170069444804.1865809.10101273264911340367.stgit@frogsfrogsfrogs (mailing list archive)
State Superseded, archived
Headers show
Series xfsprogs: minor fixes for 6.6 | expand

Commit Message

Darrick J. Wong Nov. 22, 2023, 11:07 p.m. UTC
From: Darrick J. Wong <djwong@kernel.org>

Spit out a newline after a fatal error message.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 mdrestore/xfs_mdrestore.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Christoph Hellwig Nov. 23, 2023, 6:41 a.m. UTC | #1
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
Chandan Babu R Nov. 24, 2023, 9:12 a.m. UTC | #2
On Wed, Nov 22, 2023 at 03:07:28 PM -0800, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@kernel.org>
>
> Spit out a newline after a fatal error message.
>

Looks good to me.

Reviewed-by: Chandan Babu R <chandanbabu@kernel.org>

> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> ---
>  mdrestore/xfs_mdrestore.c |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
>
> diff --git a/mdrestore/xfs_mdrestore.c b/mdrestore/xfs_mdrestore.c
> index 5dfc423493e..3190e07e478 100644
> --- a/mdrestore/xfs_mdrestore.c
> +++ b/mdrestore/xfs_mdrestore.c
> @@ -275,10 +275,10 @@ read_header_v2(
>  		fatal("error reading from metadump file\n");
>  
>  	if (h->v2.xmh_incompat_flags != 0)
> -		fatal("Metadump header has unknown incompat flags set");
> +		fatal("Metadump header has unknown incompat flags set\n");
>  
>  	if (h->v2.xmh_reserved != 0)
> -		fatal("Metadump header's reserved field has a non-zero value");
> +		fatal("Metadump header's reserved field has a non-zero value\n");
>  
>  	want_external_log = !!(be32_to_cpu(h->v2.xmh_incompat_flags) &
>  			XFS_MD2_COMPAT_EXTERNALLOG);
diff mbox series

Patch

diff --git a/mdrestore/xfs_mdrestore.c b/mdrestore/xfs_mdrestore.c
index 5dfc423493e..3190e07e478 100644
--- a/mdrestore/xfs_mdrestore.c
+++ b/mdrestore/xfs_mdrestore.c
@@ -275,10 +275,10 @@  read_header_v2(
 		fatal("error reading from metadump file\n");
 
 	if (h->v2.xmh_incompat_flags != 0)
-		fatal("Metadump header has unknown incompat flags set");
+		fatal("Metadump header has unknown incompat flags set\n");
 
 	if (h->v2.xmh_reserved != 0)
-		fatal("Metadump header's reserved field has a non-zero value");
+		fatal("Metadump header's reserved field has a non-zero value\n");
 
 	want_external_log = !!(be32_to_cpu(h->v2.xmh_incompat_flags) &
 			XFS_MD2_COMPAT_EXTERNALLOG);