mbox series

[GIT,PULL,4/5] xfs: elide defer work ->create_done if no intent

Message ID 170191573238.1135812.13863112646073646742.stg-ugh@frogsfrogsfrogs (mailing list archive)
State Superseded
Headers show
Series [GIT,PULL,1/5] xfs: log intent item recovery should reconstruct defer work state | expand

Pull-request

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/defer-elide-create-done-6.8_2023-12-06

Message

Darrick J. Wong Dec. 7, 2023, 2:30 a.m. UTC
Hi Chandan,

Please pull this branch with changes for xfs for 6.8-rc1.

As usual, I did a test-merge with the main upstream branch as of a few
minutes ago, and didn't see any conflicts.  Please let me know if you
encounter any problems.

--D

The following changes since commit 4d6bd042de601ce29732060101df64725c925836:

xfs: don't allow overly small or large realtime volumes (2023-12-06 18:17:25 -0800)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/defer-elide-create-done-6.8_2023-12-06

for you to fetch changes up to d10115e529bba3a2b2b8194419a13d7dcff970dc:

xfs: elide ->create_done calls for unlogged deferred work (2023-12-06 18:17:25 -0800)

----------------------------------------------------------------
xfs: elide defer work ->create_done if no intent [v2]

Christoph pointed out that the defer ops machinery doesn't need to call
->create_done if the deferred work item didn't generate a log intent
item in the first place.  Let's clean that up and save an indirect call
in the non-logged xattr update call path.

v2: pick up rvb tags

This has been lightly tested with fstests.  Enjoy!

Signed-off-by: Darrick J. Wong <djwong@kernel.org>

----------------------------------------------------------------
Darrick J. Wong (2):
xfs: document what LARP means
xfs: elide ->create_done calls for unlogged deferred work

fs/xfs/libxfs/xfs_defer.c | 4 ++++
fs/xfs/xfs_attr_item.c    | 3 ---
fs/xfs/xfs_sysfs.c        | 9 +++++++++
3 files changed, 13 insertions(+), 3 deletions(-)

Comments

Darrick J. Wong Dec. 7, 2023, 2:33 a.m. UTC | #1
Heh.  I got the sick, so it might be a while before y'all hear from me
again.  Also, there is no "GIT PULL 5/5" I can't do math. :(

--D