mbox series

[GIT,PULL,5/6] xfs_scrub_all: fixes for systemd services

Message ID 170502573560.996574.2504743062956504522.stg-ugh@frogsfrogsfrogs (mailing list archive)
State New
Headers show
Series [GIT,PULL,1/6] xfsprogs: various bug fixes for 6.6 | expand

Pull-request

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git tags/scruball-service-fixes-6.6_2024-01-11

Message

Darrick J. Wong Jan. 12, 2024, 2:17 a.m. UTC
Hi Carlos,

Please pull this branch with changes for xfsprogs for 6.6-rc1.

As usual, I did a test-merge with the main upstream branch as of a few
minutes ago, and didn't see any conflicts.  Please let me know if you
encounter any problems.

The following changes since commit 3d37d8bf535fd6a8ab241a86433b449152746e6a:

xfs_scrub_all.cron: move to package data directory (2024-01-11 18:08:47 -0800)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git tags/scruball-service-fixes-6.6_2024-01-11

for you to fetch changes up to 1c95c17c8857223d05e8c4516af42c6d41ae579a:

xfs_scrub_all: fix termination signal handling (2024-01-11 18:08:47 -0800)

----------------------------------------------------------------
xfs_scrub_all: fixes for systemd services [v28.3 5/6]

This patchset ties up some problems in the xfs_scrub_all program and
service, which are essential for finding mounted filesystems to scrub
and creating the background service instances that do the scrub.

First, we need to fix various errors in pathname escaping, because
systemd does /not/ like slashes in service names.  Then, teach
xfs_scrub_all to deal with systemd restarts causing it to think that a
scrub has finished before the service actually finishes.  Finally,
implement a signal handler so that SIGINT (console ^C) and SIGTERM
(systemd stopping the service) shut down the xfs_scrub@ services
correctly.

Signed-off-by: Darrick J. Wong <djwong@kernel.org>

----------------------------------------------------------------
Darrick J. Wong (4):
xfs_scrub_all: fix argument passing when invoking xfs_scrub manually
xfs_scrub_all: survive systemd restarts when waiting for services
xfs_scrub_all: simplify cleanup of run_killable
xfs_scrub_all: fix termination signal handling

scrub/xfs_scrub_all.in | 157 +++++++++++++++++++++++++++++++++++++++----------
1 file changed, 125 insertions(+), 32 deletions(-)

Comments

Carlos Maiolino Jan. 23, 2024, 10:31 a.m. UTC | #1
On Thu, Jan 11, 2024 at 06:17:28PM -0800, Darrick J. Wong wrote:
> Hi Carlos,
> 
> Please pull this branch with changes for xfsprogs for 6.6-rc1.
> 
> As usual, I did a test-merge with the main upstream branch as of a few
> minutes ago, and didn't see any conflicts.  Please let me know if you
> encounter any problems.
> 
> The following changes since commit 3d37d8bf535fd6a8ab241a86433b449152746e6a:
> 
> xfs_scrub_all.cron: move to package data directory (2024-01-11 18:08:47 -0800)
> 
> are available in the Git repository at:
> 
> https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git tags/scruball-service-fixes-6.6_2024-01-11
> 
> for you to fetch changes up to 1c95c17c8857223d05e8c4516af42c6d41ae579a:
> 
> xfs_scrub_all: fix termination signal handling (2024-01-11 18:08:47 -0800)

Pulled, thanks!

Carlos

> 
> ----------------------------------------------------------------
> xfs_scrub_all: fixes for systemd services [v28.3 5/6]
> 
> This patchset ties up some problems in the xfs_scrub_all program and
> service, which are essential for finding mounted filesystems to scrub
> and creating the background service instances that do the scrub.
> 
> First, we need to fix various errors in pathname escaping, because
> systemd does /not/ like slashes in service names.  Then, teach
> xfs_scrub_all to deal with systemd restarts causing it to think that a
> scrub has finished before the service actually finishes.  Finally,
> implement a signal handler so that SIGINT (console ^C) and SIGTERM
> (systemd stopping the service) shut down the xfs_scrub@ services
> correctly.
> 
> Signed-off-by: Darrick J. Wong <djwong@kernel.org>
> 
> ----------------------------------------------------------------
> Darrick J. Wong (4):
> xfs_scrub_all: fix argument passing when invoking xfs_scrub manually
> xfs_scrub_all: survive systemd restarts when waiting for services
> xfs_scrub_all: simplify cleanup of run_killable
> xfs_scrub_all: fix termination signal handling
> 
> scrub/xfs_scrub_all.in | 157 +++++++++++++++++++++++++++++++++++++++----------
> 1 file changed, 125 insertions(+), 32 deletions(-)
>