[GIT,PULL,10/16] xfs: move orphan files to lost and found

Message ID	171322718011.141687.9955601436581822988.stg-ugh@frogsfrogsfrogs (mailing list archive)
State	New
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 808C2652 for <linux-xfs@vger.kernel.org>; Tue, 16 Apr 2024 00:30:00 +0000 (UTC) Date: Mon, 15 Apr 2024 17:29:59 -0700 Subject: [GIT PULL 10/16] xfs: move orphan files to lost and found From: "Darrick J. Wong" <djwong@kernel.org> To: chandanbabu@kernel.org, djwong@kernel.org Cc: hch@lst.de, linux-xfs@vger.kernel.org Message-ID: <171322718011.141687.9955601436581822988.stg-ugh@frogsfrogsfrogs> Precedence: bulk MIME-Version: 1.0 In-Reply-To: <20240416002427.GB11972@frogsfrogsfrogs> References: <20240416002427.GB11972@frogsfrogsfrogs> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit
Series	[GIT,PULL,01/16] xfs: improve log incompat feature handling \| expand [GIT,PULL,01/16] xfs: improve log incompat feature handling [GIT,PULL,02/16] xfs: refactorings for atomic file content exchanges [GIT,PULL,03/16] xfs: atomic file content exchanges [GIT,PULL,04/16] xfs: create temporary files for online repair [GIT,PULL,05/16] xfs: online repair of realtime summaries [GIT,PULL,06/16] xfs: set and validate dir/attr block owners [GIT,PULL,07/16] xfs: online repair of extended attributes [GIT,PULL,08/16] xfs: online repair of inode unlinked state [GIT,PULL,09/16] xfs: online repair of directories [GIT,PULL,10/16] xfs: move orphan files to lost and found [GIT,PULL,11/16] xfs: online repair of symbolic links [GIT,PULL,12/16] xfs: online fsck of iunlink buckets [GIT,PULL,13/16] xfs: inode-related repair fixes [GIT,PULL,14/16] xfs: less heavy locks during fstrim [GIT,PULL,15/16] xfs: design documentation for online fsck, part 2 [GIT,PULL,16/16] xfs: retain ILOCK during directory updates

Message ID

171322718011.141687.9955601436581822988.stg-ugh@frogsfrogsfrogs (mailing list archive)

State

New

Headers

Date: Mon, 15 Apr 2024 17:29:59 -0700
Subject: [GIT PULL 10/16] xfs: move orphan files to lost and found
From: "Darrick J. Wong" <djwong@kernel.org>
To: chandanbabu@kernel.org, djwong@kernel.org
Cc: hch@lst.de, linux-xfs@vger.kernel.org
Message-ID: <171322718011.141687.9955601436581822988.stg-ugh@frogsfrogsfrogs>
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240416002427.GB11972@frogsfrogsfrogs>
References: <20240416002427.GB11972@frogsfrogsfrogs>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Series

[GIT,PULL,01/16] xfs: improve log incompat feature handling | expand

Message

Darrick J. Wong April 16, 2024, 12:29 a.m. UTC

Hi Chandan,

Please pull this branch with changes for xfs for 6.10-rc1.

As usual, I did a test-merge with the main upstream branch as of a few
minutes ago, and didn't see any conflicts.  Please let me know if you
encounter any problems.

--D

The following changes since commit 34c9382c128270d0f4c8b36783b30f3c8085b2dd:

xfs: ask the dentry cache if it knows the parent of a directory (2024-04-15 14:58:56 -0700)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/repair-orphanage-6.10_2024-04-15

for you to fetch changes up to 73597e3e42b4a15030e6f93b71b53a04377ea419:

xfs: ensure dentry consistency when the orphanage adopts a file (2024-04-15 14:58:57 -0700)

----------------------------------------------------------------
xfs: move orphan files to lost and found [v30.3 10/16]

Orphaned files are defined to be files with nonzero ondisk link count
but no observable parent directory.  This series enables online repair
to reparent orphaned files into the filesystem directory tree, and wires
up this reparenting ability into the directory, file link count, and
parent pointer repair functions.  This is how we fix files with positive
link count that are not reachable through the directory tree.

This patch will also create the orphanage directory (lost+found) if it
is not present.  In contrast to xfs_repair, we follow e2fsck in creating
the lost+found without group or other-owner access to avoid accidental
disclosure of files that were previously hidden by an 0700 directory.
That's silly security, but people have been known to do it.

This has been running on the djcloud for months with no problems.  Enjoy!

Signed-off-by: Darrick J. Wong <djwong@kernel.org>

----------------------------------------------------------------
Darrick J. Wong (3):
xfs: move orphan files to the orphanage
xfs: move files to orphanage instead of letting nlinks drop to zero
xfs: ensure dentry consistency when the orphanage adopts a file

.../filesystems/xfs/xfs-online-fsck-design.rst     |  20 +-
fs/xfs/Makefile                                    |   1 +
fs/xfs/scrub/dir_repair.c                          | 130 ++++-
fs/xfs/scrub/nlinks.c                              |  20 +-
fs/xfs/scrub/nlinks.h                              |   7 +
fs/xfs/scrub/nlinks_repair.c                       | 123 ++++-
fs/xfs/scrub/orphanage.c                           | 589 +++++++++++++++++++++
fs/xfs/scrub/orphanage.h                           |  75 +++
fs/xfs/scrub/parent_repair.c                       | 100 +++-
fs/xfs/scrub/repair.h                              |   2 +
fs/xfs/scrub/scrub.c                               |   2 +
fs/xfs/scrub/scrub.h                               |   4 +
fs/xfs/scrub/trace.c                               |   1 +
fs/xfs/scrub/trace.h                               |  96 ++++
fs/xfs/xfs_inode.c                                 |   6 +-
fs/xfs/xfs_inode.h                                 |   1 +
16 files changed, 1139 insertions(+), 38 deletions(-)
create mode 100644 fs/xfs/scrub/orphanage.c
create mode 100644 fs/xfs/scrub/orphanage.h

[GIT,PULL,10/16] xfs: move orphan files to lost and found

Pull-request

Message