mbox series

[GIT,PULL,2/9] xfs: improve extended attribute validation

Message ID 171392950368.1941278.17612824185696231303.stg-ugh@frogsfrogsfrogs (mailing list archive)
State Accepted, archived
Headers show
Series [GIT,PULL,1/9] xfs: shrink struct xfs_da_args | expand

Pull-request

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/improve-attr-validation-6.10_2024-04-23

Message

Darrick J. Wong April 24, 2024, 3:34 a.m. UTC
Hi Chandan,

Please pull this branch with changes for xfs for 6.10-rc1.

As usual, I did a test-merge with the main upstream branch as of a few
minutes ago, and didn't see any conflicts.  Please let me know if you
encounter any problems.

--D

The following changes since commit cda60317ac57add7a0a2865aa29afbc6caad3e9a:

xfs: rearrange xfs_da_args a bit to use less space (2024-04-23 07:46:51 -0700)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfs-linux.git tags/improve-attr-validation-6.10_2024-04-23

for you to fetch changes up to ea0b3e814741fb64e7785b564ea619578058e0b0:

xfs: enforce one namespace per attribute (2024-04-23 07:46:54 -0700)

----------------------------------------------------------------
xfs: improve extended attribute validation [v13.4 2/9]

Prior to introducing parent pointer extended attributes, let's spend
some time cleaning up the attr code and strengthening the validation
that it performs on attrs coming in from the disk.

This has been running on the djcloud for months with no problems.  Enjoy!

Signed-off-by: Darrick J. Wong <djwong@kernel.org>

----------------------------------------------------------------
Darrick J. Wong (14):
xfs: attr fork iext must be loaded before calling xfs_attr_is_leaf
xfs: require XFS_SB_FEAT_INCOMPAT_LOG_XATTRS for attr log intent item recovery
xfs: use an XFS_OPSTATE_ flag for detecting if logged xattrs are available
xfs: check opcode and iovec count match in xlog_recover_attri_commit_pass2
xfs: fix missing check for invalid attr flags
xfs: check shortform attr entry flags specifically
xfs: restructure xfs_attr_complete_op a bit
xfs: use helpers to extract xattr op from opflags
xfs: validate recovered name buffers when recovering xattr items
xfs: always set args->value in xfs_attri_item_recover
xfs: use local variables for name and value length in _attri_commit_pass2
xfs: refactor name/length checks in xfs_attri_validate
xfs: refactor name/value iovec validation in xlog_recover_attri_commit_pass2
xfs: enforce one namespace per attribute

fs/xfs/libxfs/xfs_attr.c      |  37 ++++++-
fs/xfs/libxfs/xfs_attr.h      |   9 +-
fs/xfs/libxfs/xfs_attr_leaf.c |   7 +-
fs/xfs/libxfs/xfs_da_format.h |   5 +
fs/xfs/scrub/attr.c           |  34 ++++--
fs/xfs/scrub/attr_repair.c    |   4 +-
fs/xfs/xfs_attr_item.c        | 242 +++++++++++++++++++++++++++++++++---------
fs/xfs/xfs_attr_list.c        |  18 +++-
fs/xfs/xfs_mount.c            |  16 +++
fs/xfs/xfs_mount.h            |   6 +-
fs/xfs/xfs_xattr.c            |   3 +-
11 files changed, 304 insertions(+), 77 deletions(-)