diff mbox series

[1/2] xfs/348: partially revert dbcc549317 ("xfs/348: golden output is not correct")

Message ID 171867147055.794588.9928537254200607808.stgit@frogsfrogsfrogs (mailing list archive)
State Superseded, archived
Headers show
Series [1/2] xfs/348: partially revert dbcc549317 ("xfs/348: golden output is not correct") | expand

Commit Message

Darrick J. Wong June 18, 2024, 12:53 a.m. UTC 
From: Dave Chinner <dchinner@redhat.com>

In kernel commit 1eb70f54c445f ("xfs: validate inode fork size against
fork format"), we incorrectly started flagging as corrupt symlinks with
short targets that would fit in the inode core but are remote.  The
kernel has historically written out symlinks this way and read them back
in, so we're fixing that.

The 1eb70 change came with change dbcc to fstests to adjust the golden
output; since we're adjusting the kernel back to old behavior, we need
to adjust the test too.

Fixes: dbcc549317 ("xfs/348: golden output is not correct")
Signed-off-by: Darrick J. Wong <djwong@kernel.org>
---
 tests/xfs/348.out |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig June 18, 2024, 6:26 a.m. UTC | #1 
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/xfs/348.out b/tests/xfs/348.out
index 9130f42af7..591b1a77a6 100644
--- a/tests/xfs/348.out
+++ b/tests/xfs/348.out
@@ -240,7 +240,7 @@  would have junked entry "DIR" in directory PARENT_INO
 would have junked entry "EMPTY" in directory PARENT_INO
 would have junked entry "FIFO" in directory PARENT_INO
 stat: cannot statx 'SCRATCH_MNT/test/DIR': Structure needs cleaning
-stat: cannot statx 'SCRATCH_MNT/test/DATA': Structure needs cleaning
+stat: 'SCRATCH_MNT/test/DATA' is a symbolic link
 stat: cannot statx 'SCRATCH_MNT/test/EMPTY': Structure needs cleaning
 stat: 'SCRATCH_MNT/test/SYMLINK' is a symbolic link
 stat: cannot statx 'SCRATCH_MNT/test/CHRDEV': Structure needs cleaning