| Message ID | 171988120259.2008941.14570974653938645833.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [1/3] xfs_scrub: automatic downgrades to dry-run mode in service mode | expand |
On Mon, Jul 01, 2024 at 06:09:54PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > Now that we're finished building online fsck, enable the periodic > background scrub service by default. This involves the postinst script > starting the resource management slice and the timer. > > No other sub-services need to be enabled or unmasked explicitly. They > also shouldn't be started or restarted because that might interrupt > background operation unnecessarily. I'm still not sure we quite want to run this by default on all debian systems. Are you ready to handle all the bug reports from people complaining about the I/O load?
On Tue, Jul 02, 2024 at 07:44:19AM +0200, Christoph Hellwig wrote: > On Mon, Jul 01, 2024 at 06:09:54PM -0700, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@kernel.org> > > > > Now that we're finished building online fsck, enable the periodic > > background scrub service by default. This involves the postinst script > > starting the resource management slice and the timer. > > > > No other sub-services need to be enabled or unmasked explicitly. They > > also shouldn't be started or restarted because that might interrupt > > background operation unnecessarily. > > I'm still not sure we quite want to run this by default on all > debian systems. Are you ready to handle all the bug reports from > people complaining about the I/O load? CONFIG_XFS_ONLINE_SCRUB isn't turned on for the 6.9.7 kernel in sid, so there shouldn't be any complaints until we ask the kernel team to enable it. I don't think we should ask Debian to do that until after they lift the debian 13 freeze next year/summer/whenever. --D
On Tue, Jul 02, 2024 at 07:59:29PM -0700, Darrick J. Wong wrote: > CONFIG_XFS_ONLINE_SCRUB isn't turned on for the 6.9.7 kernel in sid, so > there shouldn't be any complaints until we ask the kernel team to enable > it. I don't think we should ask Debian to do that until after they lift > the debian 13 freeze next year/summer/whenever. I'm not entirely sure if we should ever do this by default. The right fit to me would be on of those questions asked during apt-get upgrade to enable/disable things. But don't ask me how those are implemented or even called.
On Wed, Jul 03, 2024 at 06:31:24AM +0200, Christoph Hellwig wrote: > On Tue, Jul 02, 2024 at 07:59:29PM -0700, Darrick J. Wong wrote: > > CONFIG_XFS_ONLINE_SCRUB isn't turned on for the 6.9.7 kernel in sid, so > > there shouldn't be any complaints until we ask the kernel team to enable > > it. I don't think we should ask Debian to do that until after they lift > > the debian 13 freeze next year/summer/whenever. > > I'm not entirely sure if we should ever do this by default. The right > fit to me would be on of those questions asked during apt-get upgrade > to enable/disable things. But don't ask me how those are implemented > or even called. Some debconf magicks that I don't understand. :( A more declarative-happy way would be to make a subpackage that turns on the background service, so the people that want it on by default can add "Depends: xfsprogs-background-scrub" to their ... uh ... ansible? puppet? orchestration system. --D
diff --git a/debian/rules b/debian/rules index 69a79fc67405..c3fbcd26232e 100755 --- a/debian/rules +++ b/debian/rules @@ -114,7 +114,7 @@ binary-arch: checkroot built dh_compress dh_fixperms dh_makeshlibs - dh_installsystemd -p xfsprogs --no-enable --no-start --no-restart-after-upgrade --no-stop-on-upgrade + dh_installsystemd -p xfsprogs --no-restart-after-upgrade --no-stop-on-upgrade system-xfs_scrub.slice xfs_scrub_all.timer dh_installdeb dh_shlibdeps dh_gencontrol