[GIT,PULL,07/23] xfs_scrub: improve warnings about difficult repairs

Message ID	172230458454.1455085.8671992039573793867.stg-ugh@frogsfrogsfrogs (mailing list archive)
State	Accepted, archived
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9390B84D34 for <linux-xfs@vger.kernel.org>; Tue, 30 Jul 2024 02:42:08 +0000 (UTC) Date: Mon, 29 Jul 2024 19:42:07 -0700 Subject: [GIT PULL 07/23] xfs_scrub: improve warnings about difficult repairs From: "Darrick J. Wong" <djwong@kernel.org> To: cem@kernel.org, djwong@kernel.org Cc: hch@lst.de, linux-xfs@vger.kernel.org Message-ID: <172230458454.1455085.8671992039573793867.stg-ugh@frogsfrogsfrogs> Precedence: bulk MIME-Version: 1.0 In-Reply-To: <20240730013626.GF6352@frogsfrogsfrogs> References: <20240730013626.GF6352@frogsfrogsfrogs> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit
Series	[GIT,PULL,01/23] libxfs: fixes for 6.9 \| expand [GIT,PULL,01/23] libxfs: fixes for 6.9 [GIT,PULL,02/23] libxfs: sync with 6.10 [GIT,PULL,03/23] xfsprogs: atomic file updates [GIT,PULL,04/23] xfsprogs: set and validate dir/attr block owners [GIT,PULL,05/23] xfsprogs: inode-related repair fixes [GIT,PULL,06/23] xfs_scrub: fixes to the repair code [GIT,PULL,07/23] xfs_scrub: improve warnings about difficult repairs [GIT,PULL,08/23] xfs_scrub: track data dependencies for repairs [GIT,PULL,09/23] xfs_scrub: use scrub_item to track check progress [GIT,PULL,10/23] xfs_scrub: improve scheduling of repair items [GIT,PULL,11/23] xfs_scrub: detect deceptive filename extensions [GIT,PULL,12/23] xfs_scrub: move fstrim to a separate phase [GIT,PULL,13/23] xfs_scrub: use free space histograms to reduce fstrim runtime [GIT,PULL,14/23] xfs_scrub: tighten security of systemd services [GIT,PULL,15/23] xfs_scrub_all: automatic media scan service [GIT,PULL,16/23] xfs_scrub_all: improve systemd handling [GIT,PULL,17/23] xfsprogs: improve extended attribute validation [GIT,PULL,18/23] xfsprogs: Parent Pointers [GIT,PULL,19/23] xfsprogs: scrubbing for parent pointers [GIT,PULL,20/23] xfsprogs: offline repair for parent pointers [GIT,PULL,21/23] xfsprogs: detect and correct directory tree problems [GIT,PULL,22/23] xfs_scrub: vectorize kernel calls [GIT,PULL,23/23] xfs_repair: fixes for kernel 6.10

Message ID

172230458454.1455085.8671992039573793867.stg-ugh@frogsfrogsfrogs (mailing list archive)

State

Accepted, archived

Headers

Date: Mon, 29 Jul 2024 19:42:07 -0700
Subject: [GIT PULL 07/23] xfs_scrub: improve warnings about difficult repairs
From: "Darrick J. Wong" <djwong@kernel.org>
To: cem@kernel.org, djwong@kernel.org
Cc: hch@lst.de, linux-xfs@vger.kernel.org
Message-ID: <172230458454.1455085.8671992039573793867.stg-ugh@frogsfrogsfrogs>
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240730013626.GF6352@frogsfrogsfrogs>
References: <20240730013626.GF6352@frogsfrogsfrogs>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Series

[GIT,PULL,01/23] libxfs: fixes for 6.9 | expand

Message

Darrick J. Wong July 30, 2024, 2:42 a.m. UTC

Hi Carlos,

Please pull this branch with changes for xfsprogs for 6.10-rc1.

As usual, I did a test-merge with the main upstream branch as of a few
minutes ago, and didn't see any conflicts.  Please let me know if you
encounter any problems.

The following changes since commit 4b959abc5f353123775973cd98c94d819cc9de79:

xfs_scrub: actually try to fix summary counters ahead of repairs (2024-07-29 17:01:06 -0700)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git tags/scrub-better-repair-warnings-6.10_2024-07-29

for you to fetch changes up to bf15d7766e3dd63eda56f6b2f7976e529cd07575:

xfs_scrub: enable users to bump information messages to warnings (2024-07-29 17:01:07 -0700)

----------------------------------------------------------------
xfs_scrub: improve warnings about difficult repairs [v30.9 07/28]

While I was poking through the QA results for xfs_scrub, I noticed that
it doesn't warn the user when the primary and secondary realtime
metadata are so out of whack that the chances of a successful repair are
not so high.  I decided that it was worth refactoring the scrub code a
bit so that we could warn the user about these types of things, and
ended up refactoring unnecessary helpers out of existence and fixing
other reporting gaps.

This has been running on the djcloud for months with no problems.  Enjoy!

Signed-off-by: Darrick J. Wong <djwong@kernel.org>

----------------------------------------------------------------
Darrick J. Wong (8):
xfs_scrub: fix missing scrub coverage for broken inodes
xfs_scrub: collapse trivial superblock scrub helpers
xfs_scrub: get rid of trivial fs metadata scanner helpers
xfs_scrub: split up the mustfix repairs and difficulty assessment functions
xfs_scrub: add missing repair types to the mustfix and difficulty assessment
xfs_scrub: any inconsistency in metadata should trigger difficulty warnings
xfs_scrub: warn about difficult repairs to rt and quota metadata
xfs_scrub: enable users to bump information messages to warnings

man/man8/xfs_scrub.8 | 19 +++++++++++++++++++
scrub/common.c       |  2 ++
scrub/phase1.c       |  2 +-
scrub/phase2.c       | 53 ++++++++++++++++++++++++++++++++--------------------
scrub/phase3.c       | 21 +++++++++++++++++----
scrub/phase4.c       |  9 +++++----
scrub/phase5.c       | 15 +++++++--------
scrub/repair.c       | 47 +++++++++++++++++++++++++++++++++++-----------
scrub/repair.h       | 10 +++++++---
scrub/scrub.c        | 52 +--------------------------------------------------
scrub/scrub.h        |  7 ++-----
scrub/xfs_scrub.c    | 45 +++++++++++++++++++++++++++++++++++++++++++-
scrub/xfs_scrub.h    |  1 +
13 files changed, 175 insertions(+), 108 deletions(-)

[GIT,PULL,07/23] xfs_scrub: improve warnings about difficult repairs

Pull-request

Message