[GIT,PULL,17/23] xfsprogs: improve extended attribute validation

Message ID	172230459508.1455085.4400398103646272942.stg-ugh@frogsfrogsfrogs (mailing list archive)
State	Accepted, archived
Headers	show Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3B84E20326 for <linux-xfs@vger.kernel.org>; Tue, 30 Jul 2024 02:44:44 +0000 (UTC) Date: Mon, 29 Jul 2024 19:44:44 -0700 Subject: [GIT PULL 17/23] xfsprogs: improve extended attribute validation From: "Darrick J. Wong" <djwong@kernel.org> To: cem@kernel.org, djwong@kernel.org Cc: chandan.babu@oracle.com, david@fromorbit.com, hch@lst.de, linux-xfs@vger.kernel.org Message-ID: <172230459508.1455085.4400398103646272942.stg-ugh@frogsfrogsfrogs> Precedence: bulk MIME-Version: 1.0 In-Reply-To: <20240730013626.GF6352@frogsfrogsfrogs> References: <20240730013626.GF6352@frogsfrogsfrogs> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit
Series	[GIT,PULL,01/23] libxfs: fixes for 6.9 \| expand [GIT,PULL,01/23] libxfs: fixes for 6.9 [GIT,PULL,02/23] libxfs: sync with 6.10 [GIT,PULL,03/23] xfsprogs: atomic file updates [GIT,PULL,04/23] xfsprogs: set and validate dir/attr block owners [GIT,PULL,05/23] xfsprogs: inode-related repair fixes [GIT,PULL,06/23] xfs_scrub: fixes to the repair code [GIT,PULL,07/23] xfs_scrub: improve warnings about difficult repairs [GIT,PULL,08/23] xfs_scrub: track data dependencies for repairs [GIT,PULL,09/23] xfs_scrub: use scrub_item to track check progress [GIT,PULL,10/23] xfs_scrub: improve scheduling of repair items [GIT,PULL,11/23] xfs_scrub: detect deceptive filename extensions [GIT,PULL,12/23] xfs_scrub: move fstrim to a separate phase [GIT,PULL,13/23] xfs_scrub: use free space histograms to reduce fstrim runtime [GIT,PULL,14/23] xfs_scrub: tighten security of systemd services [GIT,PULL,15/23] xfs_scrub_all: automatic media scan service [GIT,PULL,16/23] xfs_scrub_all: improve systemd handling [GIT,PULL,17/23] xfsprogs: improve extended attribute validation [GIT,PULL,18/23] xfsprogs: Parent Pointers [GIT,PULL,19/23] xfsprogs: scrubbing for parent pointers [GIT,PULL,20/23] xfsprogs: offline repair for parent pointers [GIT,PULL,21/23] xfsprogs: detect and correct directory tree problems [GIT,PULL,22/23] xfs_scrub: vectorize kernel calls [GIT,PULL,23/23] xfs_repair: fixes for kernel 6.10

Message ID

172230459508.1455085.4400398103646272942.stg-ugh@frogsfrogsfrogs (mailing list archive)

State

Accepted, archived

Headers

Date: Mon, 29 Jul 2024 19:44:44 -0700
Subject: [GIT PULL 17/23] xfsprogs: improve extended attribute validation
From: "Darrick J. Wong" <djwong@kernel.org>
To: cem@kernel.org, djwong@kernel.org
Cc: chandan.babu@oracle.com, david@fromorbit.com, hch@lst.de,
 linux-xfs@vger.kernel.org
Message-ID: <172230459508.1455085.4400398103646272942.stg-ugh@frogsfrogsfrogs>
Precedence: bulk
MIME-Version: 1.0
In-Reply-To: <20240730013626.GF6352@frogsfrogsfrogs>
References: <20240730013626.GF6352@frogsfrogsfrogs>
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

Series

[GIT,PULL,01/23] libxfs: fixes for 6.9 | expand

Message

Darrick J. Wong July 30, 2024, 2:44 a.m. UTC

Hi Carlos,

Please pull this branch with changes for xfsprogs for 6.10-rc1.

As usual, I did a test-merge with the main upstream branch as of a few
minutes ago, and didn't see any conflicts.  Please let me know if you
encounter any problems.

The following changes since commit e46249ec0b96ac5ced5b49928d3b3865b6d9546c:

xfs_scrub_all: implement retry and backoff for dbus calls (2024-07-29 17:01:10 -0700)

are available in the Git repository at:

https://git.kernel.org/pub/scm/linux/kernel/git/djwong/xfsprogs-dev.git tags/improve-attr-validation-6.10_2024-07-29

for you to fetch changes up to 2823d8ed93da2bd3880abb52a58e91a920961e27:

xfs_repair: check for unknown flags in attr entries (2024-07-29 17:01:11 -0700)

----------------------------------------------------------------
xfsprogs: improve extended attribute validation [v13.8 17/28]

Prior to introducing parent pointer extended attributes, let's spend
some time cleaning up the attr code and strengthening the validation
that it performs on attrs coming in from the disk.

This has been running on the djcloud for months with no problems.  Enjoy!

Signed-off-by: Darrick J. Wong <djwong@kernel.org>

----------------------------------------------------------------
Darrick J. Wong (6):
xfs_scrub_all: fail fast on masked units
xfs_scrub: automatic downgrades to dry-run mode in service mode
xfs_scrub: add an optimization-only mode
xfs_repair: check free space requirements before allowing upgrades
xfs_repair: enforce one namespace bit per extended attribute
xfs_repair: check for unknown flags in attr entries

include/libxfs.h         |   1 +
libxfs/libxfs_api_defs.h |   1 +
man/man8/xfs_scrub.8     |   6 ++-
repair/attr_repair.c     |  30 +++++++++++
repair/phase2.c          | 134 +++++++++++++++++++++++++++++++++++++++++++++++
scrub/Makefile           |   2 +-
scrub/phase1.c           |  13 +++++
scrub/phase4.c           |   6 +++
scrub/repair.c           |  37 ++++++++++++-
scrub/repair.h           |   2 +
scrub/scrub.c            |   4 +-
scrub/xfs_scrub.c        |  21 +++++++-
scrub/xfs_scrub.h        |   1 +
scrub/xfs_scrub_all.in   |  21 ++++++++
14 files changed, 272 insertions(+), 7 deletions(-)

[GIT,PULL,17/23] xfsprogs: improve extended attribute validation

Pull-request

Message