| Message ID | 173706974091.1927324.4002591248645301199.stgit@frogsfrogsfrogs (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [01/23] generic/476: fix fsstress process management | expand |
On Thu, Jan 16, 2025 at 03:25:26PM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@kernel.org> > > generic/476 never used to run fsstress in the background, but > 8973af00ec212f made it do that. This is incorrect, because now 476 runs > for three seconds (i.e. long enough to fall out the bottom of the test > and end up in _cleanup), ignoring any SOAK_DURATION/TIME_FACTOR > settings. > > Cc: <fstests@vger.kernel.org> # v2024.12.08 > Fixes: 8973af00ec212f ("fstests: cleanup fsstress process management") > Signed-off-by: "Darrick J. Wong" <djwong@kernel.org> > --- > tests/generic/476 | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Looks fine. Reviewed-by: Dave Chinner <dchinner@redhat.com>
diff --git a/tests/generic/476 b/tests/generic/476 index 769b3745f75689..4537fcd77d2f07 100755 --- a/tests/generic/476 +++ b/tests/generic/476 @@ -22,7 +22,7 @@ nr_ops=$((25000 * nr_cpus * TIME_FACTOR)) fsstress_args=(-w -d $SCRATCH_MNT -n $nr_ops -p $nr_cpus) test -n "$SOAK_DURATION" && fsstress_args+=(--duration="$SOAK_DURATION") -_run_fsstress_bg "${fsstress_args[@]}" +_run_fsstress "${fsstress_args[@]}" # success, all done status=0