diff mbox series

[08/13] xfs/291: use _scratch_mkfs_sized instead of opencoding the logic

Message ID 173992591258.4080556.3753644406313565446.stgit@frogsfrogsfrogs (mailing list archive)
State New
Headers show
Series [01/13] xfs: fix tests that try to access the realtime rmap inode | expand

Commit Message

Darrick J. Wong Feb. 19, 2025, 1:05 a.m. UTC 
From: Darrick J. Wong <djwong@kernel.org>

Now that _scratch_mkfs_xfs_sized accepts arbitrary mkfs arguments, this
test doesn't need to open-code the helper just to add the dir block and
log size arguments.  Clean this up, which will also help us to avoid
problems with rtrmap if the rt devices is large enough to cause format
failures with the 133M data device size.

Signed-off-by: "Darrick J. Wong" <djwong@kernel.org>
---
 tests/xfs/291 |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Christoph Hellwig Feb. 19, 2025, 7:28 a.m. UTC | #1 
Looks good:

Reviewed-by: Christoph Hellwig <hch@lst.de>
diff mbox series

Patch

diff --git a/tests/xfs/291 b/tests/xfs/291
index 777968a9240df6..1a8cda4efb3357 100755
--- a/tests/xfs/291
+++ b/tests/xfs/291
@@ -26,7 +26,7 @@  _xfs_setup_verify_metadump
 
 _require_scratch
 logblks=$(_scratch_find_xfs_min_logblocks -n size=16k -d size=133m)
-_scratch_mkfs_xfs -n size=16k -l size=${logblks}b -d size=133m >> $seqres.full 2>&1
+_scratch_mkfs_sized $((133 * 1048576)) '' -n size=16k -l size=${logblks}b >> $seqres.full 2>&1
 _scratch_mount
 
 # First we cause very badly fragmented freespace, then