From patchwork Fri Dec 16 12:46:28 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michal Hocko X-Patchwork-Id: 9486849 X-Mozilla-Keys: nonjunk Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on sandeen.net X-Spam-Level: X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_HI, RCVD_IN_SORBS_SPAM, RP_MATCHES_RCVD autolearn=ham autolearn_force=no version=3.4.0 X-Spam-HP: BAYES_00=-1.9,RCVD_IN_DNSWL_HI=-5,RCVD_IN_SORBS_SPAM=0.5, RP_MATCHES_RCVD=-0.1 X-Original-To: sandeen@sandeen.net Delivered-To: sandeen@sandeen.net Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by sandeen.net (Postfix) with ESMTP id 461FF8D for ; Fri, 16 Dec 2016 06:47:22 -0600 (CST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935081AbcLPMrN (ORCPT ); Fri, 16 Dec 2016 07:47:13 -0500 Received: from mail-wm0-f68.google.com ([74.125.82.68]:33357 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1760097AbcLPMqp (ORCPT ); Fri, 16 Dec 2016 07:46:45 -0500 Received: by mail-wm0-f68.google.com with SMTP id u144so5264605wmu.0; Fri, 16 Dec 2016 04:46:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=4GVSJOaqwOo17luBUd8gee5+8w/6Z4SdQ6jAS8892r8=; b=rfxycXE8aSZ8Hp+FRiDnWz/D2PnMB13Vsdm3cEzXy2vlQavWZ01Rw26froUvjIpzHg PYdK8wg13DCRVWV7svv068mlzcdgLYBUe1MAsm6YbhrNf9mw1uG9O6pXLGLbzN7ixR1V pxxVodX4CZqYz9sqYWFUs4Np18ELeC0qRbVc6fOgZ2I/p2YJxG2afV6V7WY992Po93Tm Kx8mv1S/ETwxVbDfl4Z93WJx2a+GYWQvrAvfhFo3tS7LdVXV0REMaKzp0B7D6rz6x2wV pYFiMsyg/GIIm210Kdsi1d6LwS2DlVO8GOosH1dB4tcbIxI/WEctAsG6BVjOE1+GG5ta bpcg== X-Gm-Message-State: AIkVDXLgqTwhGv3FkFx8E9n0GY0lFqMD0Pxs9JNOREOg/6xB9t6zLnQNQya+z0YI1R8W2Q== X-Received: by 10.28.191.87 with SMTP id p84mr2663203wmf.63.1481892402682; Fri, 16 Dec 2016 04:46:42 -0800 (PST) Received: from tiehlicka.suse.cz ([213.151.95.130]) by smtp.gmail.com with ESMTPSA id e5sm3204480wma.12.2016.12.16.04.46.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 16 Dec 2016 04:46:42 -0800 (PST) From: Michal Hocko To: , Cc: Andrew Morton , Dave Chinner , "Theodore Ts'o" , Chris Mason , David Sterba , Jan Kara , ceph-devel@vger.kernel.org, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, logfs@logfs.org, linux-xfs@vger.kernel.org, linux-ext4@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mtd@lists.infradead.org, reiserfs-devel@vger.kernel.org, linux-ntfs-dev@lists.sourceforge.net, linux-f2fs-devel@lists.sourceforge.net, linux-afs@lists.infradead.org, LKML , Michal Hocko Subject: [DEBUG PATCH 2/2] silent warnings which we cannot do anything about Date: Fri, 16 Dec 2016 13:46:28 +0100 Message-Id: <20161216124628.26846-3-mhocko@kernel.org> X-Mailer: git-send-email 2.10.2 In-Reply-To: <20161216124628.26846-1-mhocko@kernel.org> References: <20161215140715.12732-1-mhocko@kernel.org> <20161216124628.26846-1-mhocko@kernel.org> Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org From: Michal Hocko THIS PATCH IS FOR TESTING ONLY AND NOT MEANT TO HIT LINUS TREE There are some code paths used by all the filesystems which we cannot change to drop the GFP_NOFS, yet they generate a lot of warnings. Provide {disable,enable}_scope_gfp_check to silence those. alloc_page_buffers and grow_dev_page are silenced right away. Signed-off-by: Michal Hocko --- fs/buffer.c | 4 ++++ include/linux/sched.h | 11 +++++++++++ mm/page_alloc.c | 3 +++ 3 files changed, 18 insertions(+) diff --git a/fs/buffer.c b/fs/buffer.c index d21771fcf7d3..d27e8f05f736 100644 --- a/fs/buffer.c +++ b/fs/buffer.c @@ -873,7 +873,9 @@ struct buffer_head *alloc_page_buffers(struct page *page, unsigned long size, head = NULL; offset = PAGE_SIZE; while ((offset -= size) >= 0) { + disable_scope_gfp_check(); bh = alloc_buffer_head(GFP_NOFS); + enable_scope_gfp_check(); if (!bh) goto no_grow; @@ -1003,7 +1005,9 @@ grow_dev_page(struct block_device *bdev, sector_t block, */ gfp_mask |= __GFP_NOFAIL; + disable_scope_gfp_check(); page = find_or_create_page(inode->i_mapping, index, gfp_mask); + enable_scope_gfp_check(); if (!page) return ret; diff --git a/include/linux/sched.h b/include/linux/sched.h index 288946bfc326..b379ef9ed464 100644 --- a/include/linux/sched.h +++ b/include/linux/sched.h @@ -1988,6 +1988,7 @@ struct task_struct { /* A live task holds one reference. */ atomic_t stack_refcount; #endif + bool disable_scope_gfp_warn; unsigned long nofs_caller; unsigned long noio_caller; /* CPU-specific state of this task */ @@ -2390,6 +2391,16 @@ static inline unsigned int __memalloc_nofs_save(unsigned long caller) return flags; } +static inline void disable_scope_gfp_check(void) +{ + current->disable_scope_gfp_warn = true; +} + +static inline void enable_scope_gfp_check(void) +{ + current->disable_scope_gfp_warn = false; +} + #define memalloc_nofs_save() __memalloc_nofs_save(_RET_IP_) static inline void memalloc_nofs_restore(unsigned int flags) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 9e35fb2a8681..7ecae58abf74 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -3758,6 +3758,9 @@ void debug_scope_gfp_context(gfp_t gfp_mask) if (!(gfp_mask & __GFP_DIRECT_RECLAIM)) return; + if (current->disable_scope_gfp_warn) + return; + if (current->flags & PF_MEMALLOC_NOIO) restrict_mask = __GFP_IO; else if ((current->flags & PF_MEMALLOC_NOFS) && (gfp_mask & __GFP_IO))