Message ID | 20170331041452.e7lvxwq3hla3kims@Haydn (mailing list archive) |
---|---|
State | Accepted, archived |
Headers | show
Return-Path: <linux-xfs-owner@kernel.org> Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D2900602BD for <patchwork-linux-xfs@patchwork.kernel.org>; Fri, 31 Mar 2017 04:15:26 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B346F285D5 for <patchwork-linux-xfs@patchwork.kernel.org>; Fri, 31 Mar 2017 04:15:26 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A4DD828683; Fri, 31 Mar 2017 04:15:26 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0EE7C285D5 for <patchwork-linux-xfs@patchwork.kernel.org>; Fri, 31 Mar 2017 04:15:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750777AbdCaEP0 (ORCPT <rfc822;patchwork-linux-xfs@patchwork.kernel.org>); Fri, 31 Mar 2017 00:15:26 -0400 Received: from mx0b-00082601.pphosted.com ([67.231.153.30]:36434 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750748AbdCaEPY (ORCPT <rfc822; linux-xfs@vger.kernel.org>); Fri, 31 Mar 2017 00:15:24 -0400 Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.16.0.20/8.16.0.20) with SMTP id v2V46w7m023499; Thu, 30 Mar 2017 21:15:22 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=date : from : to : cc : subject : message-id : references : mime-version : content-type : in-reply-to; s=facebook; bh=3qNYQMqYX4MBeYPg5L6oegbWnKEK4JhAJkPmiiqsd8k=; b=euS5/PS3tHp6zOXVFIWEaNBKLf650YwLyqOMUmt68rDrBnjFv1zq0BriqmA6uLdnIirO 7uNpm03wehNStsaf0+foJ7X1tn+PgOOp9MuoSGj03wxh+/d7V7Ksyrrk2h1e9CHHunO/ 9Gs7YOlMxFzvUzm6l+m0Pi9Qca3LT3sW8TI= Received: from mail.thefacebook.com ([199.201.64.23]) by m0001303.ppops.net with ESMTP id 29hepdg53x-1 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT); Thu, 30 Mar 2017 21:15:22 -0700 Received: from NAM03-CO1-obe.outbound.protection.outlook.com (192.168.54.28) by o365-in.thefacebook.com (192.168.16.15) with Microsoft SMTP Server (TLS) id 14.3.319.2; Thu, 30 Mar 2017 21:15:20 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.onmicrosoft.com; s=selector1-fb-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=3qNYQMqYX4MBeYPg5L6oegbWnKEK4JhAJkPmiiqsd8k=; b=U3B8D9BxirPEt77zcTTVOHm/jdCTbTPLo41m45JA2wGX0eAP9DBelHtTc7L2Wtv4n5n3nG00OqSojSAekwhWAXgG7aR3M4EbFcKkzEstgHH0MtN4FjW/oVi1VuRim9QAsCJS6vXP9A2DPMSt7iRG4ed7Y1ihVCAk+y+WUKu/6Dw= Authentication-Results: fromorbit.com; dkim=none (message not signed) header.d=none; fromorbit.com; dmarc=none action=none header.from=fb.com; Received: from Haydn (2620:10d:c090:200::c:a991) by DM5PR15MB1228.namprd15.prod.outlook.com (10.173.209.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.991.14; Fri, 31 Mar 2017 04:15:01 +0000 Date: Thu, 30 Mar 2017 21:14:52 -0700 From: Calvin Owens <calvinowens@fb.com> To: Dave Chinner <david@fromorbit.com> CC: <linux-xfs@vger.kernel.org>, <kernel-team@fb.com> Subject: Re: [PATCH][PROGS] xfs_io: Allow setting multiple mode flags for fallocate() Message-ID: <20170331041452.e7lvxwq3hla3kims@Haydn> References: <c2fdfcbb1f4ac9a71633dfbe192ed1145b12b8ac.1489799604.git.calvinowens@fb.com> <20170318065554.GX17542@dastard> <8dc5334b-a7b9-d455-25b5-5d651a3b918d@fb.com> <20170321215458.GC17542@dastard> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Disposition: inline In-Reply-To: <20170321215458.GC17542@dastard> User-Agent: NeoMutt/20170306 (1.8.0) X-Originating-IP: [2620:10d:c090:200::c:a991] X-ClientProxiedBy: MWHPR14CA0039.namprd14.prod.outlook.com (10.171.142.153) To DM5PR15MB1228.namprd15.prod.outlook.com (10.173.209.22) X-MS-Office365-Filtering-Correlation-Id: affd08ff-2192-4a02-c3c8-08d477ec808d X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(22001)(201703131423075)(201703031133081); SRVR:DM5PR15MB1228; X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1228; 3:W2HwnGlolJGHRavLgrUWuC71cHcDC7G827Ph/S1oZBFgng2VXpw0Oh7J3hwHDRFnmwqBSzenPfLRYWs6CWglVURvHNtUc9WcThfYfxnRQ9JB2cEB3cOmKR4lNmlVOfnwoNZfeJUIMrh5fB5U6IPTuDqLO66OPaDLPvo6y6vuEJMwTOVecx+BbCvEPOiIA2wvh+ECs1RnpinnFzinktFk1qwT3TStMXjheXwDVn2ufwOnuOrG4IJNsDdi6LKKidZjS5Yf1WsebxCkqEFrjKVifR7ZBwrJ7PRiXc268FbnOO/E1F16HRa5UXEwYNhHttp+hq7NO1b6YTAKhwyNqU9iXw==; 25:UxlZ/cosmKZcNfTHWeZ6cE0R4x3lke6beo6PUiErBGnnf7TH5He4ZyeNVs0coX1srew/36yfDZYcuQsTyFo9VBboZ458P5rUh6lZV8WUzzkZrpbJ+zrj3AbB6HZJHO6c5wen5sa1VSvYULa8OyWwX4LBlv0Pwx3Rqh+55q2FTooStRpk+cCxb/2Nqy6L6INtcMdpCju1ydn/+JCv4myY+Nkadi/r8ic/Jk4bTEetzaF8oJ2LtNmV/TWCbM+5k+O/nBNojNUc67NRNzpaJkvy2luWzQpBB7mk1FhEbdnXkLQOM4SLDbixZmJaBynX4HCjTOuFQxDGf029ci/J3pPj+DfQsWTtsh2K45Buq+3flwy3SzjCvo2Aes4IMiibhqMixrTrVT3Irr7IbcYaHapn21NR9O3TND0qFrdff3/Ko7zojhS8RaCT+VrHBqsMC6rYCU78jeetFVI5Rr8GU4fPaA== X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1228; 31:nAY6BjOwiFBFA3t876d2/6Gr39FMJs5xjyJ2ddswqePRO5XZEZcoN2DzUGWp1lA2dJsWi2ekSg1Nz/XSrRzlwheCpNLTFbI/sxW6wKJQ2/1M3irGDZ8nbOiIQb0tBnZSTGGzydkI/4b1O0zjfbvn81uMQcBgmmh8OkiNBUG0TXYecSH8D6+EZLBt0fCgN7b7Ehmvbhs1/YZctobHc5QC5Vi3mCKFAwlIVhuy1d6ZKEs=; 20:OUBgEDIKH1QvB32t/f38JK90MSlbbmnf3i1JUBIyIL0GnKeDz7S7MRLYmQIAchEcRHnwyMBT7/mGsbbf40gja45CxVIPX4vlw1UfuUo/zqwP2dyu/d5WB3maE3nj5m5Kml0Q8/mcv2t5lQyuRrNlgRfQi7nMXoPToIIRZ83fmDv0bdcq2sj/GnnK5dVK//uK0jwJEb9pqc06l4BuYRF8n+pv5vEYo/S318rRT42wsvWmZFoXpi4wPIu+CrvDW3I5I2aZUWdruey1osEL7YZQsN+Oxi2RjlZCRoQz0JjBeuY1m67YzR86AVWl0hSuO+x4UJh4Po44EcV5b7upucO1Py1g7HTHYA3x4CFLLXQk1rH3eKJlJ15sHgPmpJdrUAetJRjcRcyV350moAmeFp2PWxGNI3UenhhkJK7rvvD4iCodBDHXjntnih3deBFQtDLjSNF/dEC136MtdyEqCUOR/EeDBRQ+7klVOdqmc0nuKuK3CQNlgXQwV8m9g/vsFj7a X-Microsoft-Antispam-PRVS: <DM5PR15MB1228410E24A5306D975CA286CE370@DM5PR15MB1228.namprd15.prod.outlook.com> X-Exchange-Antispam-Report-Test: UriScan:(67672495146484); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040450)(601004)(2401047)(8121501046)(5005006)(10201501046)(3002001)(93006087)(93001087)(6041248)(20161123564025)(20161123562025)(20161123555025)(201703131423075)(201702281528075)(201703061421075)(20161123560025)(6072148); SRVR:DM5PR15MB1228; BCL:0; PCL:0; RULEID:; SRVR:DM5PR15MB1228; X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1228; 4:gDzuxM7gJUZ1Cfzc7iturmo9ckubPvkWUME816uGAiBDeCx7sbKAK4xoO+tSguZMoQPqjRnKrGNF3lYcuiiMCiRThYzMbVJc5oM4uIUqfhqJY9LYx0JApP7bnyZibhpi4wtMCBJqXbkY4sMhB/OOLoFdSrpN6NL/+7ohrcLKoSrY6r12cLJ/iLJ83Cs1AgslUedQamD13yL+Np0XjsxrsgOHZWgTZ4v/RP6HUUJbM34Vzn72iMQy0KOXCc9Sh4lnPT4KDItWkUogYGOGBktACcCnPpoAwJJNFhds9WIU0EnDGcCW74X7tyc+3Wvgbac2bPlCDwumzp7oX52bSJCcIWX3biBecJJyPsilAmh/J84ii0pCIZua1F3yMG90tdH1HFoJ+Kwg4hy/YnQOZfk7nL78BQvbnSqDP2ApS/xsw/p+Kj1DKgkVkhdPcPc5cpO/RjWLxRIUQjczf+ILjFdXV9DnpeRWV17cvR9FlxA93U+rjTiD0CA0iSC76j4JUUnrDlOEM0EKpyaXb9xVfSyKkReolWOCk77xDXl7VmQkf5HNaNRajo40coXnYqusvpvXGp0dlv4gcsoqmytY6cETKgCo7H+oYncK4nKBw6OluEpRYuJbFdtpzjLnLqecf3GGCC87/v2FyNGBs/ovISev4dcweBMMoO/zEry+E6luTU4F9Hw+dhIswwUwkojYKK9TXXa15iP1V1Pk/CqPiFRuK1LYwqN3mKQqjIAqgckn/rKnxFo3R7W7xREp/gehG5uTYHQ52S4omckKR/Mh3OAq7Q== X-Forefront-PRVS: 02638D901B X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10019020)(4630300001)(6009001)(39450400003)(39840400002)(39410400002)(39400400002)(377454003)(24454002)(305945005)(53936002)(189998001)(93886004)(7736002)(6916009)(6666003)(83506001)(6116002)(9686003)(229853002)(33716001)(55016002)(6496005)(47776003)(4001350100001)(54906002)(2950100002)(2906002)(50466002)(76176999)(86362001)(54356999)(23676002)(33646002)(42186005)(110136004)(38730400002)(81166006)(4326008)(53546009)(50986999)(1076002)(6246003)(8676002)(5660300001)(25786009); DIR:OUT; SFP:1102; SCL:1; SRVR:DM5PR15MB1228; H:Haydn; FPR:; SPF:None; MLV:sfv; LANG:en; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjE1TUIxMjI4OzIzOmhXQkhtRW1ka3lUengxZTBwbURaNmppTW5M?= =?utf-8?B?dlBOUFAwSTFHNTZDdEVGc3NHQnpHdDhaajkycUkyaE9IdU9xV0FNUk9TU1F3?= =?utf-8?B?cHkwaTVMUjJSRzYrcnl4cDNFV2FZTnBIek5SWXAwUlFJZW14RFk5ZDBuVTBW?= =?utf-8?B?SDVCTEd1VE8vSDA3ZFE2TjlMSWFkcDUzY0tmQWpxNHcrY0FKb1RrcEhxMlhZ?= =?utf-8?B?SENYVjZ6K2ZJNVZKRHZ3OXkwZ0pnYkZRdzQwczkrZEhwQTNnVDBCdUhYdTU4?= =?utf-8?B?Z1dzS0txSElTSkx2cDJaeFNpSFoyRmxaUFdhRnA0NG81SVBKMkdKWmJMTEs3?= =?utf-8?B?RkFnTTlkelN5QTZkb0NqcmUzUXRLSk5DNzE0N1lvcWNCYzhWSFJSZ1I3U2ln?= =?utf-8?B?dEhvL0doMVVyRW5zZi9mNW96Tm1mbTg2R252cUNacmw0VWlob0k3MmNCMlAw?= =?utf-8?B?NXFqeVBEanBrdEJQSDJRbW1keGF0TjFJK1Z2clRpUUVvRUJhQUNiU3Bpd09C?= =?utf-8?B?S0c2eTNqeEwvaHdsRkhkN21pbEkyWmxleHdRaUdzcWhnbGFoc3puQUJwZi9y?= =?utf-8?B?cDFRVGRLOGxXU2JwSDc1Q1RrcUlpTFBLci91SmNvU3YzazdWUnNrbnF4SllO?= =?utf-8?B?dzRxbzhCM0F2Y2NNWUE4TjYxQ0pCaEtuVEZRMlBCSG4zT0JLZCs0OEZzRzZv?= =?utf-8?B?bUt0UmltYjZJdHpKcGlNVCtIVnhveFRGQzJxQWVJbEd0TFJZUHNwZzUybDRm?= =?utf-8?B?cy9xQlFxWS9YVnhyNWtZYkNlbmtJalBoeEpWUzR1eFltMHlad2taV2s0RXZ1?= =?utf-8?B?QnJKanA0ZmNXaW9rRk0yOFdQbnpJWTdRSklDLzZZVkVkMnp2YUhXNlBkanBI?= =?utf-8?B?UEtCY0Z6cmVYcHJoSm5VZytHZUQ5RkZEbUxpMytvdmhEOGFHWE5zUWpMVVJX?= =?utf-8?B?Z2JFZDhGOXJoRVZrbThlR1h4QTA4em5YMVp2UnNjUHdFWUlUenlBSGdOemlZ?= =?utf-8?B?ZkRHQUM5NHF0M1dTcTZJRWlZODBWaGtnQk1BNGVvR0JQajVTQmIrcXMySTBa?= =?utf-8?B?UmtWbkVOMVN6S0hLWklmb01tSm5qNU5xaFNLU1pIVi9TWVRiWXhvdXViQ2kv?= =?utf-8?B?NjI5L2ZPeXM3eU1ON01hcmpzUmVzajMrK1ZPL2FPcjdraklIQTRhMVJhRENr?= =?utf-8?B?ZElwMkdGdStoeU1TbXM1MUtadW51a21CRjZEQXBHZGVQWjRBQjZzQk5UVllJ?= =?utf-8?B?bVFSdUVsUG4xQzlOS3owQktOTzJ3NmFDSE91L3l5UXlZV3ltb1d6S0VaUlYx?= =?utf-8?B?OEI5QmFkcnJLVHI4NUZWa056ekZzTmk3VWcwc2FQcWo0MDliNmR3Tk1IOU0r?= =?utf-8?B?eVphYUsxeHFiQ29uSUluMVNKOHNqWU5wT3crLzhDVm9HWCt2bEpRVzNPdWVh?= =?utf-8?B?bUxKeThQeGF6RXgwMk1TaXoxKytMQklXMUh4UWpqRmRsZWVNeVQ4VEE3R3dK?= =?utf-8?Q?MZJU21p+LzUFm+j5xUYGALb7I=3D?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1228; 6:I3VslnPPAmjJwVGjr5W/RnE3ZPxdccmN2pt/vqyniJHWfsfxk3l8ItTEpUHAuR/luztqzzKPJEmwdD7a9XG52aohUvbpBuikTm0GW5HPqQUXBlMiwTF79TPFEDUQIcFwKFDdwOKRixkTQU1thns1FiMIquuCtrv7b/4FhYWyIVbux2UsysVAhE2jzApvuk1cAl0v6Q1+uxetD0MAbrpBqwXiK1sqyL3PMqkzUoEKH/eCVHDGrdMgu3xON04TYCnV8ZINHPcAFDGmk7EtXQxCwnRKyFR2YItvTtu51L7REeAUK2xaZmMRH4W7FTinj9dnIAMHlqztpcF7+zN98otvlMjjj1BfYLdUTxnQQLDVk5dCP2wDHprxGJ8djqWk1a77sTM7FGGsjHwEJDpjTxl78w==; 5:BAh0ql2Y4kQaNxvUAWv0TlkBo3LAHqV16qnHwcUnMOZ91ZxfzEGdePZcZhyNFZ6dwkikhkZ/hA5PXeJPtTxoq3y4wqF9bsZU94vQmmD4mdyKXK8NuKB44PASgu+zMap8wjOq3xjNicQmQQbv0GP2Lw==; 24:0YnfZ1VrwejtiC7rNaZYMCN5d7Mr/Ay00oGggN7UjUEcdlc6zT9eA6x8l6U0ujX7IYjMJvyvtJGRcdHK4XWaSk6OY6xw5E9/29eDPeTZ8Ek= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR15MB1228; 7:FozBjZebrCtF8OgNtdbcCBfsVemho0W9FJMF8C9em1bZRLwfg2oQ32IqEAMEFB0S4JNfeEWw/g1TOv7LbSoGEpWBdFL0+fisT0jXdQU1GIsrDQ31qVhrCc9AL8BBTjv387gzZUgzlGJRxkKEGi20aCktMoZVlI9z6E1dGC6ga09DPefIPFZH4voswbvnLIOA5hYtr56O+tXFw/s17KJlO524vGU0DPH+GmCOuPNMB/RVumTnkkqQnLTTNK6ns6pz+P4k2k4LloWw98Go2BIi3+AGz3Oi1dd+uUf+qq96SUtLOYfSpt1zOhajFHu7r8LXBVgfU/G3b+r5EHfslmugeg==; 20:PD+lCs+zn5yHcO+KUMSXkD5iurUSHndtVECCVSIWEo915kRYNQpC7k4ZTdxJnvLkxe1jO25pgI+qIGgiRSqZh91CuyL84eljVD/FvzSZfYmPh0y0+HTWPdLi1uN6cp54V4ybx3ipA03GV27IOlggWB/y/ZwlCbokeTUkbKGIrXw= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 31 Mar 2017 04:15:01.5030 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR15MB1228 X-OriginatorOrg: fb.com X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-03-31_03:, , signatures=0 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: <linux-xfs.vger.kernel.org> X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP |
On 3/30/17 11:14 PM, Calvin Owens wrote: > ---8<--- > From: Calvin Owens <calvinowens@fb.com> > Date: Thu, 30 Mar 2017 20:50:55 -0700 > Subject: [PATCH] io/prealloc: Fix "falloc -p" to pass KEEP_SIZE > > Otherwise, the syscall just returns -EOPPNOTSUPP. > > Signed-off-by: Calvin Owens <calvinowens@fb.com> Reviewed-by: Eric Sandeen <sandeen@redhat.com> > --- > io/prealloc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/io/prealloc.c b/io/prealloc.c > index a9d66cc..1a1c9ca 100644 > --- a/io/prealloc.c > +++ b/io/prealloc.c > @@ -210,7 +210,7 @@ fallocate_f( > mode = FALLOC_FL_KEEP_SIZE; > break; > case 'p': > - mode = FALLOC_FL_PUNCH_HOLE; > + mode = FALLOC_FL_PUNCH_HOLE|FALLOC_FL_KEEP_SIZE; > break; > case 'u': > mode = FALLOC_FL_UNSHARE_RANGE; > -- 2.9.3 -- To unsubscribe from this list: send the line "unsubscribe linux-xfs" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
diff --git a/io/prealloc.c b/io/prealloc.c index a9d66cc..1a1c9ca 100644 --- a/io/prealloc.c +++ b/io/prealloc.c @@ -210,7 +210,7 @@ fallocate_f( mode = FALLOC_FL_KEEP_SIZE; break; case 'p': - mode = FALLOC_FL_PUNCH_HOLE; + mode = FALLOC_FL_PUNCH_HOLE|FALLOC_FL_KEEP_SIZE; break; case 'u': mode = FALLOC_FL_UNSHARE_RANGE;