From patchwork Thu Apr 6 14:55:43 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jan Tulak X-Patchwork-Id: 9667621 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id CD3F1602B8 for ; Thu, 6 Apr 2017 14:55:40 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9115D28375 for ; Thu, 6 Apr 2017 14:55:40 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8598828535; Thu, 6 Apr 2017 14:55:40 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3195C28375 for ; Thu, 6 Apr 2017 14:55:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935259AbdDFOzj (ORCPT ); Thu, 6 Apr 2017 10:55:39 -0400 Received: from mx1.redhat.com ([209.132.183.28]:48277 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934551AbdDFOzj (ORCPT ); Thu, 6 Apr 2017 10:55:39 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9C3F36AACE for ; Thu, 6 Apr 2017 14:55:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 9C3F36AACE Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx02.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jtulak@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 9C3F36AACE Received: from jtulak-arch.brq.redhat.com (jtulak.brq.redhat.com [10.34.26.85]) by smtp.corp.redhat.com (Postfix) with ESMTP id D3ABC89335; Thu, 6 Apr 2017 14:55:37 +0000 (UTC) From: Jan Tulak To: linux-xfs@vger.kernel.org Cc: Jan Tulak Subject: [PATCH] mkfs: Add a note for people changing input options Date: Thu, 6 Apr 2017 16:55:43 +0200 Message-Id: <20170406145543.21781-1-jtulak@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.26]); Thu, 06 Apr 2017 14:55:38 +0000 (UTC) Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP A simple reminder to update test xfs/191-input-validation if input behaviour is changed (e.g. new option added). Signed-off-by: Jan Tulak --- mkfs/xfs_mkfs.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c index 5aac4d1b..7a5c49fc 100644 --- a/mkfs/xfs_mkfs.c +++ b/mkfs/xfs_mkfs.c @@ -50,6 +50,14 @@ unsigned int sectorsize; /* * Table for parsing mkfs parameters. * + * !!! NOTE ================================================================== + * + * If you are adding a new option, or changing an existing one, + * please, update also xfstests - test xfs/191-input-validation + * with expected behaviour (simple fail/pass). + * + * !!! END OF NOTE =========================================================== + * * Description of the structure members follows: * * name MANDATORY @@ -110,6 +118,14 @@ unsigned int sectorsize; * sets what is used with simple specifying the subopt (-d file). * A special SUBOPT_NEEDS_VAL can be used to require a user-given * value in any case. + * + * !!! NOTE ================================================================== + * + * If you are adding a new option, or changing an existing one, + * please, update also xfstests - test xfs/191-input-validation + * with expected behaviour (simple fail/pass). + * + * !!! END OF NOTE =========================================================== */ struct opt_params { const char name;