From patchwork Thu Apr 13 08:05:11 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 9678907 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id C097060381 for ; Thu, 13 Apr 2017 08:05:45 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B3C882861A for ; Thu, 13 Apr 2017 08:05:45 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A8CA328642; Thu, 13 Apr 2017 08:05:45 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C805F28631 for ; Thu, 13 Apr 2017 08:05:44 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751488AbdDMIFn (ORCPT ); Thu, 13 Apr 2017 04:05:43 -0400 Received: from bombadil.infradead.org ([65.50.211.133]:50451 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751450AbdDMIFj (ORCPT ); Thu, 13 Apr 2017 04:05:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:To:From:Sender:Reply-To:Cc:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=uB0J0iBYvGKcZboF/t7P+eFe8bDm4qh5RruUtFsbxhw=; b=cOjSc/Q2smb+r3RKdVRo2zbR2 2GUvPDIh4PPo9u1gNJMmrk59dYrsx/6FPs6uw+md1vf2nmkCoLmYgDZpKSfBDPZfgJeuPifSD82V9 qvHQhw17XlrIBu8qp3IqW9pg0WvqnrJ733SjRLNmlLvseOMRkN8w5hqtHjNf1uxEtwtafUIhokzc/ w2BTkOIMqnvjix2gVvP/646dthjQDG/PPHkxNn9BVbX3OSKvoBDHWisDPtGCS5N6V5++tU2BoSGKJ RK9p/lTG4ixx/mVPgYZkKDDMDCQCE9qZytcTzrbiwTZAxNlK1J0gg4YWDjoBywc2O7ftjwJfbax9H m3Cvs57dA==; Received: from 212095007060.public.telering.at ([212.95.7.60] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1cyZl3-0007ZF-N1 for linux-xfs@vger.kernel.org; Thu, 13 Apr 2017 08:05:38 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Subject: [PATCH 04/10] xfs: remove an unsafe retry in xfs_bmbt_alloc_block Date: Thu, 13 Apr 2017 10:05:11 +0200 Message-Id: <20170413080517.12564-5-hch@lst.de> X-Mailer: git-send-email 2.11.0 In-Reply-To: <20170413080517.12564-1-hch@lst.de> References: <20170413080517.12564-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP We've already reserved all possible required blocks and checked they are avaible in the same AG. Signed-off-by: Christoph Hellwig --- fs/xfs/libxfs/xfs_bmap_btree.c | 13 ------------- 1 file changed, 13 deletions(-) diff --git a/fs/xfs/libxfs/xfs_bmap_btree.c b/fs/xfs/libxfs/xfs_bmap_btree.c index 3e17ceda038c..ce41dd5fbb34 100644 --- a/fs/xfs/libxfs/xfs_bmap_btree.c +++ b/fs/xfs/libxfs/xfs_bmap_btree.c @@ -476,19 +476,6 @@ xfs_bmbt_alloc_block( if (error) goto error0; - if (args.fsbno == NULLFSBLOCK && args.minleft) { - /* - * Could not find an AG with enough free space to satisfy - * a full btree split. Try again and if - * successful activate the lowspace algorithm. - */ - args.fsbno = 0; - args.type = XFS_ALLOCTYPE_FIRST_AG; - error = xfs_alloc_vextent(&args); - if (error) - goto error0; - cur->bc_private.b.dfops->dop_low = true; - } if (WARN_ON_ONCE(args.fsbno == NULLFSBLOCK)) { XFS_BTREE_TRACE_CURSOR(cur, XBT_EXIT); *stat = 0;