From patchwork Mon Sep 25 19:56:25 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Wareing X-Patchwork-Id: 9970423 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B8784602D8 for ; Mon, 25 Sep 2017 19:56:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id AB7CF28861 for ; Mon, 25 Sep 2017 19:56:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A040A28892; Mon, 25 Sep 2017 19:56:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 37B3B28861 for ; Mon, 25 Sep 2017 19:56:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965951AbdIYT4b (ORCPT ); Mon, 25 Sep 2017 15:56:31 -0400 Received: from mx0a-00082601.pphosted.com ([67.231.145.42]:53122 "EHLO mx0a-00082601.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932107AbdIYT42 (ORCPT ); Mon, 25 Sep 2017 15:56:28 -0400 Received: from pps.filterd (m0109334.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v8PJqpxk011307 for ; Mon, 25 Sep 2017 12:56:26 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fb.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-type; s=facebook; bh=5JFsCbVVp2yOpAlGseV4/sn0saG9cG8otqzI7d4o5/Y=; b=ZowbIqeV5+2OtGHxi45/VfVF3fQadfQmJ45m9oBb2e56ekxiPLZ4hoIor+6n5swwhVit GADZLExpzAELLvQQX0tW1gchFmwPYdiJXKrebD/Xwt4UhojXpIuz2V0FF/onVrC0vHB3 7TQrtkk2rgvTGtRpAPzSPDVm/gCIrwjWdF0= Received: from mail.thefacebook.com ([199.201.64.23]) by mx0a-00082601.pphosted.com with ESMTP id 2d77rw05f9-2 (version=TLSv1 cipher=ECDHE-RSA-AES256-SHA bits=256 verify=NOT) for ; Mon, 25 Sep 2017 12:56:26 -0700 Received: from mx-out.facebook.com (192.168.52.123) by PRN-CHUB10.TheFacebook.com (192.168.16.20) with Microsoft SMTP Server id 14.3.319.2; Mon, 25 Sep 2017 12:56:26 -0700 Received: from devbig279.prn1.facebook.com (localhost [127.0.0.1]) by devbig279.prn1.facebook.com (Postfix) with ESMTP id C9573362074C; Mon, 25 Sep 2017 12:56:25 -0700 (PDT) Smtp-Origin-Hostprefix: devbig From: Richard Wareing Smtp-Origin-Hostname: devbig279.prn1.facebook.com To: CC: , Smtp-Origin-Cluster: prn1c29 Subject: [PATCH v2 3/3] xfs/realtime: Fix direct invocations of xfs_repair Date: Mon, 25 Sep 2017 12:56:25 -0700 Message-ID: <20170925195625.756877-3-rwareing@fb.com> X-Mailer: git-send-email 2.9.5 In-Reply-To: <20170925195625.756877-1-rwareing@fb.com> References: <20170925195625.756877-1-rwareing@fb.com> X-FB-Internal: Safe MIME-Version: 1.0 X-Proofpoint-Spam-Reason: safe X-FB-Internal: Safe X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:, , definitions=2017-09-25_08:, , signatures=0 Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes direct invocations of xfs_repair to add in -r option if required. Signed-off-by: Richard Wareing Reviewed-by: Darrick J. Wong --- Changes since v1: * Fixed kill -9 in test xfs/070 tests/xfs/070 | 3 ++- tests/xfs/291 | 3 ++- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/tests/xfs/070 b/tests/xfs/070 index 0ae6eff..a06e998 100755 --- a/tests/xfs/070 +++ b/tests/xfs/070 @@ -56,7 +56,8 @@ _cleanup() _xfs_repair_noscan() { # invoke repair directly so we can kill the process if need be - $XFS_REPAIR_PROG $SCRATCH_DEV 2>&1 | tee -a $seqres.full > $tmp.repair & + [ -n "$SCRATCH_RTDEV" ] && rt_repair_opts="-r $SCRATCH_RTDEV" + $XFS_REPAIR_PROG $rt_repair_opts $SCRATCH_DEV 2>&1 | tee -a $seqres.full > $tmp.repair & repair_pid=$! # monitor progress for as long as it is running diff --git a/tests/xfs/291 b/tests/xfs/291 index 3f5295c..140fa33 100755 --- a/tests/xfs/291 +++ b/tests/xfs/291 @@ -122,7 +122,8 @@ _xfs_check $SCRATCH_DEV >> $seqres.full 2>&1 || _fail "xfs_check failed" # Can xfs_metadump cope with this monster? _scratch_metadump $tmp.metadump || _fail "xfs_metadump failed" xfs_mdrestore $tmp.metadump $tmp.img || _fail "xfs_mdrestore failed" -xfs_repair -f $tmp.img >> $seqres.full 2>&1 || _fail "xfs_repair of metadump failed" +[ -n "$SCRATCH_RTDEV" ] && rt_repair_opts="-r $SCRATCH_RTDEV" +xfs_repair $rt_repair_opts -f $tmp.img >> $seqres.full 2>&1 || _fail "xfs_repair of metadump failed" # Yes it can; success, all done status=0