From patchwork Thu Sep 28 18:54:26 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Goldwyn Rodrigues X-Patchwork-Id: 9976675 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 449F0603F2 for ; Thu, 28 Sep 2017 18:54:38 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 3705529704 for ; Thu, 28 Sep 2017 18:54:38 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2B8F429706; Thu, 28 Sep 2017 18:54:38 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=2.0 tests=BAYES_00,RCVD_IN_DNSWL_HI autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CAC0729704 for ; Thu, 28 Sep 2017 18:54:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750902AbdI1Syh (ORCPT ); Thu, 28 Sep 2017 14:54:37 -0400 Received: from mx2.suse.de ([195.135.220.15]:53011 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750775AbdI1Syg (ORCPT ); Thu, 28 Sep 2017 14:54:36 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id A4E20AABA; Thu, 28 Sep 2017 18:54:35 +0000 (UTC) From: Goldwyn Rodrigues To: linux-xfs@vger.kernel.org Cc: david@fromorbit.com, Goldwyn Rodrigues Subject: [PATCH 3/3] Allow partial writes Date: Thu, 28 Sep 2017 13:54:26 -0500 Message-Id: <20170928185426.9070-3-rgoldwyn@suse.de> X-Mailer: git-send-email 2.14.1 In-Reply-To: <20170928185426.9070-1-rgoldwyn@suse.de> References: <20170928185426.9070-1-rgoldwyn@suse.de> Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Goldwyn Rodrigues Partial writes are performed when there is an error midway while performing the I/O. Perform the write exactly once and return the number of bytes written. Signed-off-by: Goldwyn Rodrigues --- io/io.h | 1 + io/pwrite.c | 25 ++++++++++++++++++++++++- man/man8/xfs_io.8 | 3 +++ 3 files changed, 28 insertions(+), 1 deletion(-) diff --git a/io/io.h b/io/io.h index 2bc7ac4a..5875e85a 100644 --- a/io/io.h +++ b/io/io.h @@ -24,6 +24,7 @@ #define IO_RANDOM ( 0) #define IO_FORWARD ( 1) #define IO_BACKWARD (-1) +#define IO_PARTIAL (2) /* * File descriptor options diff --git a/io/pwrite.c b/io/pwrite.c index 8289c3ee..40f537b3 100644 --- a/io/pwrite.c +++ b/io/pwrite.c @@ -47,6 +47,7 @@ pwrite_help(void) " -W -- call fsync(2) at the end (included in timing results)\n" " -B -- write backwards through the range from offset (backwards N bytes)\n" " -F -- write forwards through the range of bytes from offset (default)\n" +" -P -- return Partial writes, perform one call and return bytes written\n" " -R -- write at random offsets in the specified range of bytes\n" " -Z N -- zeed the random number generator (used when writing randomly)\n" " (heh, zorry, the -s/-S arguments were already in use in pwrite)\n" @@ -255,6 +256,22 @@ write_buffer( return ops; } +static int +write_partial( + off64_t offset, + long long count, + long long *total, + int pwritev2_flags) +{ + size_t bytes; + bytes = do_pwrite(file->fd, offset, count, count, pwritev2_flags); + if (bytes < 0) + return -1; + *total = bytes; + return 1; +} + + static int pwrite_f( int argc, @@ -276,7 +293,7 @@ pwrite_f( init_cvtnum(&fsblocksize, &fssectsize); bsize = fsblocksize; - while ((c = getopt(argc, argv, "b:BCdf:Fi:NqRs:S:uV:wWZ:")) != EOF) { + while ((c = getopt(argc, argv, "b:BCdf:Fi:NqRs:PS:uV:wWZ:")) != EOF) { switch (c) { case 'b': tmp = cvtnum(fsblocksize, fssectsize, optarg); @@ -298,6 +315,9 @@ pwrite_f( case 'R': direction = IO_RANDOM; break; + case 'P': + direction = IO_PARTIAL; + break; case 'd': dflag = 1; break; @@ -389,6 +409,9 @@ pwrite_f( case IO_BACKWARD: c = write_backward(offset, &count, &total, pwritev2_flags); break; + case IO_PARTIAL: + c = write_partial(offset, count, &total, pwritev2_flags); + break; default: total = 0; ASSERT(0); diff --git a/man/man8/xfs_io.8 b/man/man8/xfs_io.8 index f410ce9a..b21a8145 100644 --- a/man/man8/xfs_io.8 +++ b/man/man8/xfs_io.8 @@ -229,6 +229,9 @@ write the buffers in a reserve sequential direction. .B \-R write the buffers in the give range in a random order. .TP +.B \-P +return Partial writes, perform one call and return the bytes written. +.TP .B \-Z seed specify the random number seed used for random write .TP