From patchwork Thu Nov 9 13:26:52 2017 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Christoph Hellwig X-Patchwork-Id: 10050895 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id ACE3360381 for ; Thu, 9 Nov 2017 13:27:10 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 985E52ABDA for ; Thu, 9 Nov 2017 13:27:10 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 8D3E22ABE0; Thu, 9 Nov 2017 13:27:10 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_HI,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 2DDDA2ABDA for ; Thu, 9 Nov 2017 13:27:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754463AbdKIN1J (ORCPT ); Thu, 9 Nov 2017 08:27:09 -0500 Received: from bombadil.infradead.org ([65.50.211.133]:43908 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754436AbdKIN1J (ORCPT ); Thu, 9 Nov 2017 08:27:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=References:In-Reply-To:Message-Id: Date:Subject:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=2Ae/FHK0H5QhWPCOvszG4NMcMfPekeiB7lmoiRFvln4=; b=HwBirMQt/IKd6T53qRp+cJRcA 4UTZNob9M64NaufsWkscOPE/Mytpnz2zkAY6Cspdum9CeiYRaD0JMMtkHr0irGb89U09enRgf4UZc CW4vIj+P2JKwBFM5ilYbpdB1aV+ZAzHQ4Bg/gIgm7WTOm7M8ZYHhGCYq1PtI9EJz1o2IF6TRcR1Tm Pw9FcI2CZg2K3el6YT63azY5hnLiY8n6MYYlMwnrNkaJxuiRIMdzoghdPWz0zITZzdH+4NfXyb1e/ ya+8h31GmCCCRCRyK5p3gg644dEpxiQhxv9urUB71ONhPfJ7xpEfOJaITk99bRMJuRd8h5RotA6ta gBm09Qpuw==; Received: from 80-109-164-210.cable.dynamic.surfer.at ([80.109.164.210] helo=localhost) by bombadil.infradead.org with esmtpsa (Exim 4.87 #1 (Red Hat Linux)) id 1eCmrM-0002Xv-Jz; Thu, 09 Nov 2017 13:27:09 +0000 From: Christoph Hellwig To: linux-xfs@vger.kernel.org Cc: bfoster@redhat.com Subject: [PATCH 2/6] xfs: add some comments to xfs_iext_insert/xfs_iext_insert_node Date: Thu, 9 Nov 2017 14:26:52 +0100 Message-Id: <20171109132656.1649-3-hch@lst.de> X-Mailer: git-send-email 2.14.2 In-Reply-To: <20171109132656.1649-1-hch@lst.de> References: <20171109132656.1649-1-hch@lst.de> X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-xfs-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-xfs@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Reported-by: Brian Foster Signed-off-by: Christoph Hellwig --- fs/xfs/libxfs/xfs_iext_tree.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/fs/xfs/libxfs/xfs_iext_tree.c b/fs/xfs/libxfs/xfs_iext_tree.c index 85d7f708eafc..c28a24aca9c5 100644 --- a/fs/xfs/libxfs/xfs_iext_tree.c +++ b/fs/xfs/libxfs/xfs_iext_tree.c @@ -525,6 +525,10 @@ xfs_iext_insert_node( if (nr_entries == KEYS_PER_NODE) new = xfs_iext_split_node(&node, &pos, &nr_entries); + /* + * Update the pointers in higher levels if the first entry changes + * in an existing node. + */ if (node != new && pos == 0 && nr_entries > 0) xfs_iext_update_node(ifp, node->keys[0], offset, level, node); @@ -643,6 +647,10 @@ xfs_iext_insert( if (nr_entries == RECS_PER_LEAF) new = xfs_iext_split_leaf(cur, &nr_entries); + /* + * Update the pointers in higher levels if the first entry changes + * in an existing node. + */ if (cur->leaf != new && cur->pos == 0 && nr_entries > 0) { xfs_iext_update_node(ifp, xfs_iext_leaf_key(cur->leaf, 0), offset, 1, cur->leaf);