| Message ID | 20171127202434.43125-2-bfoster@redhat.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
On Mon, Nov 27, 2017 at 03:24:31PM -0500, Brian Foster wrote: > The transaction dump code displays the content and reservation > consumption of a particular transaction in the event of an overrun. > It currently displays the reservation associated with the > transaction ticket, but not the original reservation attached to the > transaction. > > The latter value reflects the original transaction reservation > calculation before additional reservation overhead is assigned, such > as for the CIL context header and potential split region headers. > > Update xlog_print_trans() to also print the original transaction > reservation in the event of overrun. This provides a reference point > to identify how much reservation overhead was added to a particular > ticket by xfs_log_calc_unit_res(). > > Signed-off-by: Brian Foster <bfoster@redhat.com> > --- > fs/xfs/xfs_log.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c > index 38d4227895ae..3a37fa1ed25e 100644 > --- a/fs/xfs/xfs_log.c > +++ b/fs/xfs/xfs_log.c > @@ -2117,7 +2117,9 @@ xlog_print_trans( > > /* dump core transaction and ticket info */ > xfs_warn(mp, "transaction summary:"); > - xfs_warn(mp, " flags = 0x%x", tp->t_flags); > + xfs_warn(mp, " log res = %d", tp->t_log_res); > + xfs_warn(mp, " log count = %d", tp->t_log_count); > + xfs_warn(mp, " flags = 0x%x", tp->t_flags); > > xlog_print_tic_res(mp, tp->t_ticket); Looks fine. Reviewed-by: Dave Chinner <dchinner@redhat.com>
diff --git a/fs/xfs/xfs_log.c b/fs/xfs/xfs_log.c index 38d4227895ae..3a37fa1ed25e 100644 --- a/fs/xfs/xfs_log.c +++ b/fs/xfs/xfs_log.c @@ -2117,7 +2117,9 @@ xlog_print_trans( /* dump core transaction and ticket info */ xfs_warn(mp, "transaction summary:"); - xfs_warn(mp, " flags = 0x%x", tp->t_flags); + xfs_warn(mp, " log res = %d", tp->t_log_res); + xfs_warn(mp, " log count = %d", tp->t_log_count); + xfs_warn(mp, " flags = 0x%x", tp->t_flags); xlog_print_tic_res(mp, tp->t_ticket);
The transaction dump code displays the content and reservation consumption of a particular transaction in the event of an overrun. It currently displays the reservation associated with the transaction ticket, but not the original reservation attached to the transaction. The latter value reflects the original transaction reservation calculation before additional reservation overhead is assigned, such as for the CIL context header and potential split region headers. Update xlog_print_trans() to also print the original transaction reservation in the event of overrun. This provides a reference point to identify how much reservation overhead was added to a particular ticket by xfs_log_calc_unit_res(). Signed-off-by: Brian Foster <bfoster@redhat.com> --- fs/xfs/xfs_log.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)