diff mbox

[3/7] mkfs: protofile only needs to be set up once

Message ID 20171218091158.14537-4-david@fromorbit.com (mailing list archive)
State Accepted
Headers show

Commit Message

Dave Chinner Dec. 18, 2017, 9:11 a.m. UTC 
From: Dave Chinner <dchinner@redhat.com>

Signed-Off-By: Dave Chinner <dchinner@redhat.com>
---
 mkfs/xfs_mkfs.c | 2 --
 1 file changed, 2 deletions(-)

Comments

Darrick J. Wong Dec. 20, 2017, 2:48 a.m. UTC | #1 
On Mon, Dec 18, 2017 at 08:11:54PM +1100, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
> 
> Signed-Off-By: Dave Chinner <dchinner@redhat.com>

Looks ok,
Reviewed-by: Darrick J. Wong <darrick.wong@oracle.com>

> ---
>  mkfs/xfs_mkfs.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index 4a9c457ce603..7cc5ee2ddb9d 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -4024,8 +4024,6 @@ main(
>  	 */
>  	calculate_log_size(&cfg, &cli, mp);
>  
> -	protostring = setup_proto(protofile);
> -
>  	if (!quiet || dry_run) {
>  		print_mkfs_cfg(&cfg, dfile, logfile, rtfile);
>  		if (dry_run)
> -- 
> 2.15.0
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
index 4a9c457ce603..7cc5ee2ddb9d 100644
--- a/mkfs/xfs_mkfs.c
+++ b/mkfs/xfs_mkfs.c
@@ -4024,8 +4024,6 @@  main(
 	 */
 	calculate_log_size(&cfg, &cli, mp);
 
-	protostring = setup_proto(protofile);
-
 	if (!quiet || dry_run) {
 		print_mkfs_cfg(&cfg, dfile, logfile, rtfile);
 		if (dry_run)